Merged
Conversation
Documentation: Fix getting started guide
THinnerichs
previously requested changes
Apr 2, 2025
Member
Author
|
#169 has to be addressed first. |
ReubenJ
approved these changes
Jul 17, 2025
Member
ReubenJ
left a comment
ReubenJ
left a comment
There was a problem hiding this comment.
Just noticed the odd ticks in the installation guide. Feel free to merge with to without the change. We can address that in another PR if you merge without it.
docs/src/install.md
Outdated
| ``` | ||
|
|
||
| which will both install all dependencies automatically. | ||
| `which` will both install all dependencies automatically. |
Member
There was a problem hiding this comment.
Does this need to be in `...`s?
|
|
||
| And just like this you are done! Welcome to Herb.jl! | ||
|
|
||
| ## Julia How-To |
Member
There was a problem hiding this comment.
I think I'd like to remove this in the future and point somewhere that's maintained by the Julia team, but for now we can leave it
ReubenJ
approved these changes
Jul 22, 2025
pwochner
dismissed
THinnerichs’s stale review
Requested changes to fix indentation have been addressed. In addition, Reuben reviewed PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the documentation workflow to remove Python dependencies since we've fully migrated from Jupyter notebooks to Pluto.jl, and to build docs from
masterbranch. Changes include:mastermasterbranch.PlutoUI(caused dependency errors and was only used for displaying a table of contents in Pluto notebooks)addconstraint!(implementissameandis_domain_validfor custom constraint in tutorial)Closes #135
Closes #170