refs #41

* pthread attribute becomes a class attribute

Author: Herbert Koelman

include/pthread/thread.hpp

@@ -167,6 +167,7 @@ namespace pthread {
     void swap ( thread& other );
 
     pthread_t      _thread;
+    pthread_attr_t _attr;
 
     thread_status  _status;
   };

src/thread.cpp

@@ -61,26 +61,24 @@ namespace pthread {
 
   thread::thread (const runnable &work, const std::size_t stack_size ): thread(){ // ": thread()" calls the related anonymous constructor
     int rc = 0 ;
-    pthread_attr_t attr;
 
     /* Initialize and set thread detached attribute */
-    if ( (rc = pthread_attr_init(&attr)) != 0){
+    if ( (rc = pthread_attr_init(&_attr)) != 0){
       throw thread_exception("pthread_attr_init failed.", rc );
     }
 
-    if ( (rc = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_JOINABLE)) != 0 ){
+    if ( (rc = pthread_attr_setdetachstate(&_attr, PTHREAD_CREATE_JOINABLE)) != 0 ){
       throw thread_exception("pthread_attr_setdetachstate failed.", rc );
     }
 
-    if ( stack_size > 0 && (rc = pthread_attr_setstacksize(&attr, stack_size)) != 0 ){
+    if ( stack_size > 0 && (rc = pthread_attr_setstacksize(&_attr, stack_size)) != 0 ){
       throw thread_exception("pthread_attr_setstacksize failed.", rc );
     }
 
-    if ((rc = pthread_create(&_thread, &attr, thread_startup_runnable, (void *) &work)) != 0){
+    if ((rc = pthread_create(&_thread, &_attr, thread_startup_runnable, (void *) &work)) != 0){
       throw thread_exception("pthread_create failed.", rc );
     } else {
       _status = thread_status::a_thread;
-      pthread_attr_destroy(&attr);
     }
 
   }
@@ -91,6 +89,10 @@ namespace pthread {
     swap(other);
   }
 
+  thread::~thread () {
+      pthread_attr_destroy(&_attr);
+  }
+  
   /* move operator */
   thread& thread::operator=(thread&& other){
 
@@ -104,9 +106,6 @@ namespace pthread {
     std::swap(_status, other._status);
   }
 
-  thread::~thread () {
-  }
-  
   abstract_thread::abstract_thread(const std::size_t stack_size): _stack_size(stack_size){
   }
 

tests/without-cpp11-pthread-tests.cpp

@@ -111,6 +111,6 @@ int main(int argc, const char * argv[]) {
   } catch ( ... ){
     message("Unhandled exception was thrown in main");
   }
-  pthread::this_thread::sleep(10*1000); // sleep 10 seconds
+  pthread::this_thread::sleep(5*1000); // sleep 10 seconds
   message( "end reached");
 }