fixes #150 @2h

Author: HerbertKoelman

.gitignore

@@ -1,85 +1,49 @@
-# Compiled Object files
-*.slo
-*.lo
-*.o
-*.obj
-core
-
-# Precompiled Headers
-*.gch
-*.pch
+# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and WebStorm
+# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
 
-# Compiled Dynamic libraries
-*.so
-*.dylib
-*.dll
+# build directories
+target/**
+build/**
+cmake-build*/
+delivery/**
 
-# Fortran module files
-*.mod
+# SONAR Qube related working directories
+.scannerwork
 
-# Compiled Static libraries
-*.dSYM
-*.lai
-*.la
+# extension
+*.swp
+*.o
 *.a
-*.lib
-
-# Executables
-*.exe
-*.out
-*.app
-tests/*tests
+*.so
+*.class
+*.dll
 
-# emacs
-*~
+# IDE related stiff
+.idea/**
 
-# Xcode
-*.xcodeproj/
-DerivedData/
+# File-based project format
+*.iws
 
-# MAc OS X
-.DS_Store
-*.icloud
+# IntelliJ
+out/
 
-# MAc OS X
-.DS_Store
-._*
+# JIRA plugin
+atlassian-ide-plugin.xml
 
-# Code check
-.sonar
+# Crashlytics plugin (for Android Studio and IntelliJ)
+com_crashlytics_export_strings.xml
+crashlytics.properties
+crashlytics-build.properties
+fabric.properties
 
-# autoconf
+# special files
 config.h
-autom4te.cache
-config.status
-config.log
-Makefile
 
-# IDEA
-.idea
-
-# CMake
-*build*
+.DS_Store
+doc
 
-CMakeCache.txt
-CMakeFiles
-CMakeScripts
-Testing
-Makefile
-cmake_install.cmake
-install_manifest.txt
-compile_commands.json
-CTestTestfile.cmake
+*.xcode*
 
-# layout
-.scannerwork
-doxyfile
-*.tar
-sonar-project.properties
-distrib/
-lib/
-doc/
 *-tests
+*_tests
 
-# Images
-*.png

include/pthread/condition_variable.hpp

@@ -188,6 +188,11 @@ namespace pthread {
     void notify_all () noexcept ;
 #endif
 
+    /**
+     * not copy-assignable
+     */
+     void operator=( const condition_variable &) = delete;
+
     // constructor/destructor ------------------------------------------------
 
     condition_variable ();
@@ -197,7 +202,7 @@ namespace pthread {
     void milliseconds( int milliseconds);
 
     timespec timeout;
-    pthread_cond_t _condition;
+    pthread_cond_t _condition; //!< NOSONAR this union is declared in the POSIX Threading library. It cannot be changed (ignoring rule MISRA C++:2008, 9-5-1 - Unions shall not be used.)
   };
 
   /** @} */

include/pthread/lock_guard.hpp

@@ -53,9 +53,14 @@ namespace pthread {
 
     /** The destructor release the guarded mutex.
      */
-   ~lock_guard() {
+    ~lock_guard() {
       _mutex->unlock();
-   }
+    }
+
+    /**
+     * Cannot be copied.
+     */
+    lock_guard( const lock_guard &) = delete;
 
     /** @return a const reference to the guarded mutex
      *

include/pthread/mutex.hpp

@@ -21,58 +21,72 @@
 
 namespace pthread {
 
-  /** \addtogroup concurrency
-   *
-   * @{
-   */
-  class condition_variable;
-
-  /** The mutex class is a synchronization primitive that can be used to protect shared data from being simultaneously accessed by multiple threads.
-   *
-   * @author herbert koelman
-   * @date 18/3/2016
-   */
-  class mutex {
-
-    friend class condition_variable;
-
-  public:
-    /**
-     The mutex object is locked (by calling pthread_mutex_lock). If the mutex is already locked, the calling thread blocks until the mutex becomes
-     available. This operation returns with the mutex object referenced by mutex in the locked state with the calling thread as its owner.
-     @throw mutex_exception if error conditions preventing this method to succeed.
+    /** \addtogroup concurrency
+     *
+     * @{
      */
-    void lock ();
 
-    /**
-     The function pthread_mutex_trylock is identical to pthread_mutex_lock except tha
-     if the mutex object referenced by mutex is currently locked (by any thread,
-     including the current thread), the call returns immediately.
+    class condition_variable;
 
-     @throw mutex_exception if error conditions preventing this method to succeed.
-     @see lock
+    /** The mutex class is a synchronization primitive that can be used to protect shared data from being simultaneously accessed by multiple threads.
+     *
+     * @author herbert koelman
+     * @date 18/3/2016
      */
-    void try_lock ();
-
-    /**
-     The pthread_mutex_unlock function releases the mutex object referenced by mutex.  The manner in which a mutex is released is dependent upon the mutex's type attribute. If there are threads blocked on the mutex object referenced by mutex when unlock is called, resulting in the mutex becoming available, the scheduling policy is used to determine which thread shall acquire the mutex.
-     @throw mutex_exception if error conditions preventing this method to succeed.
-     */
-    void unlock ();
-
-    /*
-     Constructor/Desctructor
-     @throw mutex_exception if error conditions preventing this method to succeed.
-     */
-    mutex ();
-    virtual ~mutex ();
-
-  protected:
-    /** pthread mutex structure */
-    pthread_mutex_t _mutex;
-  };
-
-  /** @} */
+    class mutex {
+
+        friend class condition_variable;
+
+    public:
+        /**
+         The mutex object is locked (by calling pthread_mutex_lock). If the mutex is already locked, the calling thread blocks until the mutex becomes
+         available. This operation returns with the mutex object referenced by mutex in the locked state with the calling thread as its owner.
+         @throw mutex_exception if error conditions preventing this method to succeed.
+         */
+        void lock();
+
+        /**
+         The function pthread_mutex_trylock is identical to pthread_mutex_lock except tha
+         if the mutex object referenced by mutex is currently locked (by any thread,
+         including the current thread), the call returns immediately.
+
+         @throw mutex_exception if error conditions preventing this method to succeed.
+         @see lock
+         */
+        void try_lock();
+
+        /**
+         The pthread_mutex_unlock function releases the mutex object referenced by mutex.  The manner in which a mutex is released is dependent upon the mutex's type attribute. If there are threads blocked on the mutex object referenced by mutex when unlock is called, resulting in the mutex becoming available, the scheduling policy is used to determine which thread shall acquire the mutex.
+         @throw mutex_exception if error conditions preventing this method to succeed.
+         */
+        void unlock();
+
+        /**
+         Constructor/Desctructor
+         @throw mutex_exception if error conditions preventing this method to succeed.
+         */
+        mutex();
+
+        /** not copy-assignable, so no copy contructor is needed.
+         *
+         */
+        mutex(const mutex &) = delete;
+        /**
+         * destroys the mutes (pthread_mutex_destroy)
+         */
+        virtual ~mutex();
+
+        /** not copy-assignable
+         *
+         */
+        void operator=(const mutex &) = delete;
+
+    protected:
+        /** pthread mutex structure */
+        pthread_mutex_t _mutex;
+    };
+
+    /** @} */
 
 } // namespace pthread