Dont store strong references to Navigation and TabBarController delegates (#516)

mkieselmann · SD10 · commit 2d5de7404ae3 · 2018-08-29T15:30:46.000-05:00
Holding strong references leads to reference cycles if the delegate is set to self.
diff --git a/Sources/Extensions/UIViewController+Hero.swift b/Sources/Extensions/UIViewController+Hero.swift
@@ -28,8 +28,8 @@ internal class HeroViewControllerConfig: NSObject {
   var tabBarAnimation: HeroDefaultAnimationType = .auto
 
   var storedSnapshot: UIView?
-  var previousNavigationDelegate: UINavigationControllerDelegate?
-  var previousTabBarDelegate: UITabBarControllerDelegate?
+  weak var previousNavigationDelegate: UINavigationControllerDelegate?
+  weak var previousTabBarDelegate: UITabBarControllerDelegate?
 }
 
 extension UIViewController: HeroCompatible { }

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,8 @@ internal class HeroViewControllerConfig: NSObject {`
`28`	`28`	`var tabBarAnimation: HeroDefaultAnimationType = .auto`
`29`	`29`
`30`	`30`	`var storedSnapshot: UIView?`
`31`		`- var previousNavigationDelegate: UINavigationControllerDelegate?`
`32`		`- var previousTabBarDelegate: UITabBarControllerDelegate?`
	`31`	`+ weak var previousNavigationDelegate: UINavigationControllerDelegate?`
	`32`	`+ weak var previousTabBarDelegate: UITabBarControllerDelegate?`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`extension UIViewController: HeroCompatible { }`