[Feat] (Auto-)Updater improvements (#4830)

* Support auto-updates of the AppImage version

* Still show the update message if the auto-updater isn't supported

Ideally we'd show a packaging format-specific message here, but this is still
better than no message at all

Author: CommandMC

public/locales/en/translation.json

@@ -107,6 +107,7 @@
         "info": {
             "update": {
                 "detail": "Do you want to download the update in the background?",
+                "detailNoAutoupdate": "Automatic updates are not supported for your packaging format. Please use your package manager to update.",
                 "message": "There is a new Version available!",
                 "message-finished": "Do you want to restart Heroic now?",
                 "title": "Heroic Games Launcher",

src/backend/constants/environment.ts

@@ -18,3 +18,4 @@ export const isFlatpak = Boolean(env.FLATPAK_ID)
 export const isSnap = Boolean(env.SNAP)
 export const isAppImage = Boolean(env.APPIMAGE)
 export const flatpakRuntimeVersion = env.FLATPAK_RUNTIME_VERSION
+export const autoUpdateSupported = isWindows || isMac || isAppImage

src/backend/main.ts

@@ -257,7 +257,7 @@ async function initializeWindow(): Promise<BrowserWindow> {
   } else {
     Menu.setApplicationMenu(null)
     mainWindow.loadFile(join(publicDir, 'index.html'))
-    if (globalConf.checkForUpdatesOnStartup && !isLinux) {
+    if (globalConf.checkForUpdatesOnStartup) {
       autoUpdater.checkForUpdates()
     }
   }

src/backend/updater.ts

@@ -5,31 +5,46 @@ import { t } from 'i18next'
 import { showDialogBoxModalAuto } from './dialog/dialog'
 import { logError, LogPrefix } from './logger'
 import { windowIcon } from './constants/paths'
-import { isLinux } from './constants/environment'
+import { autoUpdateSupported } from './constants/environment'
 
 autoUpdater.autoDownload = false
 autoUpdater.autoInstallOnAppQuit = false
 
 async function showAutoupdateDialog() {
-  if (isLinux) {
-    return
-  }
+  let messageDetail
+  let buttons
 
-  const { response } = await dialog.showMessageBox({
-    title: t('box.info.update.title', 'Heroic Games Launcher'),
-    message: t('box.info.update.message', 'There is a new Version available!'),
-    detail: t(
+  if (autoUpdateSupported) {
+    messageDetail = t(
       'box.info.update.detail',
       'Do you want to download the update in the background?'
-    ),
-
-    icon: nativeImage.createFromPath(windowIcon),
-    buttons: [
+    )
+    buttons = [
       t('box.update', 'Update'),
       t('box.postpone', 'Postpone'),
       t('box.changelog', 'Changelog')
     ]
+  } else {
+    messageDetail = t(
+      'box.info.update.detailNoAutoupdate',
+      'Automatic updates are not supported for your packaging format. Please use your package manager to update.'
+    )
+    buttons = [t('box.ok'), t('box.changelog', 'Changelog')]
+  }
+
+  let { response } = await dialog.showMessageBox({
+    title: t('box.info.update.title', 'Heroic Games Launcher'),
+    message: t('box.info.update.message', 'There is a new Version available!'),
+    detail: messageDetail,
+
+    icon: nativeImage.createFromPath(windowIcon),
+    buttons
   })
+
+  // "Ok" button becomes "Postpone" (to just close the dialog), "Changelog" gets
+  // the correct index (1 -> 2)
+  if (!autoUpdateSupported) response++
+
   if (response === 0) {
     autoUpdater.downloadUpdate()
   }