Version 5.3.0.0

Author: rajeevkallur

src/redfish/__init__.py

@@ -1,7 +1,7 @@
 """ Redfish restful library """
 
 __all__ = ["rest", "ris", "hpilo"]
-__version__ = "5.2.0.0"
+__version__ = "5.3.0.0"
 
 import logging
 

src/redfish/hpilo/rishpilo.py

@@ -135,7 +135,9 @@ def __init__(self, dll=None, log_dir=None):
                 if status != BlobReturnCodes.SUCCESS:
                     errmsg = "Error {0} occurred while trying to open a " "channel to iLO".format(status)
                     if status == BlobReturnCodes.CHIFERR_NoDriver:
-                        errmsg = "chif"
+                        errmsg = "No devices were found."
+                        if os.name != "nt":
+                            errmsg = "{0} Ensure the hpilo kernel module is loaded.".format(errmsg)
                     elif status == BlobReturnCodes.CHIFERR_AccessDenied:
                         errmsg = "You must be root/Administrator to use this program."
                     raise HpIloInitialError(errmsg)

src/redfish/rest/v1.py

@@ -478,12 +478,15 @@ def _session_login(self):
         else:
             self.session_key = self.connection.session_key
 
-        if "OneTimePasscodeSent" in self.login_response:
-            raise OneTimePasscodeError()
-        elif "UnauthorizedLogin" in self.login_response:
-            raise UnauthorizedLoginAttemptError("Error "+str(self.login_return_code)+". Login is unauthorized.\nPlease check the credentials/OTP entered.\n")
-        elif "TokenExpired" in self.login_response:
-            raise TokenExpiredError("Error "+str(self.login_return_code)+". The OTP entered has expired. Please enter credentials again.\n")
+        if hasattr(self, "login_response") and self.login_response:
+            if "OneTimePasscodeSent" in self.login_response:
+                raise OneTimePasscodeError()
+            elif "UnauthorizedLogin" in self.login_response:
+                raise UnauthorizedLoginAttemptError("Error " + str(
+                    self.login_return_code) + ". Login is unauthorized.\nPlease check the credentials/OTP entered.\n")
+            elif "TokenExpired" in self.login_response:
+                raise TokenExpiredError("Error " + str(
+                    self.login_return_code) + ". The OTP entered has expired. Please enter credentials again.\n")
         elif not self.session_key and not resp.status == 200:
             self._credential_err()
         else:

src/redfish/ris/resp_handler.py

@@ -283,7 +283,10 @@ def verbosity_levels(
                 + "\n"
             )
         else:
-            return ""
+            if response_status == 400:
+                return "" + message + "\n"
+            else:
+                return ""
 
     # unused? (removal pending)
     @staticmethod

src/redfish/ris/rmc.py

@@ -773,9 +773,10 @@ def commit(self):
                     merge_dict(totpayload, payload)
                 currdict = copy.deepcopy(totpayload)
             if "PersistentBootConfigOrder" in currdict and type(currdict) is dict:
-                currdict = list(set(currdict["PersistentBootConfigOrder"]))
-                default_value = 0
-                currdict = {key: default_value for key in currdict}
+                refdict = list(set(currdict["PersistentBootConfigOrder"]))
+                items = list(currdict["PersistentBootConfigOrder"])
+                items_to_keep = items[: int(len(refdict))]
+                currdict = {"PersistentBootConfigOrder": items_to_keep}
             if currdict:
                 yield instance.resp.request.path
 
@@ -905,6 +906,13 @@ def get_handler(
                 results = self.current_client.get(get_path, headers=headers)
 
         if results and getattr(results, "status", None) and results.status == 404:
+            if not silent:
+                if hasattr(self.typepath.defs, "messageregistrytype"):
+                    ResponseHandler(self.validationmanager, self.typepath.defs.messageregistrytype).output_resp(
+                        results, dl_reg=service, verbosity=self.verbose
+                    )
+                else:
+                    print_handler("[" + str(results.status) + "]" + " The operation completed successfully.\n")
             return results
 
         if results and results.status == 200 and sessionid: