feat: added index to table, with agent migration skill

Author: jhirschibar

.agent/workflows/migrate.md

@@ -0,0 +1,18 @@
+---
+description: Detects changes in database schema/models, generates an Alembic migration with a descriptive name
+---
+
+# Database Migration Skill
+
+## Instructions
+
+1.  **Analyze Changes**: Review the recent changes made to the SQLAlchemy models or schema definitions in the codebase.
+2.  **Generate Name**: Create a concise, snake_case migration message (slug) that summarizes the changes (e.g., `add_user_profile_table`, `add_index_to_orders`, `remove_legacy_columns`).
+3.  **Create Revision**: Run the following command in the terminal, replacing `<message>` with the generated name:
+    ```bash
+    uv run alembic revision --autogenerate -m "<message>"
+    ```
+4.  **Apply Upgrade**: Once the revision is created successfully, run the following command to apply the changes:
+    ```bash
+    uv run alembic upgrade head
+    ```

alembic/versions/bdf5943aa4f5_add_composite_index_silver_mbo.py

@@ -0,0 +1,28 @@
+"""add_composite_index_silver_mbo
+
+Revision ID: bdf5943aa4f5
+Revises: 5f9dbb4c8034
+Create Date: 2026-02-12 17:38:13.593991
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision = 'bdf5943aa4f5'
+down_revision = '5f9dbb4c8034'
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.create_index('ix_silver_mbo_symbol_ts_action', 'silver_futures_mbo', ['symbol', 'ts_event', 'action'], unique=False)
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_index('ix_silver_mbo_symbol_ts_action', table_name='silver_futures_mbo')
+    # ### end Alembic commands ###

curator/db_tools/queries.py

@@ -1,7 +1,8 @@
+from collections.abc import Sequence
 from datetime import datetime
 
 import pandas as pd
-from sqlalchemy import case, delete, func, or_, select, update
+from sqlalchemy import Row, case, delete, func, or_, select, update
 from sqlalchemy.dialects.postgresql import insert
 from sqlalchemy.ext.asyncio import AsyncSession
 
@@ -70,7 +71,7 @@ async def query_options_tickers(
     months_hist: int = 24,
     all_=False,
     unexpired=False,
-) -> list[OptionsTickerModel]:
+) -> Sequence[Row]:
     """
     This is to pull all options contracts for a given underlying ticker.
     The batch input is to only pull o_ticker_ids for given o_tickers
@@ -103,12 +104,12 @@ async def query_options_tickers(
 
 
 @Session
-async def query_stock_tickers(session: AsyncSession, all_: bool = True, tickers: list[str] = []) -> list[TickerModel]:
+async def query_stock_tickers(session: AsyncSession, tickers: list[str], all_: bool = True) -> list[TickerModel]:
     """only returns tickers likely to have options contracts"""
     stmt = select(StockTickers.id, StockTickers.ticker).where(StockTickers.type.in_(["ADRC", "ETF", "CS"]))
     if not all_:
         stmt = stmt.where(StockTickers.ticker.in_(tickers))
-    return (await session.execute(stmt)).all()
+    return (await session.execute(stmt)).all()  # type: ignore
 
 
 @Session
@@ -128,8 +129,8 @@ async def ticker_imported(session: AsyncSession, ticker_id: int):
 async def update_stock_metadata(session: AsyncSession, data: list[TickerModel]):
     df = pd.DataFrame(data)
     df = df.drop_duplicates(subset=["ticker"], keep="last")
-    data = df.to_dict(orient="records")
-    stmt = insert(StockTickers).values(data)
+    clean_data = df.to_dict(orient="records")
+    stmt = insert(StockTickers).values(clean_data)
     stmt = stmt.on_conflict_do_update(
         index_elements=["ticker"],
         set_=dict(
@@ -242,7 +243,7 @@ async def delete_stock_ticker(session: AsyncSession, ticker: str):
 
 
 @Session
-async def latest_date_per_ticker(session: AsyncSession, tickers: list[str] = [], options=False):
+async def latest_date_per_ticker(session: AsyncSession, tickers: list[str], options=False):
     """query to retrieve the most recent date of record for ticker data (prices/quotes for stock/options).
     If tickers is [] empty, return all
     """

curator/db_tools/schemas.py

@@ -12,6 +12,7 @@
     Column,
     Enum,
     ForeignKey,
+    Index,
     Integer,
     String,
     UniqueConstraint,
@@ -249,7 +250,10 @@ class SilverFuturesMBO(Base):
     """
 
     __tablename__ = "silver_futures_mbo"
-    __table_args__ = (UniqueConstraint("ts_event", "order_id", "sequence", name="uq_silver_mbo_event"),)
+    __table_args__ = (
+        UniqueConstraint("ts_event", "order_id", "sequence", name="uq_silver_mbo_event"),
+        Index("ix_silver_mbo_symbol_ts_action", "symbol", "ts_event", "action"),
+    )
 
     id = Column(BigInteger, primary_key=True, autoincrement=True)
     ts_recv = Column(DateTime, nullable=False)