`puter.apps.getDeveloperProfile()` doesn't do anything

[reynaldichernando]

hi team, seems like the getDeveloperProfile method isn't doing anything, as it's not resolving or rejecting the promise
furthermore, we have duplicated code for how we handle the options

puter/src/puter-js/src/modules/Apps.js

Lines 197 to 235 in 9d307d5

	getDeveloperProfile = function (...args) {
	let options;
	// If first argument is an object, it's the options
	if ( typeof args[0] === 'object' && args[0] !== null ) {
	options = args[0];
	} else {
	// Otherwise, we assume separate arguments are provided
	options = {
	success: args[0],
	error: args[1],
	};
	}
	return new Promise((resolve, reject) => {
	let options;
	// If first argument is an object, it's the options
	if ( typeof args[0] === 'object' && args[0] !== null ) {
	options = args[0];
	} else {
	// Otherwise, we assume separate arguments are provided
	options = {
	success: args[0],
	error: args[1],
	};
	}
	return new Promise((resolve, reject) => {
	const xhr = utils.initXhr('/get-dev-profile', puter.APIOrigin, puter.authToken, 'get');
	// set up event handlers for load and error events
	utils.setupXhrEventHandlers(xhr, options.success, options.error, resolve, reject);
	xhr.send();
	});
	});
	};
	}

we have promise double wrapped, and i think the outer promise don't get resolved

[reynaldichernando]

proposed change:

getDeveloperProfile = function (...args) {
    let options;

    // If first argument is an object, it's the options
    if ( typeof args[0] === 'object' && args[0] !== null ) {
        options = args[0];
    } else {
        // Otherwise, we assume separate arguments are provided
        options = {
            success: args[0],
            error: args[1],
        };
    }

    return new Promise((resolve, reject) => {
        const xhr = utils.initXhr('/get-dev-profile', puter.APIOrigin, puter.authToken, 'get');

        // set up event handlers for load and error events
        utils.setupXhrEventHandlers(xhr, options.success, options.error, resolve, reject);

        xhr.send();
    });
};

i don't have context what the method does though, but this seems sensible

[ProgrammerIn-wonderland]

this makes sense, can you put this in a PR?

[ProgrammerIn-wonderland]

okay so this isn't a bug but it genuinely is supposed to be like this. You're supposed to pass in a function

puter.apps.getDeveloperProfile((res)=>{
    console.log(res)
})

and then it works

[ProgrammerIn-wonderland]

but I disagree with that so I just added support for both