Skip to content

Commit 4aeb256

Browse files
committed
Removing changes made to LCD Brightness slider as that will be refactored and handled in WAS Backend
1 parent 55424ed commit 4aeb256

File tree

2 files changed

+9
-16
lines changed

2 files changed

+9
-16
lines changed

misc/helperfunctions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export async function handleSubmit(
116116
mqtt_tls:
117117
generalSettingsForm.command_endpoint == 'MQTT' ? !!generalSettingsForm.mqtt_tls : undefined,
118118
speaker_volume: parseIntOrUndef(generalSettingsForm.speaker_volume),
119-
lcd_brightness: (parseIntOrUndef(generalSettingsForm.lcd_brightness) ?? 0) * 10,
119+
lcd_brightness: parseIntOrUndef(generalSettingsForm.lcd_brightness),
120120
display_timeout: parseIntOrUndef(generalSettingsForm.display_timeout),
121121
wake_confirmation: !!generalSettingsForm.wake_confirmation,
122122
timezone: tzDictionary[generalSettingsForm.timezone],

pagecomponents/GeneralSettingsSection.tsx

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -99,22 +99,22 @@ export default function GeneralSettingsSection({
9999
const handleLcdBrightnessInputChange = (event: React.ChangeEvent<HTMLInputElement>) => {
100100
setFieldStateHelper(
101101
'lcd_brightness',
102-
event.target.value === '' ? undefined : Number(event.target.value) * 10
102+
event.target.value === '' ? undefined : Number(event.target.value)
103103
);
104104
setChangesMade(true);
105105
};
106106

107107
const handleLcdBrightnessSliderChange = (event: Event, newValue: number | number[]) => {
108-
setFieldStateHelper('lcd_brightness', (newValue as number) * 10);
108+
setFieldStateHelper('lcd_brightness', newValue as number);
109109
setChangesMade(true);
110110
};
111111

112112
const handleLcdBrightnessBlur = () => {
113113
const lcdBrightnessValue = fieldState.lcd_brightness;
114114
if (lcdBrightnessValue && lcdBrightnessValue < 0) {
115115
setFieldStateHelper('lcd_brightness', 0);
116-
} else if (lcdBrightnessValue && lcdBrightnessValue > 1000) {
117-
setFieldStateHelper('lcd_brightness', 1000);
116+
} else if (lcdBrightnessValue && lcdBrightnessValue > 1023) {
117+
setFieldStateHelper('lcd_brightness', 1023);
118118
} else if (!lcdBrightnessValue) {
119119
setFieldStateHelper(
120120
'lcd_brightness',
@@ -124,10 +124,6 @@ export default function GeneralSettingsSection({
124124
setChangesMade(true);
125125
};
126126

127-
const brightnessValueFormat = (value: number) => {
128-
return `${value}%`;
129-
};
130-
131127
// Handlers for Display Timeout Slider and Input
132128
const handleDisplayTimeoutInputChange = (event: React.ChangeEvent<HTMLInputElement>) => {
133129
setFieldStateHelper(
@@ -409,32 +405,29 @@ export default function GeneralSettingsSection({
409405
<Brightness4Icon />
410406
<Slider
411407
name="lcd_brightness"
412-
value={(fieldState.lcd_brightness ?? 0) / 10}
408+
value={fieldState.lcd_brightness}
413409
onChange={handleLcdBrightnessSliderChange}
414410
min={0}
415-
max={100}
411+
max={1023}
416412
size="small"
417413
step={10}
418-
getAriaValueText={brightnessValueFormat}
419-
valueLabelFormat={brightnessValueFormat}
420414
valueLabelDisplay="auto"
421415
/>
422416
<Brightness5Icon />
423417
<Input
424-
value={(fieldState.lcd_brightness ?? 0) / 10}
418+
value={fieldState.lcd_brightness}
425419
size="small"
426420
onChange={handleLcdBrightnessInputChange}
427421
onBlur={handleLcdBrightnessBlur}
428422
inputProps={{
429423
step: 1,
430424
min: 0,
431-
max: 100,
425+
max: 1023,
432426
type: 'number',
433427
'aria-labelledby': 'input-slider',
434428
}}
435429
sx={{ width: 55 }}
436430
/>
437-
%
438431
</Stack>
439432
<InputLabel>Display Timeout</InputLabel>
440433
<Stack spacing={2} direction="row" sx={{ mb: 1 }} alignItems="center">

0 commit comments

Comments
 (0)