Skip to content

Commit d75a710

Browse files
authored
[REF/#737] Improve padding value application (#742)
1 parent 390ce5c commit d75a710

File tree

11 files changed

+27
-13
lines changed

11 files changed

+27
-13
lines changed

core/common/src/main/java/com/hilingual/core/common/extension/ModfierExt.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ import androidx.compose.foundation.layout.WindowInsets
2424
import androidx.compose.foundation.layout.asPaddingValues
2525
import androidx.compose.foundation.layout.consumeWindowInsets
2626
import androidx.compose.foundation.layout.imePadding
27+
import androidx.compose.foundation.layout.navigationBarsPadding
28+
import androidx.compose.foundation.layout.padding
2729
import androidx.compose.foundation.layout.statusBars
2830
import androidx.compose.runtime.Composable
2931
import androidx.compose.runtime.LaunchedEffect
@@ -136,3 +138,8 @@ fun Modifier.statusBarColor(backgroundColor: Color): Modifier = composed {
136138
)
137139
}
138140
}
141+
142+
fun Modifier.subScreenPadding(paddingValues: PaddingValues) =
143+
this
144+
.padding(top = paddingValues.calculateTopPadding())
145+
.navigationBarsPadding()

presentation/diaryfeedback/src/main/java/com/hilingual/presentation/diaryfeedback/DiaryFeedbackScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ import com.hilingual.core.common.constant.UrlConstant
5252
import com.hilingual.core.common.extension.collectSideEffect
5353
import com.hilingual.core.common.extension.launchCustomTabs
5454
import com.hilingual.core.common.extension.statusBarColor
55+
import com.hilingual.core.common.extension.subScreenPadding
5556
import com.hilingual.core.common.model.HilingualMessage
5657
import com.hilingual.core.common.provider.LocalTracker
5758
import com.hilingual.core.common.trigger.LocalDialogTrigger
@@ -265,7 +266,7 @@ private fun DiaryFeedbackScreen(
265266
.fillMaxSize()
266267
.statusBarColor(HilingualTheme.colors.white)
267268
.background(HilingualTheme.colors.white)
268-
.padding(paddingValues),
269+
.subScreenPadding(paddingValues),
269270
) {
270271
BackAndMoreTopAppBar(
271272
title = "일기장",

presentation/diarywrite/src/main/java/com/hilingual/presentation/diarywrite/DiaryWriteScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ import com.hilingual.core.common.extension.advancedImePadding
6767
import com.hilingual.core.common.extension.collectSideEffect
6868
import com.hilingual.core.common.extension.noRippleClickable
6969
import com.hilingual.core.common.extension.statusBarColor
70+
import com.hilingual.core.common.extension.subScreenPadding
7071
import com.hilingual.core.common.model.HilingualMessage
7172
import com.hilingual.core.common.provider.LocalTracker
7273
import com.hilingual.core.common.trigger.LocalDialogTrigger
@@ -362,7 +363,7 @@ private fun DiaryWriteScreen(
362363
.statusBarColor(white)
363364
.background(HilingualTheme.colors.white)
364365
.fillMaxSize()
365-
.padding(paddingValues)
366+
.subScreenPadding(paddingValues)
366367
.addFocusCleaner(focusManager),
367368
) {
368369
BackTopAppBar(

presentation/feed/src/main/java/com/hilingual/presentation/feed/search/FeedSearchScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import androidx.compose.ui.tooling.preview.Preview
3434
import androidx.compose.ui.unit.dp
3535
import androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel
3636
import androidx.lifecycle.compose.collectAsStateWithLifecycle
37+
import com.hilingual.core.common.extension.subScreenPadding
3738
import com.hilingual.core.common.util.UiState
3839
import com.hilingual.core.designsystem.component.indicator.HilingualLoadingIndicator
3940
import com.hilingual.core.designsystem.theme.HilingualTheme
@@ -89,7 +90,7 @@ private fun FeedSearchScreen(
8990
modifier = Modifier
9091
.background(HilingualTheme.colors.white)
9192
.fillMaxSize()
92-
.padding(paddingValues),
93+
.subScreenPadding(paddingValues),
9394
) {
9495
FeedSearchHeader(
9596
searchWord = { searchWord },

presentation/feeddiary/src/main/java/com/hilingual/presentation/feeddiary/FeedDiaryScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import com.hilingual.core.common.analytics.TriggerType
4747
import com.hilingual.core.common.constant.UrlConstant
4848
import com.hilingual.core.common.extension.collectSideEffect
4949
import com.hilingual.core.common.extension.launchCustomTabs
50+
import com.hilingual.core.common.extension.subScreenPadding
5051
import com.hilingual.core.common.model.HilingualMessage
5152
import com.hilingual.core.common.provider.LocalTracker
5253
import com.hilingual.core.common.trigger.LocalDialogTrigger
@@ -212,7 +213,7 @@ private fun FeedDiaryScreen(
212213
modifier = Modifier
213214
.fillMaxSize()
214215
.background(HilingualTheme.colors.white)
215-
.padding(paddingValues),
216+
.subScreenPadding(paddingValues),
216217
) {
217218
BackAndMoreTopAppBar(
218219
onBackClicked = onBackClick,

presentation/feedprofile/src/main/java/com/hilingual/presentation/feedprofile/FeedProfileScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ import com.hilingual.core.common.analytics.TriggerType
5353
import com.hilingual.core.common.constant.UrlConstant
5454
import com.hilingual.core.common.extension.collectSideEffect
5555
import com.hilingual.core.common.extension.launchCustomTabs
56+
import com.hilingual.core.common.extension.subScreenPadding
5657
import com.hilingual.core.common.model.HilingualMessage
5758
import com.hilingual.core.common.provider.LocalTracker
5859
import com.hilingual.core.common.trigger.LocalDialogTrigger
@@ -222,7 +223,7 @@ private fun FeedProfileScreen(
222223
Column(
223224
modifier = Modifier
224225
.fillMaxSize()
225-
.padding(paddingValues),
226+
.subScreenPadding(paddingValues),
226227
) {
227228
FeedProfileTopBar(
228229
isMine = profile.isMine,

presentation/feedprofile/src/main/java/com/hilingual/presentation/feedprofile/follow/FollowListScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import androidx.compose.foundation.background
1919
import androidx.compose.foundation.layout.Column
2020
import androidx.compose.foundation.layout.PaddingValues
2121
import androidx.compose.foundation.layout.fillMaxSize
22-
import androidx.compose.foundation.layout.padding
2322
import androidx.compose.foundation.lazy.LazyListState
2423
import androidx.compose.foundation.lazy.rememberLazyListState
2524
import androidx.compose.foundation.pager.HorizontalPager
@@ -35,6 +34,7 @@ import androidx.compose.ui.unit.dp
3534
import androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel
3635
import androidx.lifecycle.compose.collectAsStateWithLifecycle
3736
import com.hilingual.core.common.extension.collectSideEffect
37+
import com.hilingual.core.common.extension.subScreenPadding
3838
import com.hilingual.core.common.trigger.LocalDialogTrigger
3939
import com.hilingual.core.common.util.UiState
4040
import com.hilingual.core.designsystem.component.indicator.HilingualLoadingIndicator
@@ -110,7 +110,7 @@ private fun FollowListScreen(
110110
modifier = modifier
111111
.fillMaxSize()
112112
.background(HilingualTheme.colors.white)
113-
.padding(paddingValues),
113+
.subScreenPadding(paddingValues),
114114
) {
115115
BackTopAppBar(
116116
title = "팔로우",

presentation/mypage/src/main/java/com/hilingual/presentation/mypage/blockeduser/BlockedUserScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ import androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel
4545
import androidx.lifecycle.compose.collectAsStateWithLifecycle
4646
import com.hilingual.core.common.extension.collectSideEffect
4747
import com.hilingual.core.common.extension.statusBarColor
48+
import com.hilingual.core.common.extension.subScreenPadding
4849
import com.hilingual.core.common.trigger.LocalDialogTrigger
4950
import com.hilingual.core.common.util.UiState
5051
import com.hilingual.core.designsystem.R
@@ -103,7 +104,7 @@ private fun BlockedUserScreen(
103104
.fillMaxSize()
104105
.statusBarColor(HilingualTheme.colors.white)
105106
.background(HilingualTheme.colors.white)
106-
.padding(paddingValues),
107+
.subScreenPadding(paddingValues),
107108
) {
108109
BackTopAppBar(
109110
title = "차단한 유저",

presentation/mypage/src/main/java/com/hilingual/presentation/mypage/licenses/OssLicensesScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ import androidx.compose.foundation.background
1919
import androidx.compose.foundation.layout.Column
2020
import androidx.compose.foundation.layout.PaddingValues
2121
import androidx.compose.foundation.layout.fillMaxSize
22-
import androidx.compose.foundation.layout.padding
2322
import androidx.compose.runtime.Composable
2423
import androidx.compose.runtime.getValue
2524
import androidx.compose.ui.Modifier
25+
import com.hilingual.core.common.extension.subScreenPadding
2626
import com.hilingual.core.designsystem.theme.HilingualTheme
2727
import com.hilingual.core.ui.component.topappbar.BackTopAppBar
2828
import com.mikepenz.aboutlibraries.ui.compose.android.produceLibraries
@@ -39,7 +39,7 @@ fun OssLicensesScreen(
3939
modifier = Modifier
4040
.fillMaxSize()
4141
.background(HilingualTheme.colors.white)
42-
.padding(paddingValues),
42+
.subScreenPadding(paddingValues),
4343
) {
4444
BackTopAppBar(
4545
title = "오픈소스 라이선스",

presentation/mypage/src/main/java/com/hilingual/presentation/mypage/profileedit/ProfileEditScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ import androidx.lifecycle.compose.collectAsStateWithLifecycle
4343
import com.hilingual.core.common.extension.collectSideEffect
4444
import com.hilingual.core.common.extension.noRippleClickable
4545
import com.hilingual.core.common.extension.statusBarColor
46+
import com.hilingual.core.common.extension.subScreenPadding
4647
import com.hilingual.core.common.model.HilingualMessage
4748
import com.hilingual.core.common.provider.LocalAppRestarter
4849
import com.hilingual.core.common.trigger.LocalDialogTrigger
@@ -117,7 +118,7 @@ private fun ProfileEditScreen(
117118
.fillMaxSize()
118119
.statusBarColor(HilingualTheme.colors.white)
119120
.background(HilingualTheme.colors.white)
120-
.padding(paddingValues),
121+
.subScreenPadding(paddingValues),
121122
horizontalAlignment = Alignment.CenterHorizontally,
122123
) {
123124
TitleCenterAlignedTopAppBar(

0 commit comments

Comments
 (0)