Fix order update request not using event ID in update (#473)

Author: daveearley

backend/app/Http/Actions/Orders/EditOrderAction.php

@@ -24,8 +24,9 @@ public function __invoke(EditOrderRequest $request, int $eventId, int $orderId):
 
         $order = $this->handler->handle(new EditOrderDTO(
             id: $orderId,
-            first_name: $request->validated('first_name'),
-            last_name: $request->validated('last_name'),
+            eventId: $eventId,
+            firstName: $request->validated('first_name'),
+            lastName: $request->validated('last_name'),
             email: $request->validated('email'),
             notes: $request->validated('notes'),
         ));

backend/app/Services/Application/Handlers/Order/DTO/EditOrderDTO.php

@@ -7,10 +7,11 @@
 class EditOrderDTO extends BaseDTO
 {
     public function __construct(
-        public int $id,
-        public string $first_name,
-        public string $last_name,
-        public string $email,
+        public int     $id,
+        public int     $eventId,
+        public string  $firstName,
+        public string  $lastName,
+        public string  $email,
         public ?string $notes,
     )
     {

backend/app/Services/Application/Handlers/Order/EditOrderHandler.php

@@ -28,8 +28,9 @@ public function handle(EditOrderDTO $dto): OrderDomainObject
 
         return $this->editOrderService->editOrder(
             id: $dto->id,
-            first_name: $dto->first_name,
-            last_name: $dto->last_name,
+            eventId: $dto->eventId,
+            firstName: $dto->firstName,
+            lastName: $dto->lastName,
             email: $dto->email,
             notes: $dto->notes
         );

backend/app/Services/Domain/Order/EditOrderService.php

@@ -25,22 +25,24 @@ public function __construct(
      */
     public function editOrder(
         int     $id,
-        ?string $first_name,
-        ?string $last_name,
+        int     $eventId,
+        ?string $firstName,
+        ?string $lastName,
         ?string $email,
         ?string $notes
     ): OrderDomainObject
     {
-        return $this->databaseManager->transaction(function () use ($id, $first_name, $last_name, $email, $notes) {
+        return $this->databaseManager->transaction(function () use ($id, $firstName, $lastName, $email, $notes, $eventId) {
             $this->orderRepository->updateWhere(
                 attributes: array_filter([
-                    'first_name' => $first_name,
-                    'last_name' => $last_name,
+                    'first_name' => $firstName,
+                    'last_name' => $lastName,
                     'email' => $email,
                     'notes' => $notes,
                 ]),
                 where: [
-                    'id' => $id
+                    'id' => $id,
+                    'event_id' => $eventId,
                 ]
             );
 
@@ -51,7 +53,10 @@ public function editOrder(
                 ),
             );
 
-            return $this->orderRepository->findById($id);
+            return $this->orderRepository->findFirstWhere([
+                'id' => $id,
+                'event_id' => $eventId,
+            ]);
         });
     }
 }