Fix incorrect stripe account status (#650)

Author: daveearley

backend/app/Services/Application/Handlers/Account/Payment/Stripe/CreateStripeConnectAccountHandler.php

@@ -64,6 +64,11 @@ private function createOrGetStripeConnectAccount(CreateStripeConnectAccountDTO $
         );
 
         if ($response->isConnectSetupComplete) {
+            // If setup is complete, but this isn't reflected in the account, update it.
+            if ($account->getStripeConnectSetupComplete() === false) {
+                $this->updateAccountStripeSetupCompletionStatus($account, $stripeConnectAccount);
+            }
+
             return $response;
         }
 
@@ -155,4 +160,25 @@ private function getStripeAccountSetupUrl(Account $stripAccount, AccountDomainOb
 
         return $accountLink->url;
     }
+
+    private function updateAccountStripeSetupCompletionStatus(
+        AccountDomainObject $account,
+        Account             $stripeConnectAccount,
+    ): void
+    {
+        $this->accountRepository->updateWhere(
+            attributes: [
+                AccountDomainObjectAbstract::STRIPE_CONNECT_SETUP_COMPLETE => true,
+            ],
+            where: [
+                'id' => $account->getId(),
+            ]
+        );
+
+        $this->logger->info(sprintf(
+            'Stripe Connect account setup completed for account %s with Stripe account ID %s',
+            $account->getId(),
+            $stripeConnectAccount->id
+        ));
+    }
 }

frontend/src/components/common/StripeConnectButton/index.tsx

@@ -57,6 +57,11 @@ export const StripeConnectButton: React.FC<StripeConnectButtonProps> = ({
         if (!stripeDetails) {
             setFetchStripeDetails(true);
         } else {
+            if (stripeDetails.is_connect_setup_complete) {
+                showSuccess(t`Stripe setup is already complete.`);
+                return;
+            }
+
             if (typeof window !== 'undefined') {
                 showSuccess(t`Redirecting to Stripe...`);
                 window.location.href = String(stripeDetails.connect_url);