sys 0.12

Author: andrieshiemstra

Cargo.toml

@@ -31,7 +31,7 @@ backtrace = "0.3"
 
 #libquickjs-sys = {package="hirofa-quickjs-sys", git='https://github.com/HiRoFa/quickjs-sys'}
 #libquickjs-sys = { package = "hirofa-quickjs-sys", path = '../quickjs-sys', default-features = false }
-libquickjs-sys = { package = "hirofa-quickjs-sys", version = "0.11", default-features = false }
+libquickjs-sys = { package = "hirofa-quickjs-sys", version = "0.12", default-features = false }
 lazy_static = "1.5.0"
 log = "0.4"
 num_cpus = "1"

src/quickjs_utils/errors.rs

@@ -142,6 +142,7 @@ pub fn is_error_q(q_ctx: &QuickJsRealmAdapter, obj_ref: &QuickJsValueAdapter) ->
 /// See if a JSValueRef is an Error object
 /// # Safety
 /// When passing a context pointer please make sure the corresponding QuickJsContext is still valid
+#[allow(unused_variables)]
 pub unsafe fn is_error(context: *mut q::JSContext, obj_ref: &QuickJsValueAdapter) -> bool {
     if obj_ref.is_object() {
         #[cfg(feature = "bellard")]
@@ -151,7 +152,7 @@ pub unsafe fn is_error(context: *mut q::JSContext, obj_ref: &QuickJsValueAdapter
         }
         #[cfg(feature = "quickjs-ng")]
         {
-            q::JS_IsError(context, *obj_ref.borrow_value())
+            q::JS_IsError(*obj_ref.borrow_value())
         }
     } else {
         false

src/quickjs_utils/functions.rs

@@ -660,7 +660,7 @@ where
 
     let callback_class_id = CALLBACK_CLASS_ID.with(|rc| *rc.borrow());
 
-    let class_val: q::JSValue = q::JS_NewObjectClass(context, callback_class_id as i32);
+    let class_val: q::JSValue = q::JS_NewObjectClass(context, callback_class_id as _);
 
     let class_val_ref = QuickJsValueAdapter::new(
         context,

src/quickjs_utils/sets.rs

@@ -2,13 +2,17 @@
 //! see [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Sap) for more on Sets
 
 use crate::jsutils::JsError;
+#[cfg(feature = "bellard")]
 use crate::quickjs_utils::class_ids::JS_CLASS_SET;
 use crate::quickjs_utils::objects::construct_object;
 use crate::quickjs_utils::{functions, get_constructor, iterators, objects, primitives};
 use crate::quickjsrealmadapter::QuickJsRealmAdapter;
 use crate::quickjsvalueadapter::QuickJsValueAdapter;
 use libquickjs_sys as q;
+#[cfg(feature = "bellard")]
 use libquickjs_sys::JS_GetClassID;
+#[cfg(feature = "quickjs-ng")]
+use libquickjs_sys::JS_IsSet;
 
 /// create new instance of Set
 /// # Example
@@ -44,7 +48,11 @@ pub fn is_set_q(obj: &QuickJsValueAdapter) -> bool {
 /// # Safety
 /// please ensure the passed JSContext is still valid
 pub unsafe fn is_set(obj: &QuickJsValueAdapter) -> bool {
-    JS_GetClassID(*obj.borrow_value()) == JS_CLASS_SET
+    #[cfg(feature = "bellard")]
+    return JS_GetClassID(*obj.borrow_value()) == JS_CLASS_SET;
+
+    #[cfg(feature = "quickjs-ng")]
+    return JS_IsSet(*obj.borrow_value());
 }
 
 /// add a value to the Set

src/reflection/mod.rs

@@ -649,7 +649,7 @@ impl Proxy {
         log::trace!("reflection::Proxy::install_class_prop / 3");
 
         let class_val: q::JSValue =
-            unsafe { q::JS_NewObjectClass(q_ctx.context, static_class_id as i32) };
+            unsafe { q::JS_NewObjectClass(q_ctx.context, static_class_id as _) };
 
         log::trace!("reflection::Proxy::install_class_prop / 4");
 
@@ -834,7 +834,7 @@ pub(crate) fn new_instance3(
     let ctx = q_ctx.context;
     let class_id = PROXY_INSTANCE_CLASS_ID.with(|rc| *rc.borrow());
 
-    let class_val: q::JSValue = unsafe { q::JS_NewObjectClass(ctx, class_id as i32) };
+    let class_val: q::JSValue = unsafe { q::JS_NewObjectClass(ctx, class_id as _) };
 
     let class_name = proxy.get_class_name();