fix up test

Author: JFriel

Documentation/CodeTutorials/Packages.md

@@ -16,7 +16,7 @@
 | WeCantSpell.Hunspell | [GitHub](https://github.com/aarondandy/WeCantSpell.Hunspell/) | [GPL-2 and others](https://github.com/aarondandy/WeCantSpell.Hunspell/blob/main/license.txt) | |
 | [DockPanelSuite.ThemeVS2015](http://dockpanelsuite.com/) | [GitHub](https://github.com/dockpanelsuite/dockpanelsuite) | [MIT](https://opensource.org/licenses/MIT)  | Provides Window layout and docking for RDMP. | There are no powershell initialization files in the package which can be run by the NuGet installer.|
 | [FAM FAM FAM Icons](https://github.com/markjames/famfamfam-silk-icons) | N\A | [CC 2.5](https://creativecommons.org/licenses/by/2.5/) | Icons for user interfaces |
-| CommandLineParser | [GitHub](https://github.com/commandlineparser/commandline) | [MIT](https://opensource.org/licenses/MIT) | Allows command line arguments for main client application and CLI executables |
+| CommandLineParser | [GitHub](https://github.cosystem.m/commandlineparser/commandline) | [MIT](https://opensource.org/licenses/MIT) | Allows command line arguments for main client application and CLI executables |
 | NPOI | [GitHub](https://github.com/tonyqus/npoi) | Apache 2.0 | Enables reading/writing Microsoft Excel files |
 | ExcelNumberFormat | [GitHub](https://github.com/andersnm/ExcelNumberFormat) |[MIT](https://opensource.org/licenses/MIT)  | Handles translating number formats from Excel formats into usable values | |
 | LibArchive.Net | [GitHub](https://github.com/jas88/libarchive.net) | [BSD](https://opensource.org/license/bsd-2-clause/) | Access archive formats without the LZMA bugs of SharpCompress | |
@@ -29,7 +29,6 @@
 | YamlDotNet | [GitHub](https://github.com/aaubry/YamlDotNet)  | [MIT](https://opensource.org/licenses/MIT) |Loading configuration files|
 | SixLabors.ImageSharp | [GitHub](https://github.com/SixLabors/ImageSharp) | [Apache 2.0](https://github.com/SixLabors/ImageSharp/blob/main/LICENSE) | Platform-independent replacement for legacy Windows-only System.Drawing.Common | |
 | SixLabors.ImageSharp.Drawing | [GitHub](https://github.com/SixLabors/ImageSharp.Drawing) | [Apache 2.0](https://github.com/SixLabors/ImageSharp/blob/main/LICENSE) | Font handling for ImageSharp | |
-| System.Private.Uri | Part of .Net, referenced to override vulnerable transitive dependency | .Net SDK | |
 | [AutoComplete Console](https://www.codeproject.com/Articles/1182358/Using-Autocomplete-in-Windows-Console-Applications) by Jasper Lammers | Embedded | [CPOL](https://www.codeproject.com/info/cpol10.aspx) | Provides interactive autocomplete in console input | |
 | Spectre.Console | [GitHub](https://github.com/spectreconsole/spectre.console) | [MIT](https://opensource.org/licenses/MIT) | Allows richer command line interactions| |
 | HIC.System.Windows.Forms.DataVisualization | [GitHub](https://github.com/HicServices/winforms-datavisualization) |[MIT](https://opensource.org/licenses/MIT) | Dotnet core support for DQE charts |  |

Rdmp.Core.Tests/DataExport/DataRelease/S3BucketReleaseDestinationTests.cs

@@ -1,20 +1,24 @@
-using NUnit.Framework;
-using Minio;
-using Rdmp.Core.ReusableLibraryCode.AWS;
-using Tests.Common.Scenarios;
-using Rdmp.Core.DataFlowPipeline;
-using Rdmp.Core.ReusableLibraryCode.Progress;
-using System;
-using Rdmp.Core.Curation.Data.Pipelines;
-using Rdmp.Core.DataExport.DataRelease;
+using Minio;
+using Minio.ApiEndpoints;
+using Minio.DataModel.Args;
+using NUnit.Framework;
+using Rdmp.Core.CommandExecution;
 using Rdmp.Core.CommandLine.Options;
 using Rdmp.Core.CommandLine.Runners;
-using Rdmp.Core.CommandExecution;
+using Rdmp.Core.Curation.Data.DataLoad;
+using Rdmp.Core.Curation.Data.Pipelines;
+using Rdmp.Core.DataExport.DataRelease;
+using Rdmp.Core.DataFlowPipeline;
+using Rdmp.Core.ReusableLibraryCode.AWS;
 using Rdmp.Core.ReusableLibraryCode.Checks;
-using System.Linq;
-using Minio.DataModel.Args;
+using Rdmp.Core.ReusableLibraryCode.Progress;
+using System;
 using System.Collections.Generic;
-using Rdmp.Core.Curation.Data.DataLoad;
+using System.Linq;
+using System.Reactive.Linq;
+using System.Threading;
+using System.Threading.Tasks;
+using Tests.Common.Scenarios;
 namespace Rdmp.Core.Tests.DataExport.DataRelease;
 
 public sealed class S3BucketReleaseDestinationTests : TestsRequiringAnExtractionConfiguration
@@ -63,10 +67,20 @@ private static void DeleteBucket(string name)
 
     private static List<Minio.DataModel.Item> GetObjects(string bucketName)
     {
-        throw new Exception("This needs to be fixed by minio");
-        //var loArgs = new ListObjectsArgs().WithBucket(bucketName);
-        //var x = _minioClient.ListObjectsEnumAsync(loArgs).ToListAsync<Item>();
-        //return x.IsCompleted ? x.Result : x.AsTask().Result;
+        var loArgs = new ListObjectsArgs().WithBucket(bucketName);
+        var x = _minioClient.ListObjectsEnumAsync(loArgs);
+        var results = ToListAsync(x).Result;
+        return results;
+    }
+
+    public static async Task<List<T>> ToListAsync<T>(this IAsyncEnumerable<T> items,
+        CancellationToken cancellationToken = default)
+    {
+        var results = new List<T>();
+        await foreach (var item in items.WithCancellation(cancellationToken)
+                                        .ConfigureAwait(false))
+            results.Add(item);
+        return results;
     }
 
     private static void SetArgs(IArgument[] args, Dictionary<string, object> values)