Copy existing User configuration when installing a new RDMP version (#2276)

* correct startup location

* tidy up

* codeql update

* use correct order

Author: JFriel

CHANGELOG.md

@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [9.1.2] - Unreleased
+- Automatically fetch user settings from previous versions of RDMP when installing the latest version
 - Allow new columns to be added to archive extractions
 - Simplify use of Extraction Progress
 

Rdmp.UI/TestsAndSetup/StartupUI.cs

@@ -4,13 +4,6 @@
 // RDMP is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
 // You should have received a copy of the GNU General Public License along with RDMP. If not, see <https://www.gnu.org/licenses/>.
 
-using System;
-using System.ComponentModel;
-using System.Linq;
-using System.Reflection;
-using System.Text.RegularExpressions;
-using System.Threading.Tasks;
-using System.Windows.Forms;
 using Rdmp.Core.Icons.IconProvision;
 using Rdmp.Core.ReusableLibraryCode.Checks;
 using Rdmp.Core.ReusableLibraryCode.Settings;
@@ -21,6 +14,15 @@
 using Rdmp.UI.Versioning;
 using SixLabors.ImageSharp;
 using SixLabors.ImageSharp.PixelFormats;
+using System;
+using System.ComponentModel;
+using System.IO;
+using System.IO.IsolatedStorage;
+using System.Linq;
+using System.Reflection;
+using System.Text.RegularExpressions;
+using System.Threading.Tasks;
+using System.Windows.Forms;
 using WideMessageBox = Rdmp.UI.SimpleDialogs.WideMessageBox;
 
 namespace Rdmp.UI.TestsAndSetup;
@@ -167,6 +169,7 @@ private void StartOrRestart(bool forceClearRepositorySettings)
         pbLoadProgress.Maximum = 1000;
 
         if (_startup.RepositoryLocator == null || forceClearRepositorySettings)
+        {
             try
             {
                 lblProgress.Text = "Constructing UserSettingsRepositoryFinder";
@@ -178,7 +181,13 @@ private void StartOrRestart(bool forceClearRepositorySettings)
                 lblProgress.Text = "Constructing UserSettingsRepositoryFinder Failed";
                 ragSmiley1.Fatal(ex);
             }
-
+            if (!forceClearRepositorySettings && (_startup.RepositoryLocator is null || _startup.RepositoryLocator.CatalogueRepository == null))
+            {
+                CopyExistingConfigurationToNewApplication();
+                var finder = new UserSettingsRepositoryFinder();
+                _startup.RepositoryLocator = finder;
+            }
+        }
         escapePressed = false;
         countDownToClose = 5;
         lastStatus = RDMPPlatformDatabaseStatus.Healthy;
@@ -213,6 +222,36 @@ private void StartOrRestart(bool forceClearRepositorySettings)
     private ChooseLocalFileSystemLocationUI _chooseLocalFileSystem;
     private bool _haveWarnedAboutOutOfDate;
 
+
+    private static DirectoryInfo FindLatestConfig(string isolatedStoragePath)
+    {
+        var dirs = Directory.GetDirectories(isolatedStoragePath, "AppFiles", SearchOption.AllDirectories);
+        var dir = dirs.Select(d => new DirectoryInfo(d))
+            .OrderByDescending(d => d.LastWriteTime)
+            .Where(d => d.GetFiles().Any(file => file.Name == "CatalogueConnectionString")).FirstOrDefault();
+        return dir;
+    }
+
+    private static void CopyExistingConfigurationToNewApplication()
+    {
+        var configPath = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData) + "\\IsolatedStorage";
+        var latestConfig = FindLatestConfig(configPath);
+        if (latestConfig != null)
+        {
+            var isolated = IsolatedStorageFile.GetUserStoreForApplication();
+            foreach (var file in latestConfig.GetFiles().Where(f => !isolated.FileExists(f.Name)))
+            {
+                try
+                {
+                    isolated.CopyFile(file.FullName, file.Name);
+                }
+                finally { }
+            }
+        }
+
+    }
+
+
     private void HandleDatabaseFoundOnSimpleUI(PlatformDatabaseFoundEventArgs eventArgs)
     {
         //if status got worse
@@ -275,7 +314,7 @@ private void HandleDatabaseFoundOnSimpleUI(PlatformDatabaseFoundEventArgs eventA
                 }
                 else
                 {
-                    MessageBox.Show("Patching was cancelled. Apply Patch to use the latest version of RDMP. Application will exit."); 
+                    MessageBox.Show("Patching was cancelled. Apply Patch to use the latest version of RDMP. Application will exit.");
                     Environment.Exit(0);
                 }