Skip to content

Commit 13f1d96

Browse files
committed
fixed the issue where the image output was being skipped because it contained a secret.
1 parent da17170 commit 13f1d96

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/deploy.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ jobs:
6464
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
6565
aws-region: ${{ env.AWS_REGION }}
6666

67+
- name: Login to Amazon ECR
68+
id: login-ecr
69+
uses: aws-actions/amazon-ecr-login@v1
70+
6771
- name: Download Task Definition
6872
run: |
6973
aws ecs describe-task-definition --task-definition ${{ env.ECS_TASK_DEFINITION }} --query taskDefinition > task-definition.json
@@ -74,7 +78,7 @@ jobs:
7478
with:
7579
task-definition: task-definition.json
7680
container-name: ${{ env.CONTAINER_NAME }}
77-
image: ${{ needs.build.outputs.image }}
81+
image: ${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_REPOSITORY }}:${{ github.sha }}
7882

7983
- name: Deploy Amazon ECS task definition
8084
uses: aws-actions/amazon-ecs-deploy-task-definition@v1

0 commit comments

Comments
 (0)