Merge pull request #20763 from Homebrew/dug/raise-warnings

Enable raise_on_warning in specs

Author: dduugg

Library/Homebrew/test/cache_store_spec.rb

@@ -92,7 +92,7 @@
   describe "#write_if_dirty!" do
     context "with an open database" do
       it "does not raise an error when `close` is called on the database" do
-        expect { sample_db.write_if_dirty! }.not_to raise_error(NoMethodError)
+        expect { sample_db.write_if_dirty! }.not_to raise_error
       end
     end
 
@@ -102,7 +102,7 @@
       end
 
       it "does not raise an error when `close` is called on the database" do
-        expect { sample_db.write_if_dirty! }.not_to raise_error(NoMethodError)
+        expect { sample_db.write_if_dirty! }.not_to raise_error
       end
     end
   end

Library/Homebrew/test/cask/cask_loader/from_uri_loader_spec.rb

@@ -46,11 +46,11 @@
       end.to raise_error(UnsupportedInstallationMethod)
     end
 
-    it "does not raise an error when given a file URL" do
+    it "does not raise an error when given a file URL", :needs_utils_curl do
       loader = described_class.new("file://#{TEST_FIXTURE_DIR}/cask/Casks/local-caffeine.rb")
       expect do
         loader.load(config: nil)
-      end.not_to raise_error(UnsupportedInstallationMethod)
+      end.not_to raise_error
     end
   end
 end

…ples/reinstall_pkgconf_if_needed_spec.rb …_examples/reinstall_pkgconf_if_needed.rbLibrary/Homebrew/test/cmd/shared_examples/reinstall_pkgconf_if_needed_spec.rb renamed to Library/Homebrew/test/cmd/shared_examples/reinstall_pkgconf_if_needed.rb Library/Homebrew/test/cmd/shared_examples/reinstall_pkgconf_if_needed_spec.rb renamed to Library/Homebrew/test/cmd/shared_examples/reinstall_pkgconf_if_needed.rb

@@ -4,7 +4,7 @@
 require "formula_versions"
 require "yaml"
 require "cmd/shared_examples/args_parse"
-require "cmd/shared_examples/reinstall_pkgconf_if_needed_spec"
+require "cmd/shared_examples/reinstall_pkgconf_if_needed"
 
 RSpec.describe Homebrew::Cmd::UpdateReport do
   it_behaves_like "parseable arguments"

Library/Homebrew/test/cmd/update-report_spec.rb

@@ -2,7 +2,7 @@
 
 require "cmd/shared_examples/args_parse"
 require "cmd/upgrade"
-require "cmd/shared_examples/reinstall_pkgconf_if_needed_spec"
+require "cmd/shared_examples/reinstall_pkgconf_if_needed"
 
 RSpec.describe Homebrew::Cmd::UpgradeCmd do
   include FileUtils

Library/Homebrew/test/cmd/upgrade_spec.rb

@@ -603,10 +603,10 @@ def formula_json_contents(extra_items = {})
         end.to raise_error(UnsupportedInstallationMethod)
       end
 
-      it "does not raise an error when given a file URL" do
+      it "does not raise an error when given a file URL", :needs_utils_curl do
         expect do
           described_class.factory("file://#{TEST_FIXTURE_DIR}/testball.rb")
-        end.not_to raise_error(UnsupportedInstallationMethod)
+        end.not_to raise_error
       end
     end
 

Library/Homebrew/test/formulary_spec.rb

@@ -5,6 +5,7 @@
 
 RSpec.describe GitHubRunnerMatrix, :no_api do
   before do
+    allow(ENV).to receive(:fetch).and_call_original
     allow(ENV).to receive(:fetch).with("HOMEBREW_LINUX_RUNNER").and_return("ubuntu-latest")
     allow(ENV).to receive(:fetch).with("HOMEBREW_MACOS_LONG_TIMEOUT", "false").and_return("false")
     allow(ENV).to receive(:fetch).with("HOMEBREW_MACOS_BUILD_ON_GITHUB_RUNNER", "false").and_return("false")

Library/Homebrew/test/github_runner_matrix_spec.rb

@@ -111,7 +111,7 @@ def initialize(*, **)
       mktmpdir do |path|
         FileUtils.touch path/"foo"
         sandbox.allow_write_path(path)
-        expect { sandbox.run "chmod", "ug-w", path/"foo" }.not_to raise_error(ErrorDuringExecution)
+        expect { sandbox.run "chmod", "ug-w", path/"foo" }.not_to raise_error
       end
     end
   end
@@ -125,7 +125,7 @@ def initialize(*, **)
       mktmpdir do |path|
         FileUtils.touch path/"foo"
         sandbox.allow_write_path(path)
-        expect { sandbox.run "chmod", "4000", path/"foo" }.not_to raise_error(ErrorDuringExecution)
+        expect { sandbox.run "chmod", "4000", path/"foo" }.not_to raise_error
       end
     end
   end

Library/Homebrew/test/sandbox_spec.rb

@@ -53,8 +53,7 @@
     it "checks the input exists" do
       expect do
         services_cli.check!("hello")
-      end.not_to raise_error(UsageError,
-                             "Invalid usage: Formula(e) missing, please provide a formula name or use `--all`.")
+      end.not_to raise_error
     end
   end
 

Library/Homebrew/test/services/cli_spec.rb

@@ -76,6 +76,7 @@
 
   config.raise_errors_for_deprecations!
   config.warnings = true
+  config.raise_on_warning = true
   config.disable_monkey_patching!
 
   config.filter_run_when_matching :focus