Skip to content

Commit 319b39c

Browse files
committed
Simplify Service attr helper methods
1 parent 726f83c commit 319b39c

File tree

1 file changed

+13
-76
lines changed

1 file changed

+13
-76
lines changed

Library/Homebrew/service.rb

Lines changed: 13 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -109,52 +109,27 @@ def run(command = nil, macos: nil, linux: nil)
109109

110110
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
111111
def working_dir(path = nil)
112-
case path
113-
when nil
114-
@working_dir
115-
when String, Pathname
116-
@working_dir = path.to_s
117-
end
112+
path ? @working_dir = path.to_s : @working_dir
118113
end
119114

120115
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
121116
def root_dir(path = nil)
122-
case path
123-
when nil
124-
@root_dir
125-
when String, Pathname
126-
@root_dir = path.to_s
127-
end
117+
path ? @root_dir = path.to_s : @root_dir
128118
end
129119

130120
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
131121
def input_path(path = nil)
132-
case path
133-
when nil
134-
@input_path
135-
when String, Pathname
136-
@input_path = path.to_s
137-
end
122+
path ? @input_path = path.to_s : @input_path
138123
end
139124

140125
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
141126
def log_path(path = nil)
142-
case path
143-
when nil
144-
@log_path
145-
when String, Pathname
146-
@log_path = path.to_s
147-
end
127+
path ? @log_path = path.to_s : @log_path
148128
end
149129

150130
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
151131
def error_log_path(path = nil)
152-
case path
153-
when nil
154-
@error_log_path
155-
when String, Pathname
156-
@error_log_path = path.to_s
157-
end
132+
path ? @error_log_path = path.to_s : @error_log_path
158133
end
159134

160135
sig {
@@ -178,12 +153,7 @@ def keep_alive(value = nil)
178153

179154
sig { params(value: T.nilable(T::Boolean)).returns(T::Boolean) }
180155
def require_root(value = nil)
181-
case value
182-
when nil
183-
@require_root
184-
when TrueClass, FalseClass
185-
@require_root = value
186-
end
156+
value.nil? ? @require_root : @require_root = value
187157
end
188158

189159
# Returns a `Boolean` describing if a service requires root access.
@@ -194,12 +164,7 @@ def requires_root?
194164

195165
sig { params(value: T.nilable(T::Boolean)).returns(T.nilable(T::Boolean)) }
196166
def run_at_load(value = nil)
197-
case value
198-
when nil
199-
@run_at_load
200-
when TrueClass, FalseClass
201-
@run_at_load = value
202-
end
167+
value.nil? ? @run_at_load : @run_at_load = value
203168
end
204169

205170
sig {
@@ -240,22 +205,12 @@ def keep_alive?
240205

241206
sig { params(value: T.nilable(T::Boolean)).returns(T::Boolean) }
242207
def launch_only_once(value = nil)
243-
case value
244-
when nil
245-
@launch_only_once
246-
when TrueClass, FalseClass
247-
@launch_only_once = value
248-
end
208+
value.nil? ? @launch_only_once : @launch_only_once = value
249209
end
250210

251211
sig { params(value: T.nilable(Integer)).returns(T.nilable(Integer)) }
252212
def restart_delay(value = nil)
253-
case value
254-
when nil
255-
@restart_delay
256-
when Integer
257-
@restart_delay = value
258-
end
213+
restart_delay ? @restart_delay = value : @restart_delay
259214
end
260215

261216
sig { params(value: T.nilable(Symbol)).returns(T.nilable(Symbol)) }
@@ -286,22 +241,12 @@ def run_type(value = nil)
286241

287242
sig { params(value: T.nilable(Integer)).returns(T.nilable(Integer)) }
288243
def interval(value = nil)
289-
case value
290-
when nil
291-
@interval
292-
when Integer
293-
@interval = value
294-
end
244+
value ? @interval = value : @interval
295245
end
296246

297247
sig { params(value: T.nilable(String)).returns(T::Hash[Symbol, T.any(Integer, String)]) }
298248
def cron(value = nil)
299-
case value
300-
when nil
301-
@cron
302-
when String
303-
@cron = parse_cron(value)
304-
end
249+
value ? @cron = parse_cron(value) : @cron
305250
end
306251

307252
sig { returns(T::Hash[Symbol, T.any(Integer, String)]) }
@@ -352,20 +297,12 @@ def parse_cron(cron_statement)
352297

353298
sig { params(variables: T::Hash[Symbol, String]).returns(T.nilable(T::Hash[Symbol, String])) }
354299
def environment_variables(variables = {})
355-
case variables
356-
when Hash
357-
@environment_variables = variables.transform_values(&:to_s)
358-
end
300+
@environment_variables = variables.transform_values(&:to_s)
359301
end
360302

361303
sig { params(value: T.nilable(T::Boolean)).returns(T::Boolean) }
362304
def macos_legacy_timers(value = nil)
363-
case value
364-
when nil
365-
@macos_legacy_timers
366-
when TrueClass, FalseClass
367-
@macos_legacy_timers = value
368-
end
305+
value ? @macos_legacy_timers = value : @macos_legacy_timers
369306
end
370307

371308
delegate [:bin, :etc, :libexec, :opt_bin, :opt_libexec, :opt_pkgshare, :opt_prefix, :opt_sbin, :var] => :@formula

0 commit comments

Comments
 (0)