Skip to content

Commit 38415d8

Browse files
authored
Merge pull request #20413 from Homebrew/cask-audit-signing-skiplist
cask/audit: add skiplist for signing audit
2 parents 97c0bc7 + c83f77b commit 38415d8

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

Library/Homebrew/cask/audit.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,8 @@ def audit_signing
502502

503503
odebug "Auditing signing"
504504

505+
is_in_skiplist = cask.tap&.audit_exception(:signing_audit_skiplist, cask.token)
506+
505507
extract_artifacts do |artifacts, tmpdir|
506508
is_container = artifacts.any? { |a| a.is_a?(Artifact::App) || a.is_a?(Artifact::Pkg) }
507509

@@ -531,6 +533,7 @@ def audit_signing
531533

532534
next false if result.success?
533535
next true if cask.deprecated? && cask.deprecation_reason == :unsigned
536+
next true if is_in_skiplist
534537

535538
add_error <<~EOS, location: url.location
536539
Signature verification failed:
@@ -543,6 +546,9 @@ def audit_signing
543546
end
544547

545548
return if any_signing_failure
549+
550+
add_error "Cask is in the signing audit skiplist, but does not need to be skipped!" if is_in_skiplist
551+
546552
return unless cask.deprecated?
547553
return if cask.deprecation_reason != :unsigned
548554

0 commit comments

Comments
 (0)