Fix Sorbet runtime type errors in TestBot

Fix two runtime type errors found in CI after the initial strict typing PR:

1. `Test#test` arguments parameter: Accept `T.any(String, Pathname)` and
   convert to strings via `.map(&:to_s)` before passing to `Step.new`.
   Callers like `TestCleanup` pass `repository` (a `Pathname`) directly.

2. `BottlesFetch#fetch_bottles!` tag parameter: Accept `Utils::Bottles::Tag`
   (what `collector.tags` actually returns) instead of `Symbol`.

Author: dduugg

Library/Homebrew/test/test_bot/bottles_fetch_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require "test_bot"
+require "dev-cmd/test-bot"
+
+RSpec.describe Homebrew::TestBot::BottlesFetch do
+  describe "#fetch_bottles!" do
+    it "accepts Utils::Bottles::Tag objects from the bottle collector" do
+      # Regression test: bottle_specification.collector.tags returns Utils::Bottles::Tag objects,
+      # not Symbols. The fetch_bottles! signature must accept Tag, not Symbol.
+      fetch = described_class.new(tap: nil, git: nil, dry_run: true, fail_fast: false, verbose: false)
+      allow(fetch).to receive(:cleanup_during!)
+      tag = Utils::Bottles::Tag.new(system: :sequoia, arch: :arm64)
+
+      fetch.send(:fetch_bottles!, tag, Set["some-formula"], args: instance_double(Homebrew::Cmd::TestBotCmd::Args))
+
+      expect(fetch.steps.last).to be_passed
+      expect(fetch.steps.last.command).to include("--bottle-tag=#{tag}")
+    end
+  end
+end

Library/Homebrew/test/test_bot/test_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require "test_bot"
+
+RSpec.describe Homebrew::TestBot::Test do
+  describe "#test" do
+    it "converts Pathname arguments to strings" do
+      # Regression test: callers like TestCleanup pass Pathname objects (e.g. repository)
+      # as positional arguments. The `test` method must coerce them to String before
+      # forwarding to Step.new, which expects T::Array[String].
+      test_instance = described_class.new(dry_run: true)
+
+      step = test_instance.send(:test, "git", "-C", Pathname.new("/some/path"), "status")
+
+      expect(step.command).to eq(["git", "-C", "/some/path", "status"])
+      expect(step).to be_passed
+    end
+  end
+end

Library/Homebrew/test_bot/bottles_fetch.rb

@@ -21,7 +21,7 @@ def run!(args:)
 
       private
 
-      sig { returns(T::Hash[Symbol, T::Set[String]]) }
+      sig { returns(T::Hash[Utils::Bottles::Tag, T::Set[String]]) }
       def formulae_by_tag
         tags = Hash.new { |hash, key| hash[key] = Set.new }
 
@@ -41,7 +41,7 @@ def formulae_by_tag
         tags
       end
 
-      sig { params(tag: Symbol, formulae: T::Set[String], args: Homebrew::Cmd::TestBotCmd::Args).void }
+      sig { params(tag: Utils::Bottles::Tag, formulae: T::Set[String], args: Homebrew::Cmd::TestBotCmd::Args).void }
       def fetch_bottles!(tag, formulae, args:)
         test_header(:BottlesFetch, method: "fetch_bottles!(#{tag})")
 

Library/Homebrew/test_bot/test.rb

@@ -80,7 +80,7 @@ def info_header(text)
 
       sig {
         params(
-          arguments:        String,
+          arguments:        T.any(String, Pathname),
           named_args:       T.nilable(T.any(String, T::Array[String])),
           env:              T::Hash[String, String],
           verbose:          T::Boolean,
@@ -91,7 +91,7 @@ def info_header(text)
       def test(*arguments, named_args: nil, env: {}, verbose: @verbose, ignore_failures: false,
                report_analytics: false)
         step = Step.new(
-          arguments,
+          arguments.map(&:to_s),
           named_args:,
           env:,
           verbose:,

Library/Homebrew/test_bot/test_formulae.rb

@@ -292,7 +292,7 @@ def install_formula_from_bottle!(formula_name, testing_formulae_dependents:, dry
 
         install_args = []
         install_args += %w[--ignore-dependencies --skip-post-install] if testing_formulae_dependents
-        test "brew", "install", *install_args, bottle_filename
+        test "brew", "install", *install_args, bottle_filename.to_s
         install_step = steps.fetch(-1)
 
         if !dry_run && !testing_formulae_dependents && install_step.passed?