Skip to content

Commit 5e1fd26

Browse files
authored
Merge pull request #20383 from Homebrew/rubydoc-fixes
RubyDoc output improvements
2 parents 98384bb + 626b6ac commit 5e1fd26

28 files changed

+131
-132
lines changed

Library/Homebrew/build_options.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def head?
8585
# ### Example
8686
#
8787
# ```ruby
88-
# args << "--some-beta" if build.head?
88+
# args << "--some-feature" if build.stable?
8989
# ```
9090
def stable?
9191
!head?

Library/Homebrew/cask/dsl.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -561,8 +561,8 @@ def livecheckable?
561561

562562
# Excludes the cask from autobump list.
563563
#
564-
# TODO: limit this method to the official taps only (f.e. raise
565-
# an error if `!tap.official?`)
564+
# TODO: limit this method to the official taps only
565+
# (e.g. raise an error if `!tap.official?`)
566566
#
567567
# @api public
568568
sig { params(because: T.any(String, Symbol)).void }

Library/Homebrew/cask/url.rb

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,32 +42,24 @@ class DSL
4242
extend Forwardable
4343
def_delegators :uri, :path, :scheme, :to_s
4444

45+
# Creates a `url` stanza.
46+
#
47+
# @api public
4548
sig {
4649
params(
4750
uri: T.any(URI::Generic, String),
48-
# @api public
4951
verified: T.nilable(String),
50-
# @api public
5152
using: T.any(T::Class[AbstractDownloadStrategy], Symbol, NilClass),
52-
# @api public
5353
tag: T.nilable(String),
54-
# @api public
5554
branch: T.nilable(String),
56-
# @api public
5755
revisions: T.nilable(T::Hash[T.any(Symbol, String), String]),
58-
# @api public
5956
revision: T.nilable(String),
60-
# @api public
6157
trust_cert: T.nilable(T::Boolean),
62-
# @api public
6358
cookies: T.nilable(T::Hash[String, String]),
6459
referer: T.nilable(T.any(URI::Generic, String)),
65-
# @api public
6660
header: T.nilable(T.any(String, T::Array[String])),
6761
user_agent: T.nilable(T.any(Symbol, String)),
68-
# @api public
6962
data: T.nilable(T::Hash[String, String]),
70-
# @api public
7163
only_path: T.nilable(String),
7264
).void
7365
}

Library/Homebrew/dev-cmd/contributions.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@ def run
6868
users = args.user.presence || GitHub.members_by_team("Homebrew", "maintainers").keys
6969
users.each do |username|
7070
# TODO: Using the GitHub username to scan the `git log` undercounts some
71-
# contributions as people might not always have configured their Git
72-
# committer details to match the ones on GitHub.
71+
# contributions as people might not always have configured their Git
72+
# committer details to match the ones on GitHub.
7373
# TODO: Switch to using the GitHub APIs instead of `git log` if
74-
# they ever support trailers.
74+
# they ever support trailers.
7575
results[username] = scan_repositories(repos, username, from:)
7676
grand_totals[username] = total(results[username])
7777

Library/Homebrew/download_strategy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ def curl(*args, print_stdout: true, **options)
663663
end
664664
end
665665

666-
# Strategy for downloading a file using homebrew's curl.
666+
# Strategy for downloading a file using Homebrew's `curl`.
667667
#
668668
# @api public
669669
class HomebrewCurlDownloadStrategy < CurlDownloadStrategy

Library/Homebrew/extend/kernel.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
# Contains shorthand Homebrew utility methods like `ohai`, `opoo`, `odisabled`.
55
# TODO: move these out of `Kernel` into `Homebrew::GlobalMethods` and add
6-
# necessary Sorbet and global Kernel inclusions.
6+
# necessary Sorbet and global Kernel inclusions.
77

88
module Kernel
99
sig { params(env: T.nilable(String)).returns(T::Boolean) }

0 commit comments

Comments
 (0)