Skip to content

Commit 6c18f5c

Browse files
committed
Simplify Service attr helper methods
1 parent 726f83c commit 6c18f5c

File tree

1 file changed

+33
-48
lines changed

1 file changed

+33
-48
lines changed

Library/Homebrew/service.rb

Lines changed: 33 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -109,51 +109,46 @@ def run(command = nil, macos: nil, linux: nil)
109109

110110
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
111111
def working_dir(path = nil)
112-
case path
113-
when nil
114-
@working_dir
115-
when String, Pathname
112+
if path
116113
@working_dir = path.to_s
114+
else
115+
@working_dir
117116
end
118117
end
119118

120119
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
121120
def root_dir(path = nil)
122-
case path
123-
when nil
124-
@root_dir
125-
when String, Pathname
121+
if path
126122
@root_dir = path.to_s
123+
else
124+
@root_dir
127125
end
128126
end
129127

130128
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
131129
def input_path(path = nil)
132-
case path
133-
when nil
134-
@input_path
135-
when String, Pathname
130+
if path
136131
@input_path = path.to_s
132+
else
133+
@input_path
137134
end
138135
end
139136

140137
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
141138
def log_path(path = nil)
142-
case path
143-
when nil
144-
@log_path
145-
when String, Pathname
139+
if path
146140
@log_path = path.to_s
141+
else
142+
@log_path
147143
end
148144
end
149145

150146
sig { params(path: T.nilable(T.any(String, Pathname))).returns(T.nilable(String)) }
151147
def error_log_path(path = nil)
152-
case path
153-
when nil
154-
@error_log_path
155-
when String, Pathname
148+
if path
156149
@error_log_path = path.to_s
150+
else
151+
@error_log_path
157152
end
158153
end
159154

@@ -178,10 +173,9 @@ def keep_alive(value = nil)
178173

179174
sig { params(value: T.nilable(T::Boolean)).returns(T::Boolean) }
180175
def require_root(value = nil)
181-
case value
182-
when nil
176+
if value.nil?
183177
@require_root
184-
when TrueClass, FalseClass
178+
else
185179
@require_root = value
186180
end
187181
end
@@ -194,10 +188,9 @@ def requires_root?
194188

195189
sig { params(value: T.nilable(T::Boolean)).returns(T.nilable(T::Boolean)) }
196190
def run_at_load(value = nil)
197-
case value
198-
when nil
191+
if value.nil?
199192
@run_at_load
200-
when TrueClass, FalseClass
193+
else
201194
@run_at_load = value
202195
end
203196
end
@@ -240,21 +233,19 @@ def keep_alive?
240233

241234
sig { params(value: T.nilable(T::Boolean)).returns(T::Boolean) }
242235
def launch_only_once(value = nil)
243-
case value
244-
when nil
236+
if value.nil?
245237
@launch_only_once
246-
when TrueClass, FalseClass
238+
else
247239
@launch_only_once = value
248240
end
249241
end
250242

251243
sig { params(value: T.nilable(Integer)).returns(T.nilable(Integer)) }
252244
def restart_delay(value = nil)
253-
case value
254-
when nil
255-
@restart_delay
256-
when Integer
245+
if restart_delay
257246
@restart_delay = value
247+
else
248+
@restart_delay
258249
end
259250
end
260251

@@ -286,21 +277,19 @@ def run_type(value = nil)
286277

287278
sig { params(value: T.nilable(Integer)).returns(T.nilable(Integer)) }
288279
def interval(value = nil)
289-
case value
290-
when nil
291-
@interval
292-
when Integer
280+
if value
293281
@interval = value
282+
else
283+
@interval
294284
end
295285
end
296286

297287
sig { params(value: T.nilable(String)).returns(T::Hash[Symbol, T.any(Integer, String)]) }
298288
def cron(value = nil)
299-
case value
300-
when nil
301-
@cron
302-
when String
289+
if value
303290
@cron = parse_cron(value)
291+
else
292+
@cron
304293
end
305294
end
306295

@@ -352,18 +341,14 @@ def parse_cron(cron_statement)
352341

353342
sig { params(variables: T::Hash[Symbol, String]).returns(T.nilable(T::Hash[Symbol, String])) }
354343
def environment_variables(variables = {})
355-
case variables
356-
when Hash
357-
@environment_variables = variables.transform_values(&:to_s)
358-
end
344+
@environment_variables = variables.transform_values(&:to_s)
359345
end
360346

361347
sig { params(value: T.nilable(T::Boolean)).returns(T::Boolean) }
362348
def macos_legacy_timers(value = nil)
363-
case value
364-
when nil
349+
if value.nil?
365350
@macos_legacy_timers
366-
when TrueClass, FalseClass
351+
else
367352
@macos_legacy_timers = value
368353
end
369354
end

0 commit comments

Comments
 (0)