download_queue: fix bottle manifest handling.

These should be ignored upon failures.

Author: MikeMcQuaid

Library/Homebrew/download_queue.rb

@@ -38,6 +38,8 @@ def fetch
         rescue ChecksumMismatchError => e
           opoo "#{downloadable.download_type} reports different checksum: #{e.expected}"
           Homebrew.failed = true if downloadable.is_a?(Resource::Patch)
+        rescue => e
+          raise e unless bottle_manifest_error?(downloadable, e)
         end
       else
         spinner = Spinner.new
@@ -68,6 +70,9 @@ def fetch
               raise future.state.to_s
             end
 
+            exception = future.reason if future.rejected?
+            next 1 if bottle_manifest_error?(downloadable, exception)
+
             message = "#{downloadable.download_type} #{downloadable.name}"
             if tty
               stdout_print_and_flush "#{status} #{message}#{"\n" unless last}"
@@ -76,14 +81,13 @@ def fetch
             end
 
             if future.rejected?
-              if (e = future.reason).is_a?(ChecksumMismatchError)
-                opoo "#{downloadable.download_type} reports different checksum: #{e.expected}"
+              if exception.is_a?(ChecksumMismatchError)
+                opoo "#{downloadable.download_type} reports different checksum: #{exception.expected}"
                 Homebrew.failed = true if downloadable.is_a?(Resource::Patch)
                 next 2
               else
                 message = future.reason.to_s
-                onoe message
-                Homebrew.failed = true
+                ofail message
                 next message.count("\n")
               end
             end
@@ -165,6 +169,13 @@ def shutdown
 
     private
 
+    sig { params(downloadable: Downloadable, exception: T.nilable(Exception)).returns(T::Boolean) }
+    def bottle_manifest_error?(downloadable, exception)
+      return false if exception.nil?
+
+      downloadable.is_a?(Resource::BottleManifest) || exception.is_a?(Resource::BottleManifest::Error)
+    end
+
     sig { void }
     def cancel
       # FIXME: Implement graceful cancellation of running downloads based on