Merge pull request #20343 from Homebrew/fix_uri_parser_warning

Fix URI parser warning

Author: MikeMcQuaid

Library/Homebrew/cask/cask_loader.rb

@@ -181,7 +181,7 @@ def self.try_new(ref, warn: false)
 
         # Cache compiled regex
         @uri_regex ||= begin
-          uri_regex = ::URI::DEFAULT_PARSER.make_regexp
+          uri_regex = ::URI::RFC2396_PARSER.make_regexp
           Regexp.new("\\A#{uri_regex.source}\\Z", uri_regex.options)
         end
 

Library/Homebrew/download_strategy.rb

@@ -366,7 +366,7 @@ def resolved_url_and_basename
   def parse_basename(url, search_query: true)
     components = { path: T.let([], T::Array[String]), query: T.let([], T::Array[String]) }
 
-    if url.match?(URI::DEFAULT_PARSER.make_regexp)
+    if url.match?(URI::RFC2396_PARSER.make_regexp)
       uri = URI(url)
 
       if (uri_query = uri.query.presence)
@@ -382,7 +382,7 @@ def parse_basename(url, search_query: true)
 
       if (uri_path = uri.path.presence)
         components[:path] = uri_path.split("/").filter_map do |part|
-          URI::DEFAULT_PARSER.unescape(part).presence
+          URI::RFC2396_PARSER.unescape(part).presence
         end
       end
     else

Library/Homebrew/formulary.rb

@@ -661,7 +661,7 @@ def self.try_new(ref, from: nil, warn: false)
 
       # Cache compiled regex
       @uri_regex ||= begin
-        uri_regex = ::URI::DEFAULT_PARSER.make_regexp
+        uri_regex = ::URI::RFC2396_PARSER.make_regexp
         Regexp.new("\\A#{uri_regex.source}\\Z", uri_regex.options)
       end