Merge pull request #20026 from abitrolly/non-archive-fix

MikeMcQuaid · web-flow · commit bdbd80671a83 · 2025-05-30T16:49:09.000Z
create: fix archive check if HTML starts with spaces
diff --git a/Library/Homebrew/formula_creator.rb b/Library/Homebrew/formula_creator.rb
@@ -84,7 +84,10 @@ def write_formula!
           r.owner = self
           filepath = r.fetch
           html_doctype_prefix = "<!doctype html"
-          if File.read(filepath, html_doctype_prefix.length).downcase.start_with?(html_doctype_prefix)
+          # Number of bytes to read from file start to ensure it is not HTML.
+          # HTML may start with arbitrary number of whitespace lines.
+          bytes_to_read = 100
+          if File.read(filepath, bytes_to_read).strip.downcase.start_with?(html_doctype_prefix)
             raise "Downloaded URL is not archive"
           end
 
