ExtractPlist: refactor URL options handling

This maintains the same behavior of the logic for handling `livecheck`
block URL options but cleans it up a little. Namely:

* Use trailing `if` in `filter_map` instead of ternary with `nil`
branch.
* Use `options` instead of `cask.livecheck.options`, as these are the
same here.
* Use `select` with a `nil?` guard instead of `compact.each` and
pushing to an external variable, as this is a little tidier and uses
less memory allocation.

Author: samford

Library/Homebrew/livecheck/strategy/extract_plist.rb

@@ -107,19 +107,21 @@ def self.find_versions(cask:, url: nil, regex: nil, options: Options.new, &block
             @cask_url_kw_params ||= T.let(
               T::Utils.signature_for_method(
                 Cask::URL.instance_method(:initialize),
-              ).parameters.filter_map { |type, sym| (type == :key) ? sym : nil },
+              ).parameters.filter_map { |type, sym| sym if type == :key },
               T.nilable(T::Array[Symbol]),
             )
 
-            # Collect `livecheck` block options supported by `Cask::URL`
-            url_kwargs = {}
+            # Collect `livecheck` block URL options supported by `Cask::URL`
             unused_opts = []
-            cask.livecheck.options.url_options.compact.each_key do |option_key|
-              if @cask_url_kw_params.include?(option_key)
-                url_kwargs[option_key] = cask.livecheck.options.public_send(option_key)
-              else
-                unused_opts << option_key
+            url_kwargs = options.url_options.select do |key, value|
+              next if value.nil?
+
+              unless @cask_url_kw_params.include?(key)
+                unused_opts << key
+                next
               end
+
+              true
             end
 
             unless unused_opts.empty?
@@ -130,7 +132,7 @@ def self.find_versions(cask:, url: nil, regex: nil, options: Options.new, &block
             end
 
             # Create a copy of the cask that overrides the artifact URL with the
-            # provided URL and supported `livecheck` block options
+            # provided URL and supported `livecheck` block URL options
             cask_copy = Cask::CaskLoader.load(cask.sourcefile_path)
             cask_copy.allow_reassignment = true
             cask_copy.url(url, **url_kwargs)