Merge pull request #255935 from Homebrew/std_go_args_omit_ldflags

various: omit `ldflags` argument in `std_go_args` method

Author: BrewTestBot

Formula/b/bitrise.rb

@@ -31,7 +31,7 @@ def install
       -X github.com/bitrise-io/bitrise/version.Commit=#{tap.user}
     ]
 
-    system "go", "build", *std_go_args(ldflags: ldflags)
+    system "go", "build", *std_go_args(ldflags:)
   end
 
   test do

Formula/b/bom.rb

@@ -23,7 +23,7 @@ def install
       -X sigs.k8s.io/release-utils/version.gitVersion=v#{version}
       -X sigs.k8s.io/release-utils/version.gitTreeState=clean
     ]
-    system "go", "build", *std_go_args(ldflags: ldflags.join(" ")), "./cmd/bom"
+    system "go", "build", *std_go_args(ldflags:), "./cmd/bom"
 
     generate_completions_from_executable(bin/"bom", "completion", shells: [:bash, :zsh, :fish, :pwsh])
   end

Formula/d/dnscontrol.rb

@@ -31,7 +31,7 @@ def install
       -s -w
       -X github.com/StackExchange/dnscontrol/v4/pkg/version.version=#{version}
     ]
-    system "go", "build", *std_go_args(ldflags: ldflags)
+    system "go", "build", *std_go_args(ldflags:)
 
     generate_completions_from_executable(bin/"dnscontrol", "shell-completion", shells: [:bash, :zsh])
   end

Formula/g/gh-ost.rb

@@ -26,7 +26,7 @@ class GhOst < Formula
 
   def install
     ldflags = "-s -w -X main.AppVersion=#{version} -X main.GitCommit=#{tap.user}"
-    system "go", "build", *std_go_args(ldflags: ldflags), "./go/cmd/gh-ost"
+    system "go", "build", *std_go_args(ldflags:), "./go/cmd/gh-ost"
   end
 
   test do

Formula/g/go-librespot.rb

@@ -35,7 +35,7 @@ def install
     ]
     ldflags << "-X github.com/devgianlu/go-librespot.commit=#{Utils.git_short_head(length: 8)}" if build.head?
 
-    system "go", "build", *std_go_args(output: bin/"go-librespot", ldflags: ldflags), "./cmd/daemon"
+    system "go", "build", *std_go_args(output: bin/"go-librespot", ldflags:), "./cmd/daemon"
     (var/"log").mkpath
 
     # On macOS, create a minimal config that selects the correct backend.

Formula/g/gphotos-uploader-cli.rb

@@ -23,7 +23,7 @@ def install
       -s -w
       -X github.com/gphotosuploader/gphotos-uploader-cli/version.versionString=#{version}
     ]
-    system "go", "build", *std_go_args(ldflags: ldflags)
+    system "go", "build", *std_go_args(ldflags:)
   end
 
   test do

Formula/m/mender-artifact.rb

@@ -36,7 +36,7 @@ def install
     end
 
     ldflags = "-s -w -X github.com/mendersoftware/mender-artifact/cli.Version=#{version}"
-    system "go", "build", *std_go_args(ldflags: ldflags)
+    system "go", "build", *std_go_args(ldflags:)
 
     # mender-artifact doesn't support autocomplete generation so we have to
     # install the individual files instead of using

Formula/p/privatebin-cli.rb

@@ -18,7 +18,7 @@ class PrivatebinCli < Formula
 
   def install
     ldflags = "-s -w -X main.version=#{version} -X main.commit=#{tap.user} -X main.date=#{time.iso8601}"
-    system "go", "build", *std_go_args(ldflags: ldflags, output: bin/"privatebin"), "./cmd/privatebin"
+    system "go", "build", *std_go_args(ldflags:, output: bin/"privatebin"), "./cmd/privatebin"
   end
 
   test do

Formula/t/terraform-ls.rb

@@ -27,7 +27,7 @@ def install
       -s -w
       -X main.rawVersion=#{version}+#{tap.user}
     ]
-    system "go", "build", *std_go_args(ldflags: ldflags.join(" "))
+    system "go", "build", *std_go_args(ldflags:)
   end
 
   test do

Formula/t/tofu-ls.rb

@@ -27,7 +27,7 @@ def install
       -s -w
       -X main.rawVersion=#{version}+#{tap.user}
     ]
-    system "go", "build", *std_go_args(ldflags: ldflags.join(" "))
+    system "go", "build", *std_go_args(ldflags:)
   end
 
   test do