Merge pull request #223390 from Homebrew/jar-script-style

bfg, ditaa, picard-tools: install binary with `write_jar_script`

Author: chenrui333

Formula/b/bfg.rb

@@ -18,10 +18,7 @@ class Bfg < Formula
 
   def install
     libexec.install "bfg-#{version}.jar"
-    (bin/"bfg").write <<~SHELL
-      #!/bin/bash
-      exec "#{Formula["openjdk"].opt_bin}/java" -jar "#{libexec}/bfg-#{version}.jar" "$@"
-    SHELL
+    bin.write_jar_script libexec/"bfg-#{version}.jar", "bfg"
   end
 
   test do

Formula/d/ditaa.rb

@@ -15,10 +15,7 @@ class Ditaa < Formula
 
   def install
     libexec.install "ditaa-#{version}-standalone.jar"
-    (bin/"ditaa").write <<~BASH
-      #!/bin/bash
-      exec "#{Formula["openjdk"].opt_bin}/java" -jar "#{libexec}/ditaa-#{version}-standalone.jar" "$@"
-    BASH
+    bin.write_jar_script libexec/"ditaa-#{version}-standalone.jar", "ditaa"
   end
 
   test do

Formula/p/picard-tools.rb

@@ -18,10 +18,7 @@ class PicardTools < Formula
 
   def install
     libexec.install "picard.jar"
-    (bin/"picard").write <<~EOS
-      #!/bin/bash
-      exec "#{Formula["openjdk"].opt_bin}/java" $JAVA_OPTS -jar "#{libexec}/picard.jar" "$@"
-    EOS
+    bin.write_jar_script libexec/"picard.jar", "picard", "$JAVA_OPTS"
   end
 
   test do