Merge pull request #255897 from Homebrew/tests-nodejs-and-concurrent-downloads

workflows/tests: check nodejs label via check-labels.js

Author: cho-m

.github/workflows/scripts/check-labels.js

@@ -73,11 +73,11 @@ module.exports = async ({github, context, core}, formulae_detect, dependent_test
     const test_bot_dependents_args = ["--only-formulae-dependents", "--junit"]
 
     if (label_names.includes(`CI-test-bot-no-concurrent-downloads`)) {
-      console.log(`CI-test-bot-no-concurrent-downloads label found. Not passing --concurrent-downloads to brew test-bot.`)
+      console.log(`CI-test-bot-no-concurrent-downloads label found. Running with HOMEBREW_DOWNLOAD_CONCURRENCY=1`)
+      core.setOutput('download-concurrency', '1')
     } else {
-      console.log(`No CI-test-bot-no-concurrent-downloads label found. Passing --concurrent-downloads to brew test-bot.`)
-      test_bot_formulae_args.push('--concurrent-downloads')
-      test_bot_dependents_args.push('--concurrent-downloads')
+      console.log(`No CI-test-bot-no-concurrent-downloads label found. Running with HOMEBREW_DOWNLOAD_CONCURRENCY=auto`)
+      core.setOutput('download-concurrency', 'auto')
     }
 
     if (label_names.includes(`CI-test-bot-fail-fast${deps_suffix}`)) {
@@ -146,4 +146,6 @@ module.exports = async ({github, context, core}, formulae_detect, dependent_test
 
     core.setOutput('test-bot-formulae-args', test_bot_formulae_args.join(" "))
     core.setOutput('test-bot-dependents-args', test_bot_dependents_args.join(" "))
+
+    core.setOutput('nodejs', label_names.includes('nodejs'))
 }

.github/workflows/tests.yml

@@ -143,15 +143,12 @@ jobs:
       long-timeout: ${{ steps.check-labels.outputs.long-timeout }}
       test-bot-formulae-args: ${{ steps.check-labels.outputs.test-bot-formulae-args }}
       test-bot-dependents-args: ${{ steps.check-labels.outputs.test-bot-dependents-args }}
+      download-concurrency: ${{ steps.check-labels.outputs.download-concurrency }}
     steps:
       - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
         with:
           persist-credentials: false
 
-      - name: Check if nodejs formula
-        if: contains(github.event.pull_request.labels.*.name, 'nodejs')
-        run: exit 1
-
       - name: Check for CI labels
         id: check-labels
         uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
@@ -178,6 +175,10 @@ jobs:
               console.error(error);
             }
 
+      - name: Check if nodejs formula
+        if: fromJson(steps.check-labels.outputs.nodejs)
+        run: exit 1
+
   setup_runners:
     needs: [formulae_detect, setup_tests]
     if: >
@@ -244,6 +245,7 @@ jobs:
             --deleted-formulae="$DELETED_FORMULAE" \
             <<<"$TEST_BOT_FORMULAE_ARGS"
         env:
+          HOMEBREW_DOWNLOAD_CONCURRENCY: ${{ needs.setup_tests.outputs.download-concurrency }}
           TEST_BOT_FORMULAE_ARGS: ${{ needs.setup_tests.outputs.test-bot-formulae-args }}
           TESTING_FORMULAE: ${{ needs.formulae_detect.outputs.testing_formulae }}
           ADDED_FORMULAE: ${{ needs.formulae_detect.outputs.added_formulae }}
@@ -273,6 +275,7 @@ jobs:
       long-timeout: ${{ steps.check-labels.outputs.long-timeout }}
       test-bot-formulae-args: ${{ steps.check-labels.outputs.test-bot-formulae-args }}
       test-bot-dependents-args: ${{ steps.check-labels.outputs.test-bot-dependents-args }}
+      download-concurrency: ${{ steps.check-labels.outputs.download-concurrency }}
     steps:
       - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
         with:
@@ -376,6 +379,7 @@ jobs:
             --tested-formulae="$TESTED_FORMULAE" \
             <<<"$TEST_BOT_DEPENDENTS_ARGS"
         env:
+          HOMEBREW_DOWNLOAD_CONCURRENCY: ${{ needs.setup_dep_tests.outputs.download-concurrency }}
           TEST_BOT_DEPENDENTS_ARGS: ${{ needs.setup_dep_tests.outputs.test-bot-dependents-args }}
           TESTED_FORMULAE: ${{ needs.formulae_detect.outputs.testing_formulae }}
         working-directory: ${{ env.BOTTLES_DIR }}