Skip to content

kubetail 0.0.6 #195821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrewTestBot wants to merge 1 commit into from
Closed

kubetail 0.0.6 #195821

BrewTestBot wants to merge 1 commit into from

Conversation

@BrewTestBot
Copy link
Contributor

@BrewTestBot BrewTestBot commented Oct 28, 2024

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Oct 28, 2024
@stefanb stefanb force-pushed the bump-kubetail-0.0.6 branch from 309ef64 to 6dd822c Compare October 28, 2024 16:54
@stefanb
Copy link
Member

stefanb commented Oct 28, 2024 •
edited
Loading

Pinned to node@22 after recent

because of error:

> tsc && vite build
  
  vite v5.4.9 building for production...
  transforming...
  (node:5508) ExperimentalWarning: CommonJS module /tmp/kubetail-20241028-5380-xl8de0/kubetail-cli-v0.0.6/dashboard-ui/node_modules/.pnpm/[email protected]/node_modules/tailwindcss/lib/lib/load-config.js is loading ES Module /tmp/kubetail-20241028-5380-xl8de0/kubetail-cli-v0.0.6/dashboard-ui/tailwind.config.js using require().
  Support for loading ES Module in require() is an experimental feature and might change at any time
  (Use `node --trace-warnings ...` to show where the warning was created)
  file:///tmp/kubetail-20241028-5380-xl8de0/kubetail-cli-v0.0.6/dashboard-ui/tailwind.config.js:2
  module.exports = {
  ^
  
  ReferenceError: module is not defined
      at file:///tmp/kubetail-20241028-5380-xl8de0/kubetail-cli-v0.0.6/dashboard-ui/tailwind.config.js:2:1
      at ModuleJobSync.runSync (node:internal/modules/esm/module_job:367:35)
      at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:325:47)
      at loadESMFromCJS (node:internal/modules/cjs/loader:1396:24)
      at Module._compile (node:internal/modules/cjs/loader:1529:5)
      at Object..js (node:internal/modules/cjs/loader:1678:16)
      at Module.load (node:internal/modules/cjs/loader:[131](https://github.com/Homebrew/homebrew-core/actions/runs/11557535382/job/32167954369?pr=195821#step:4:132)5:32)
      at Function._load (node:internal/modules/cjs/loader:1125:12)
      at TracingChannel.traceSync (node:diagnostics_channel:322:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:216:24)
  
  Node.js v23.1.0
   ELIFECYCLE  Command failed with exit code 1.
  make: *** [Makefile:39: build-dashboard-ui] Error 1

chenrui333
chenrui333 reviewed Oct 28, 2024
View reviewed changes
Formula/k/kubetail.rb Outdated
Copy link
Member

@chenrui333 chenrui333 Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also log an upstream issue for this?

Copy link
Member

@stefanb stefanb Oct 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked upstream for an issue or PR, but found none.
Doesn't feel right to report an issue which isn't really an issue yet, and node 22 will be supported longer than 23:

image

Copy link
Member

@chenrui333 chenrui333 Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it would be very much a feature request tbh :)

Copy link
Member

@stefanb stefanb Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, @amorey is already fixing it in upstream

supposedly coming in 0.0.7 release

Copy link
Member

@stefanb stefanb Oct 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying 0.0.7 with the fix in

Copy link
Contributor

@amorey amorey Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up about the problem. I patched the bug and published a new version (0.0.7) which should compile with Node 23. The source of the error was a tailwind config issue which was resolved by updating the config file format from commonjs to typescript.

Copy link
Member

@chenrui333 chenrui333 Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amorey! 🍻

@amorey amorey mentioned this pull request Oct 28, 2024
Merged
@stefanb stefanb force-pushed the bump-kubetail-0.0.6 branch from 6dd822c to 0f2728c Compare October 28, 2024 21:39
amorey added a commit to kubetail-org/kubetail that referenced this pull request Oct 28, 2024
@amorey
Fixes tailwind config issue causing build failure in node23 (#139)
cfd0bb0 
Fixes
Homebrew/homebrew-core#195821 (comment)
@chenrui333
Copy link
Member

chenrui333 commented Oct 28, 2024

Looks like 0.0.7 builds well with node23, closing this. Thanks @stefanb @amorey!!

@chenrui333 chenrui333 closed this Oct 28, 2024
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Oct 28, 2024
@github-actions github-actions bot deleted the bump-kubetail-0.0.6 branch October 28, 2024 22:13
freexploit pushed a commit to freexploit/kubetail that referenced this pull request Jun 2, 2025
@amorey
Fixes tailwind config issue causing build failure in node23 (kubetail…
a77c4fa 
…-org#139)

Fixes
Homebrew/homebrew-core#195821 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanb stefanb stefanb left review comments

@chenrui333 chenrui333 chenrui333 approved these changes

+1 more reviewer

@amorey amorey amorey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue superseded PR was replaced by another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BrewTestBot @stefanb @chenrui333 @amorey