# Merged PRs
dolt

9005: go/store/nbs: Fix perf regression in taking backups.

1.50.0 introduced a perf regression which mainly effects taking backups to AWS or GCS. This is a partial fix which makes backups perform as before when they are going to a completely new destination. Incremental backups to an existing store are still slower. We continue to work on addressing the regression.
9003: Up server config default max conns from 100 to 1000
8994: Bug fix for TypeCompatibilityChecker to ignore ExtenedTypes

The following query caused a panic in Doltgres, because DoltTable was using TypeCompatibilityChecker to test if the column type change was compatible. TypeCompatibilityChecker wasn't able to handle the ExtendedType instance and panic'ed. This change makes TypeCompatibilityChecker ignore extended types, since it doesn't know enough about them to determine if a type change is compatible or not.
8993: Bump golang.org/x/net in /go/gen/proto/dolt/services/eventsapi

Bumps golang.org/x/net from 0.23.0 to 0.36.0.

Commits


updated-dependencies:

dependency-name: golang.org/x/net dependency-type: indirect ...


8992: Remove unnecessary hashicorp/go-uuid dependency

We are already using github.com/google/uuid for UUIDs. This dependency was accidentally introduced.
8990: Remove unnecessary hashicorp/go-uuid dependency

We are already using github.com/google/uuid for UUIDs. I think this dependency was accidentally introduced.

https://github.com/dolthub/dolt/blob/b7c0ddb4aac3702114c4e060651007d590a8be8c/go/go.mod#L24

https://github.com/dolthub/dolt/blob/b7c0ddb4aac3702114c4e060651007d590a8be8c/go/go.mod#L71
8988: Test for INSERT ... ON DUPLICATE UPDATE with dolt_docs table

Adds a test for the bug fix in Bug fix: Call StatementBegin for all TableEditors used in insertIter dolthub/go-mysql-server#2892
8979: Bump golang.org/x/net from 0.23.0 to 0.36.0 in /go/gen/proto/dolt/services/eventsapi

Bumps golang.org/x/net from 0.23.0 to 0.36.0.

Commits

85d1d54 go.mod: update golang.org/x dependencies
cde1dda proxy, http/httpproxy: do not mismatch IPv6 zone ids against hosts
fe7f039 publicsuffix: spruce up code gen and speed up PublicSuffix
459513d internal/http3: move more common stream processing to genericConn
aad0180 http2: fix flakiness from t.Log when GOOS=js
b73e574 http2: don't log expected errors from writing invalid trailers
5f45c77 internal/http3: make read-data tests usable for server handlers
43c2540 http2, internal/httpcommon: reject userinfo in :authority
1d78a08 http2, internal/httpcommon: factor out server header logic for h2/h3
0d7dc54 quic: add Conn.ConnectionState
Additional commits viewable in compare view




[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.23.0&new-version=0.36.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---

Dependabot commands and options


You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/dolthub/dolt/network/alerts).


8850: refactor: using clear to simplify the code

This is a new built-in function added in the go1.21 standard library, which can make the code more concise and easy to read.

go-mysql-server

2895: Bug fix: resolve column default expressions for ALTER COLUMN nodes

When building plan nodes to handle altering a column's nullability or type, without respecifying the full column definition, the built node should ensure any column default expressions are resolved.

This originally showed up as a panic in Doltgres, because Doltgres' TypeSanitzer found the UnresolvedColumnDefault instance and tried to invoke operations on it.

Note that it's not currently possible to trigger this issue with Dolt or GMS because MySQL has a more limited syntax than Postgres for altering a column without respecfiying its full column definition, and Dolt/GMS does not support that syntax currently (e.g. ALTER TABLE t ALTER COLUMN SET VISIBLE).
2892: Bug fix: Call StatementBegin for all TableEditors used in insertIter

insertIter can be given a sql.RowInserter and a sql.RowUpdater, and when the ON DUPLICATE UPDATE clause is present, it can use both to update a table. StatementBegin was only being called on the sql.RowInserter and not for the sql.RowUpdater, which caused a problem for some implementations (e.g. docsWriter) that depend on StatementBegin being called.

Test for this added to the Dolt package (Test for INSERT ... ON DUPLICATE UPDATE with dolt_docs table dolthub/dolt#8988), using the docWriter implementation where this bug was originally discovered.
2891: look through table aliases for table names when applying triggers

Table aliases on update statements break triggers, because we are unable to find any trigger matches on the alias.

The fix is to find the real table name when searching for triggers.

fixes: BUG: BEFORE UPDATE Trigger Not Working in Dolt dolthub/dolt#8926
2890: Sort tables by FK dependencies for DROP TABLES

When multiple tables are supplied to DROP TABLES, MySQL (and also Postgres) will sort the tables by foreign key dependencies, so that the tables can be dropped cleanly.

Resolves DROP TABLE should sort tables by dependencies dolthub/doltgresql#1272
2889: don't erase dual table projection

The rule eraseProjection erases the projection from select '', which causes validateSchemaSource to error.

Adding a case in validateSchemaSource resulted in dummy rows being outputted, so I think this is the best solution for now.

fixes: Can't select '' dolthub/dolt#8977
2888: Allow type conversions for foreign key checks

This PR introduces a new method for the ExtendedType interface and uses it to allow converting between compatible column types during a foreign key check.
2887: Correct JSON_LENGTH with an object parameter

When JSON_LENGTH is passed a JSON object, it should always return the number of fields in the object. However, due to a typo, it currently only returns 1 for objects. This PR corrects that behavior.
2886: reintroduce last_insert_id discrepancy

Apparently the last_insert_id in ok result, is not the same as select last_insert_id().

When there is an auto_increment column, the insert_id in the OKResult is the first value that increments the auto_increment value.

Reverts some changes from: fix insert id dolthub/go-mysql-server#2616

fixes: MySQL is not consistent regarding last_insert_id; go-mysql-server ceased to emulate this inconsistency in v0.19.0 dolthub/dolt#8914

Closed Issues

8942: Log when max_connections is reached
7428: Feature request for supporting health and readiness checks in Dolt DB
5997: Pro-active dolt gc warning
5785: dolt table import -u inserts and updates duplicate keys instead of failing. Unclear what the desired behavior is.
5535: dolt pull from DoltHub does not complete (gets stuck) in hours when a clone takes minutes
5371: dolt clone loads all dolt databases in working directory into memory
8926: BUG: BEFORE UPDATE Trigger Not Working in Dolt
3629: dolt cli commands take a long time for large databases
2322: dolt persisted globals --global are not initialized during sql engine creation
1987: Automatically GC during SQL server execution
864: Postgres compatible mode for dolt diff -r sql and dolt patch
8975: Cannot merge branches when two indexes covers same column
2847: BUG: Element types don't match MySQL: query-results have inconsistent types