Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
DropCheck.IfExistsgets copied over to new instancesThis change doesn't affect Dolt, but is needed by Doltgres to make sure
IF EXISTSlogic for dropping a constraint is correctly executed.Schema() was being called during Doltgres's
Prepareimplementation, and there's no reason it can't be.ALTER TABLE ... DROP CONSTRAINT IF EXISTSDepends on: Add AST support for
DROP CONSTRAINT IF EXISTSdolthub/vitess#411ntileThis PR implements the
NTILE()SQL function, which groups rows into evenly sized buckets.mysql docs: https://dev.mysql.com/doc/refman/8.4/en/window-function-descriptions.html#function_ntile
fixes: Request for
NTILEfunction dolthub/dolt#9087find_in_setfunction.This was missed in the initial wrapped values PR because we only had tests for
find_in_setwhere the inputs came from VARCHAR columns. This adds a test for inputs fromTEXTcolumns.Fixes Handler caught panic: interface conversion: interface {} is *val.TextStorage, not string dolthub/dolt#9101
ConvertToBytes is a commonly called function to get the string representation of a value. However, it has some unnecessary allocations where a child function allocates a byte buffer, only for the result to be copied into the buffer provided by the parent function. In other places we needlessly round-trip between string and []byte.
This PR improves performance by removing some of these unneeded copies. In places where ConvertToBytes calls a function that allocates a buffer (instead of using the buffer that ConvertToBytes can provide), we can optimize by using the returned value without copying it again.
Dolt shows a 7% improvement in the
types_table_scanbenchmark.We can potentially do even better by allowing these child functions to take a buffer, removing the need for an extra allocation.
Required for proper type conversion in doltgres
vitess
DROP CONSTRAINT IF EXISTSntilesyntaxThis PR implements the correct syntax for
NTILE()mysql docs: https://dev.mysql.com/doc/refman/8.4/en/window-function-descriptions.html#function_ntile
syntax for: Request for
NTILEfunction dolthub/dolt#9087var_sampto keywordsClosed Issues
NTILEfunction