Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
NULcharacter to string incrementA customer reported a bug with lookup_join.
It turns out in the prolly iterator, we weren't correctly incrementing strings.
We were appending
"0"(character 0) when we should've been appending"\000"(the NUL character).tests: [no-release-notes] test for lookup join dolthub/go-mysql-server#2956
This change also makes it possible for a long-running COMMIT operation to cancel while it is waiting for the transaction lock.
dolt admin createchunkis a set of undocumented commands for manually writing chunks into the chunkstore. They're a useful tool for writing tests, fixing repos that somehow get into an unexpected state, and hacking on Dolt in ways that the higher-level commands don't support.dolt admin createchunk commitis the first such command; it creates a commit chunk and prints the new commit hash to standard output.I picked
createchunk committo implement first because it already has utility: it can be used to flatten commit history. Dolt already allows flattening commit history viadolt rebase, but this method introduces a lot of overhead: it walks the commit history to build the rebase table, then walks it again to apply the rebase. For large histories (the kind of histories you might want to squash to save space), this is unacceptably slow.With this command, flattening a history can be done with
dolt admin createchunk commit --root "$rootValueHash" --desc "flattened history" --parents "refs/internal/create" --branch "$branchname" --forceThe
--branchflag causes the named branch to point to the newly created commit. This flag is mandatory when using the CLI, because the chunk journal is required to end with a root hash and chunks are only flushed to the chunk journal when there's a new root hash.go-mysql-server
When we initially implemented implicit commits, we did not exclude temporary tables. This PR addresses that issue.
These queries no longer implicitly commit the ongoing transaction:
create temporary table tmp_tbl(...),insert into table tmp_tbl ...,drop temporary table tmp_tblHowever
drop table tmp_tblwill still cause an implicit commit even thoughtmp_tblis defined as a temporary table (not sure if this is intentional from MySQL side).Additionally,
alter table tmp_tbl ...will also cause an implicit commit, but we don't support altering temporary tables (issue).Fixes: CREATE TEMPORARY TABLE during a transaction causes a commit dolthub/dolt#9149
Closed Issues