Skip to content

Conversation

@branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See #251058

Copilot AI review requested due to automatic review settings October 28, 2025 15:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation comments in two Python formula files to clarify a workaround for a hatch limitation and adds a reference to track when the workaround can be removed.

  • Replaces vague comment about invalid SOURCE_DATE_EPOCH with specific explanation of hatch's 1980 limitation
  • Adds GitHub issue link for tracking when the workaround can be removed

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Formula/k/kimi-cli.rb Updated comment to explain hatch limitation and added tracking link
Formula/h/httptap.rb Updated comment to explain hatch limitation and added tracking link

@branchvincent branchvincent added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Oct 28, 2025
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Oct 28, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 28, 2025
Merged via the queue into Homebrew:main with commit 82153d7 Oct 28, 2025
23 checks passed
@branchvincent branchvincent deleted the httptap branch October 28, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants