Skip to content

granted: fix missing assume binary #255790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2025
Merged

granted: fix missing assume binary #255790

merged 2 commits into from
Nov 26, 2025

Conversation

@emmanuj
Copy link

@emmanuj emmanuj commented Nov 24, 2025

Granted requires both granted and assume to function. This PR fixes the missing assume command.

What this PR does

  • Adds assumego symlink pointing to the granted binary
  • Installs assume shell script from source (scripts/assume)
  • Installs assume.fish shell script from source (scripts/assume.fish)

Why this is needed

Granted runs as two components:

  1. granted - the Go binary (built from source)
  2. assume - a shell script wrapper that calls assumego and exports AWS credentials to the parent shell

Without assume, users get "command not found: assume" making the tool non-functional.

Testing

brew uninstall granted --force
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source granted

Verified all binaries installed:

$ which granted && which assume && which assumego
/opt/homebrew/bin/granted
/opt/homebrew/bin/assume
/opt/homebrew/bin/assumego

$ granted --version
Granted version: 0.38.0

Assume command works:

$ assume poc
[✔] [poc](us-west-2) session credentials will expire in 12 hours

Tests pass:

$ brew test granted
==> Testing granted
==> /opt/homebrew/Cellar/granted/0.38.0/bin/granted --version
==> /opt/homebrew/Cellar/granted/0.38.0/bin/granted auth configure 2>&1

Style check:

$ brew style granted.rb
1 file inspected, no offenses detected

Closes #249904

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue autosquash Automatically squash pull request commits according to Homebrew style. labels Nov 24, 2025
@emmanuj emmanuj force-pushed the fix-granted-assume-binary branch from d9e4c43 to f1e9d3e Compare November 24, 2025 20:45
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@emmanuj emmanuj force-pushed the fix-granted-assume-binary branch from f1e9d3e to 8630f61 Compare November 24, 2025 20:52
SMillerDev
SMillerDev reviewed Nov 24, 2025
View reviewed changes
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 25, 2025
@emmanuj emmanuj force-pushed the fix-granted-assume-binary branch from 4ac3da1 to 10b6cbe Compare November 25, 2025 02:01
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 25, 2025
SMillerDev
SMillerDev reviewed Nov 25, 2025
View reviewed changes
@emmanuj emmanuj force-pushed the fix-granted-assume-binary branch from 10b6cbe to 6c15db7 Compare November 25, 2025 16:25
SMillerDev
SMillerDev reviewed Nov 26, 2025
View reviewed changes
@emmanuj emmanuj force-pushed the fix-granted-assume-binary branch from 6c15db7 to 02d3e83 Compare November 26, 2025 20:20
emmanuj
emmanuj commented Nov 26, 2025
View reviewed changes
@emmanuj emmanuj force-pushed the fix-granted-assume-binary branch 2 times, most recently from 9eee9a8 to 8e3a31f Compare November 26, 2025 20:48
granted: fix missing assume binary
14cc034 
Granted requires both 'granted' and 'assume' binaries to function.
The assume script exports AWS credentials to the parent shell.

Closes Homebrew#249904
@emmanuj emmanuj force-pushed the fix-granted-assume-binary branch from 8e3a31f to 14cc034 Compare November 26, 2025 21:22
p-linnane
p-linnane approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 26, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 26, 2025
Merged via the queue into Homebrew:main with commit 54f6316 Nov 26, 2025
19 checks passed
@p-linnane p-linnane mentioned this pull request Nov 27, 2025
Closed
6 tasks
@SMillerDev
Copy link
Member

SMillerDev commented Nov 27, 2025

Thanks @emmanuj ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new granted now masks tap maintained by owner of granted

4 participants

@emmanuj @SMillerDev @p-linnane @BrewTestBot