Windows support

[kapitanluffy]

I get this error. I checked Lib/python38 and it has pexpect

Traceback (most recent call last):
  File "C:\Program Files\Sublime Text\Lib\python38\sublime_plugin.py", line 325, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.8/importlib/__init__.py", line 127, in import_module
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 868, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "C:\Users\abc\AppData\Roaming\Sublime Text\Installed Packages\SSHubl.sublime-package\main.py", line 29, in <module>
  File "C:\Users\abc\AppData\Roaming\Sublime Text\Installed Packages\SSHubl.sublime-package\sshubl/commands.py", line 12, in <module>
  File "C:\Users\abc\AppData\Roaming\Sublime Text\Installed Packages\SSHubl.sublime-package\sshubl/actions.py", line 17, in <module>
  File "C:\Users\abc\AppData\Roaming\Sublime Text\Installed Packages\SSHubl.sublime-package\sshubl/ssh_utils.py", line 13, in <module>
  File "C:\Users\abc\AppData\Roaming\Sublime Text\Lib\python38\pexpect\pxssh.py", line 23, in <module>
    from pexpect import ExceptionPexpect, TIMEOUT, EOF, spawn
ImportError: cannot import name 'spawn' from 'pexpect' (C:\Users\abc\AppData\Roaming\Sublime Text\Lib\python38\pexpect\__init__.py)

[HorlogeSkynet]

Hello @kapitanluffy, so it appears pxssh isn't supported on Windows (see pexpect/pexpect#567 or pexpect/pexpect#339). We'll try to come out with a native workaround.

[HorlogeSkynet]

Hello there, please see #25 for implementation proposal 🙇

[kapitanluffy]

Hello there, please see #25 for implementation proposal 🙇

Thank you so much for trying to fix it! I will try to test it personally later but I looked into the code and the workaround seems fine 👍

I hope you don't mind me "approving" the PR 😅

[kapitanluffy]

I get this error @HorlogeSkynet

[HorlogeSkynet]

Thanks for trying this out @kapitanluffy ! It looks like we've precisely fallen in shlex.quote (used by shlex.join) pitfall on non-POSIX platforms, which eventually causes ssh command line parsing issues (mainly due to whitespaces in sockets directory path).

Unfortunately mslex isn't packaged for Sublime. I was on the verge of vendoring it, but it's licensed under Apache v2, so I don't know whether we actually can redistribute it under GPL v3 in SSHubl...
We could also prepare a repository for inclusion in Package Control default channel.

Tell me what you think about that ! Bye 👋