org.springframework.core.convert.ConverterNotFoundException when using Hotswap agent

[jorgheymans]

Hi,

I have a small spring-boot + Vaadin application that starts fine without hotswapagent. When enabling hotswapagent though (either using the IntelliJ vaadin plugin or by manually copying hotswap-agent.jar to the jdk directory), i get this error during startup:

Failed to bind properties under 'my.property.allowed-media-types[0]' to org.apache.tika.mime.MediaType:

    Property: my.property.upload.allowed-media-types[0]
    Value: "text/plain"
    Origin: class path resource [application.yml] - 48:11
    Reason: org.springframework.core.convert.ConverterNotFoundException: No converter found capable of converting from type [java.lang.String] to type [org.apache.tika.mime.MediaType]

Action:

Update your application's configuration

Any idea what could be causing this ? Using OpenJDK Runtime Environment JBR-17.0.14+1-1367.22-jcef (build 17.0.14+1-b1367.22), hotswap-agent 2.0.2.

[jorgheymans]

The offending yaml is a bit of custom config in application.yml :

    upload:
      allowed-media-types:
#        - text/plain
#        - application/msword
#        - application/vnd.openxmlformats-officedocument.wordprocessingml.document
#        - image/jpeg
#        - application/vnd.ms-outlook
#        - application/pdf
#        - application/vnd.ms-excel
#        - application/vnd.openxmlformats-officedocument.spreadsheetml.sheet

If i uncomment one of the media-types the error occurs. When all are commented out, the application starts fine with the hotswap agent (either through the Vaadin plugin or with jdk/lib/hotswap/hotswap-agent.jar).

[jorgheymans]

It can be reproduced with a minimal spring-boot starter project (sorry for the inline pasting as it was easier than to share a git repo somewhere, it's really minimal)

pom.xml:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.example.application</groupId>
  <artifactId>my-app</artifactId>
  <name>my-app</name>
  <version>1.0-SNAPSHOT</version>
  <packaging>jar</packaging>

  <parent>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-parent</artifactId>
    <version>3.4.4</version>
  </parent>

  <dependencies>
    <dependency>
      <groupId>org.apache.tika</groupId>
      <artifactId>tika-core</artifactId>
      <version>2.9.3</version>
    </dependency>

    <dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-starter-validation</artifactId>
    </dependency>
  </dependencies>

Application class:

@SpringBootApplication
public class Application {

  public static void main(String[] args) {
    SpringApplication.run(Application.class, args);
  }

  @Configuration
  @EnableConfigurationProperties(TikaProperties.class)
  public static class MyAutoConfiguration {}

  @ConfigurationProperties("tika")
  public static class TikaProperties {

    private List<MediaType> allowedMediaTypes = new ArrayList<>();

    public List<MediaType> getAllowedMediaTypes() {
      return allowedMediaTypes;
    }

    public void setAllowedMediaTypes(List<MediaType> mediaTypes) {
      this.allowedMediaTypes = mediaTypes;
    }
  }
}

With application.yml being:

tika:
  allowed-media-types:
    - text/plain
    - application/msword

HOTSWAP AGENT: 15:01:47.536 INFO (org.hotswap.agent.HotswapAgent) - Loading Hotswap agent {2.0.2} - unlimited runtime class redefinition.
HOTSWAP AGENT: 15:01:48.076 INFO (org.hotswap.agent.config.PluginRegistry) - Discovered plugins: [JdkPlugin, ClassInitPlugin, AnonymousClassPatch, WatchResources, Hotswapper, Hibernate, HibernateJakarta, Hibernate3JPA, Hibernate3, Spring, SpringBoot, Jersey1, Jersey2, Jetty, Tomcat, ZK, Logback, Log4j2, MyFaces, Mojarra, Omnifaces, ELResolver, WildFlyELResolver, OsgiEquinox, Owb, OwbJakarta, Proxy, WebObjects, Weld, WeldJakarta, JBossModules, ResteasyRegistry, Deltaspike, DeltaspikeJakarta, GlassFish, Weblogic, Vaadin, Wicket, CxfJAXRS, FreeMarker, Undertow, MyBatis, MyBatisPlus, IBatis, JacksonPlugin, Idea, Thymeleaf, Velocity, Sponge]
HOTSWAP AGENT: 15:01:48.926 INFO (org.hotswap.agent.config.PluginRegistry) - Plugin 'org.hotswap.agent.plugin.spring.boot.SpringBootPlugin' initialized in ClassLoader 'jdk.internal.loader.ClassLoaders$AppClassLoader@1dbd16a6'.
HOTSWAP AGENT: 15:01:48.928 INFO (org.hotswap.agent.plugin.spring.boot.SpringBootPlugin) - Spring Boot plugin initialized - Spring Boot core version '3.4.4'


........

***************************
APPLICATION FAILED TO START
***************************

Description:

Failed to bind properties under 'tika.allowed-media-types[0]' to org.apache.tika.mime.MediaType:

    Property: tika.allowed-media-types[0]
    Value: "text/plain"
    Origin: class path resource [application.yml] - 3:7
    Reason: org.springframework.core.convert.ConverterNotFoundException: No converter found capable of converting from type [java.lang.String] to type [org.apache.tika.mime.MediaType]

Action:

Update your application's configuration

Disconnected from the target VM, address: '127.0.0.1:34675', transport: 'socket'

[jorgheymans]

It seems my repro is not correct, as it fails to start also without hotswap-agent. Investigating further ......

[jorgheymans]

State of play is that i still have a larger application that always fails to start with hotswap (but starts without), but extracting a repro is quite difficult, my above attempt does not trigger the problem. Is there anything I can provide to help troubleshoot this ?

[skybber]

Could you try please if the problem is in Spring plugin using -Dhotswapagent.disablePlugin=Spring,SpringBoot ?

[jorgheymans]

Indeed, with disabledPlugins=Spring in hotswap-agent.properties the problem goes away. The SpringBoot plugin can stay activated.

[jorgheymans]

What it boils down to, from the error message, is that one of our custom starters fails to initialize itself because a converter bean that creates Tika MediaTypes from the application.yml configuration cannot be found. The starter defines it like this:

  @Bean
  @ConfigurationPropertiesBinding
  MediaTypeConverter mediaTypeConverter() {
    return new MediaTypeConverter();
  }

  public static class MediaTypeConverter implements Converter<String, MediaType> {

    @Override
    public MediaType convert(String source) {
      return MediaType.parse(source);
    }
  }

So maybe it is something around @ConfigurationPropertiesBinding that is not supported ?

[skybber]

Unfortunately I'm not expert on SpringPlugin, may be @cvictory or @beiwei30 could help please?