feat: don't display top screen banner (#321)

keeping styles this banner affect,
but remove data-access logic which should be rewritten,
if this kind of banner would return

Author: dokolyski

libs/blog/ad-banner/data-access/src/index.ts

@@ -1 +0,0 @@
-export * from './lib/state/ad-banner.store';

libs/blog/ad-banner/data-access/src/lib/infrastructure/ad-banner.service.ts

@@ -2,12 +2,11 @@ import { DatePipe, NgClass } from '@angular/common';
 import {
   ChangeDetectionStrategy,
   Component,
-  inject,
   input,
+  signal,
 } from '@angular/core';
 import { FastSvgComponent } from '@push-based/ngx-fast-svg';
 
-import { AdBannerStore } from '@angular-love/blog/ad-banner/data-access';
 import { GiscusCommentsComponent } from '@angular-love/blog/articles/feature-comments';
 import { RelatedArticlesComponent } from '@angular-love/blog/articles/feature-related-articles';
 import { ArticleCompactCardSkeletonComponent } from '@angular-love/blog/articles/ui-article-card';
@@ -61,6 +60,5 @@ import { ArticleShareIconsComponent } from '../article-share-icons/article-share
 })
 export class ArticleDetailsComponent {
   readonly articleDetails = input.required<Article>();
-  protected readonly adBannerStoreVisible =
-    inject(AdBannerStore).adBannerVisible;
+  protected readonly adBannerStoreVisible = signal(false);
 }

libs/blog/ad-banner/data-access/src/lib/state/ad-banner.store.ts

@@ -10,6 +10,7 @@ import {
   inject,
   OnDestroy,
   OnInit,
+  signal,
   viewChild,
 } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
@@ -24,7 +25,6 @@ import { TranslocoDirective, TranslocoService } from '@jsverse/transloco';
 import { FastSvgComponent } from '@push-based/ngx-fast-svg';
 import { debounceTime, filter, startWith, tap } from 'rxjs';
 
-import { AdBannerStore } from '@angular-love/blog/ad-banner/data-access';
 import {
   AlLocalizePipe,
   AlLocalizeService,
@@ -60,8 +60,7 @@ export class SearchDialogComponent implements OnInit, OnDestroy {
     validators: [Validators.maxLength(50)],
   });
 
-  protected readonly adBannerStoreVisible =
-    inject(AdBannerStore).adBannerVisible;
+  protected readonly adBannerStoreVisible = signal(false);
 
   private readonly _searchService = inject(GlobalSearchService);
   private readonly _searchInput =

libs/blog/articles/feature-article/src/lib/article-details/article-details.component.ts

@@ -1,11 +1,10 @@
 import { NgClass, ViewportScroller } from '@angular/common';
-import { Component, computed, effect, inject, signal } from '@angular/core';
+import { Component, computed, effect, inject } from '@angular/core';
 import { toSignal } from '@angular/core/rxjs-interop';
 import { Router, RouterOutlet } from '@angular/router';
 import { TranslocoService } from '@jsverse/transloco';
 import { startWith } from 'rxjs';
 
-import { AdBannerStore } from '@angular-love/blog/ad-banner/data-access';
 import { AlLocalizeService } from '@angular-love/blog/i18n/util';
 import {
   FooterComponent,
@@ -19,13 +18,14 @@ import { AdBannerComponent } from '@angular-love/blog/shared/ad-banner';
   selector: 'al-root-shell',
   template: `
     <div class="fixed top-0 z-10 w-full">
-      @if (adBannerVisible()) {
+      <!--top screen closable banner-->
+      <!--@if (adBannerVisible()) {
         <al-ad-banner
           class="block"
           [data]="adBanner()"
           (closed)="adBannerStore.onClose()"
         />
-      }
+      }-->
       <al-header
         class="block w-full"
         [language]="language()"
@@ -53,17 +53,8 @@ import { AdBannerComponent } from '@angular-love/blog/shared/ad-banner';
 export class RootShellComponent {
   readonly translocoService = inject(TranslocoService);
 
-  protected readonly adBannerStore = inject(AdBannerStore);
-
-  protected readonly adBannerVisible = computed(() => {
-    //TODO: after data-binding is done we can set this boolean if wp sends banner data
-    const data = this.adBannerStore.adBanner;
-    return this.adBannerStore.adBannerVisible() && data();
-  });
-
-  protected readonly adBanner = computed(() => {
-    return this.adBannerStore.adBanner();
-  });
+  // todo: temporary solution to keep in mind how banner influence the layout
+  protected readonly adBannerVisible = computed(() => false);
 
   readonly language = toSignal(
     this.translocoService.langChanges$.pipe(
@@ -84,6 +75,7 @@ export class RootShellComponent {
   }
 
   constructor(viewport: ViewportScroller) {
+    // todo: temporary solution to keep in mind how banner influence the layout
     effect(() => {
       this.adBannerVisible()
         ? viewport.setOffset([0, 160])