The style cache has to handle all parents of added or deleted nodes

rbri · rbri · commit 0c60de866ddb · 2025-03-22T17:05:29.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.11.0" date="March xx, 2025" description="Chrome/Edge 134, Firefox 136, Rhino RegExp, less dependencies, Bugfixes">
+            <action type="fix" dev="rbri" issue="#942">
+                The style cache has to handle all parents of added or deleted nodes.
+            </action>
             <action type="remove" dev="rbri">
                 Class HiddenFunctionObject removed, this was a leftover from the IE age.
             </action>
diff --git a/src/main/java/org/htmlunit/html/HtmlPage.java b/src/main/java/org/htmlunit/html/HtmlPage.java
@@ -2783,7 +2783,8 @@ private void nodeChanged(final DomNode changedNode, final String attribName) {
             }
 
             // Apparently it wasn't a stylesheet that changed; be semi-smart about what we evict and when.
-            final boolean clearParents = ATTRIBUTES_AFFECTING_PARENT.contains(attribName);
+            // null means that a node was added/removed; we always have to take care of this for the parents
+            final boolean clearParents = attribName == null || ATTRIBUTES_AFFECTING_PARENT.contains(attribName);
             if (computedStylesCache_ != null) {
                 computedStylesCache_.nodeChanged(changedNode, clearParents);
             }
diff --git a/src/test/java/org/htmlunit/javascript/host/css/CSSStyleSheetTest.java b/src/test/java/org/htmlunit/javascript/host/css/CSSStyleSheetTest.java
@@ -24,6 +24,7 @@
 import org.htmlunit.WebDriverTestCase;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.annotation.Alerts;
+import org.htmlunit.junit.annotation.HtmlUnitNYI;
 import org.htmlunit.util.MimeType;
 import org.htmlunit.util.NameValuePair;
 import org.junit.Test;
@@ -2056,8 +2057,14 @@ public void widthHeightPercent() throws Exception {
      * @throws Exception if the test fails
      */
     @Test
-    @Alerts({"0 622 / 722", "1 622 / 722", "2 622 / 722", "3 622 / 722",
-             "4 622 / 722", "5 622 / 722", "6 622 / 722"})
+    @Alerts(CHROME = "break at: 10 660.5833740234375 / 622",
+        EDGE = "break at: 10 660.5833740234375 / 631",
+        FF = "break at: 11 726.63330078125 / 676",
+        FF_ESR = "break at: 11 726.63330078125 / 677")
+    @HtmlUnitNYI(CHROME = "break at: 33 620 / 605",
+        EDGE = "break at: 33 620 / 605",
+        FF = "break at: 33 620 / 605",
+        FF_ESR = "break at: 33 620 / 605")
     public void endlessLoop() throws Exception {
         final String html = DOCTYPE_HTML
             + "<html>\n"
@@ -2069,16 +2076,21 @@ public void endlessLoop() throws Exception {
             + "<script>\n"
             + LOG_TITLE_FUNCTION
 
+            + "  var lastBottom = 0;\n"
             + "  for (let i = 0; i < 70; i++) {\n"
             + "    let windowRelativeBottom = document.documentElement.getBoundingClientRect().bottom;\n"
-            + "    let stop = document.documentElement.clientHeight + 100;"
+            + "    let stop = document.documentElement.clientHeight;"
             + "    if (windowRelativeBottom > stop) {\n"
             + "      log('break at: ' + i + ' ' + windowRelativeBottom + ' / ' + stop);\n"
             + "      break;\n"
             + "    }\n"
-            + "    log(i + ' ' + windowRelativeBottom + ' / ' + stop);\n"
+            + "    if (lastBottom >= windowRelativeBottom) {\n"
+            + "      log('error at: ' + i + ' ' + windowRelativeBottom + ' / ' + lastBottom);\n"
+            + "      break;\n"
+            + "    }\n"
+            + "    lastBottom = windowRelativeBottom;\n"
 
-            + "    document.body.insertAdjacentHTML('beforeend', `<p>Date: ${new Date()}</p>`);\n"
+            + "    document.body.insertAdjacentHTML('beforeend', '<h1>H 1</h1>');\n"
             + "  }\n"
             + "</script>\n"
 

Original file line number	Diff line number	Diff line change
`@@ -2783,7 +2783,8 @@ private void nodeChanged(final DomNode changedNode, final String attribName) {`
`2783`	`2783`	`}`
`2784`	`2784`
`2785`	`2785`	`// Apparently it wasn't a stylesheet that changed; be semi-smart about what we evict and when.`
`2786`		`- final boolean clearParents = ATTRIBUTES_AFFECTING_PARENT.contains(attribName);`
	`2786`	`+ // null means that a node was added/removed; we always have to take care of this for the parents`
	`2787`	`+ final boolean clearParents = attribName == null \|\| ATTRIBUTES_AFFECTING_PARENT.contains(attribName);`
`2787`	`2788`	`if (computedStylesCache_ != null) {`
`2788`	`2789`	`computedStylesCache_.nodeChanged(changedNode, clearParents);`
`2789`	`2790`	`}`