micro optimization

Author: rbri

src/main/java/org/htmlunit/HttpWebConnection.java

@@ -426,7 +426,8 @@ private static Charset getCharset(final Charset charset, final List<NameValuePai
                 final KeyDataPair pairWithFile = (KeyDataPair) pair;
                 if (pairWithFile.getData() == null && pairWithFile.getFile() != null) {
                     final String fileName = pairWithFile.getFile().getName();
-                    for (int i = 0; i < fileName.length(); i++) {
+                    final int length = fileName.length();
+                    for (int i = 0; i < length; i++) {
                         if (fileName.codePointAt(i) > 127) {
                             return charset;
                         }

src/main/java/org/htmlunit/css/CssStyleSheet.java

@@ -1205,7 +1205,8 @@ public static boolean isActive(final MediaListImpl mediaList, final WebWindow we
             return true;
         }
 
-        for (int i = 0; i < mediaList.getLength(); i++) {
+        final int length = mediaList.getLength();
+        for (int i = 0; i < length; i++) {
             final MediaQuery mediaQuery = mediaList.mediaQuery(i);
             boolean isActive = isActive(mediaQuery, webWindow);
             if (mediaQuery.isNot()) {

src/main/java/org/htmlunit/html/HtmlElement.java

@@ -679,7 +679,8 @@ public Page type(final Keyboard keyboard) throws IOException {
             }
         }
 
-        for (int i = 0; i < keys.size(); i++) {
+        final int size = keys.size();
+        for (int i = 0; i < size; i++) {
             final Object[] entry = keys.get(i);
             if (entry.length == 1) {
                 type((char) entry[0], i == keys.size() - 1);

src/main/java/org/htmlunit/html/HtmlTable.java

@@ -91,9 +91,11 @@ public final HtmlTableCell getCellAt(final int rowIndex, final int columnIndex)
                         return cell;
                     }
                 }
-                if (cell.getRowSpan() > 1 || cell.getColumnSpan() > 1) {
-                    for (int i = 0; i < cell.getRowSpan(); i++) {
-                        for (int j = 0; j < cell.getColumnSpan(); j++) {
+                final int rowSpan = cell.getRowSpan();
+                final int columnSpan = cell.getColumnSpan();
+                if (rowSpan > 1 || columnSpan > 1) {
+                    for (int i = 0; i < rowSpan; i++) {
+                        for (int j = 0; j < columnSpan; j++) {
                             occupied.add(new Position(row + i, col + j));
                         }
                     }

src/main/java/org/htmlunit/html/impl/SimpleRange.java

@@ -521,7 +521,8 @@ private static void deleteBefore(final DomNode node, int offset) {
         }
         else {
             final DomNodeList<DomNode> children = node.getChildNodes();
-            for (int i = 0; i < offset && i < children.getLength(); i++) {
+            final int length = children.getLength();
+            for (int i = 0; i < offset && i < length; i++) {
                 final DomNode child = children.get(i);
                 child.remove();
                 i--;
@@ -540,7 +541,8 @@ private static void deleteAfter(final DomNode node, final int offset) {
         }
         else {
             final DomNodeList<DomNode> children = node.getChildNodes();
-            for (int i = offset; i < children.getLength(); i++) {
+            final int length = children.getLength();
+            for (int i = offset; i < length; i++) {
                 final DomNode child = children.get(i);
                 child.remove();
                 i--;

src/main/java/org/htmlunit/html/xpath/XPathHelper.java

@@ -112,7 +112,8 @@ public static <T> List<T> getByXPath(final Node node, final XPathAdapter xpath,
 
             if (result instanceof XNodeSet) {
                 final NodeList nodelist = result.nodelist();
-                for (int i = 0; i < nodelist.getLength(); i++) {
+                final int length = nodelist.getLength();
+                for (int i = 0; i < length; i++) {
                     list.add((T) nodelist.item(i));
                 }
             }

src/main/java/org/htmlunit/httpclient/HtmlUnitBrowserCompatCookieSpec.java

@@ -223,7 +223,8 @@ public List<Header> formatCookies(final List<Cookie> cookies) {
         final CharArrayBuffer buffer = new CharArrayBuffer(20 * cookies.size());
         buffer.append(SM.COOKIE);
         buffer.append(": ");
-        for (int i = 0; i < cookies.size(); i++) {
+        final int size = cookies.size();
+        for (int i = 0; i < size; i++) {
             final Cookie cookie = cookies.get(i);
             if (i > 0) {
                 buffer.append("; ");

src/main/java/org/htmlunit/javascript/host/crypto/Crypto.java

@@ -85,7 +85,8 @@ public NativeTypedArrayView<?> getRandomValues(final NativeTypedArrayView<?> arr
                     DOMException.QUOTA_EXCEEDED_ERR);
         }
 
-        for (int i = 0; i < array.getByteLength() / array.getBytesPerElement(); i++) {
+        final int lenght = array.getByteLength() / array.getBytesPerElement();
+        for (int i = 0; i < lenght; i++) {
             array.put(i, array, RANDOM.nextInt());
         }
         return array;

src/main/java/org/htmlunit/javascript/host/dom/DOMTokenList.java

@@ -371,7 +371,8 @@ public Object[] getIds() {
 
         final List<String> parts = split(getValue());
         final Object[] ids = new Object[parts.size() + normalIds.length];
-        for (int i = 0; i < parts.size(); i++) {
+        final int size = parts.size();
+        for (int i = 0; i < size; i++) {
             ids[i] = i;
         }
         System.arraycopy(normalIds, 0, ids, parts.size(), normalIds.length);
@@ -421,7 +422,8 @@ public void forEach(final Object callback) {
             final Function function = (Function) callback;
             final Scriptable scope = getParentScope();
             final List<String> parts = split(value);
-            for (int i = 0; i < parts.size(); i++) {
+            final int size = parts.size();
+            for (int i = 0; i < size; i++) {
                 function.call(cx, scope, this, new Object[] {parts.get(i), i, this});
             }
             return null;

src/main/java/org/htmlunit/javascript/host/dom/Document.java

@@ -624,7 +624,8 @@ public HtmlUnitScriptable createElement(final Object tagName) {
                         "createElement: Provided string '" + tagNameString + "' contains an invalid character",
                         org.htmlunit.javascript.host.dom.DOMException.INVALID_CHARACTER_ERR);
             }
-            for (int i = 1; i < tagNameString.length(); i++) {
+            final int length = tagNameString.length();
+            for (int i = 1; i < length; i++) {
                 final int c = tagNameString.charAt(i);
                 if (!(Character.isLetterOrDigit(c)
                         || ':' == c