FF 135

rbri · rbri · commit 3e6018f960d4 · 2025-02-05T17:42:30.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -7,7 +7,7 @@
     </properties>
 
     <body>
-        <release version="4.10.0" date="February xx, 2025" description="Bugfixes">
+        <release version="4.10.0" date="February xx, 2025" description="Firefox 135, Javascript Errors, Bugfixes">
             <action type="update" dev="RhinoTeam">
                 core-js: Function hoisting inside blocks is no a core Rhino feature, our own hack is gone.
             </action>
diff --git a/src/main/java/org/htmlunit/BrowserVersionFeatures.java b/src/main/java/org/htmlunit/BrowserVersionFeatures.java
@@ -265,6 +265,10 @@ public enum BrowserVersionFeatures {
     @BrowserFeature(FF)
     JS_CLIENTHEIGHT_RADIO_CHECKBOX_14,
 
+    /** ClientWidth for text/password input is 154. */
+    @BrowserFeature(FF_ESR)
+    JS_CLIENTWIDTH_INPUT_TEXT_154,
+
     /** ClientWidth for text/password input is 173. */
     @BrowserFeature({CHROME, EDGE})
     JS_CLIENTWIDTH_INPUT_TEXT_173,
diff --git a/src/main/java/org/htmlunit/css/ComputedCssStyleDeclaration.java b/src/main/java/org/htmlunit/css/ComputedCssStyleDeclaration.java
@@ -18,6 +18,7 @@
 import static org.htmlunit.BrowserVersionFeatures.JS_CLIENTHEIGHT_INPUT_18;
 import static org.htmlunit.BrowserVersionFeatures.JS_CLIENTHEIGHT_RADIO_CHECKBOX_10;
 import static org.htmlunit.BrowserVersionFeatures.JS_CLIENTHEIGHT_RADIO_CHECKBOX_14;
+import static org.htmlunit.BrowserVersionFeatures.JS_CLIENTWIDTH_INPUT_TEXT_154;
 import static org.htmlunit.BrowserVersionFeatures.JS_CLIENTWIDTH_INPUT_TEXT_173;
 import static org.htmlunit.BrowserVersionFeatures.JS_CLIENTWIDTH_RADIO_CHECKBOX_10;
 import static org.htmlunit.BrowserVersionFeatures.JS_CLIENTWIDTH_RADIO_CHECKBOX_14;
@@ -1555,7 +1556,10 @@ else if (element instanceof HtmlTextInput || element instanceof HtmlPasswordInpu
                 if (browserVersion.hasFeature(JS_CLIENTWIDTH_INPUT_TEXT_173)) {
                     return 173;
                 }
-                width = 154; // FF
+                if (browserVersion.hasFeature(JS_CLIENTWIDTH_INPUT_TEXT_154)) {
+                    return 154;
+                }
+                width = 161; // FF
             }
             else if (element instanceof HtmlRadioButtonInput || element instanceof HtmlCheckBoxInput) {
                 final BrowserVersion browserVersion = getDomElement().getPage().getWebClient().getBrowserVersion();
diff --git a/src/test/java/org/htmlunit/javascript/host/css/property/ElementOffsetWidthTest.java b/src/test/java/org/htmlunit/javascript/host/css/property/ElementOffsetWidthTest.java
@@ -1760,7 +1760,7 @@ public void xmp() throws Exception {
             FF_ESR = "158")
     @HtmlUnitNYI(CHROME = "173",
             EDGE = "173",
-            FF = "154",
+            FF = "161",
             FF_ESR = "154")
     public void input() throws Exception {
         test("input");
@@ -1837,7 +1837,7 @@ public void inputHidden() throws Exception {
             FF_ESR = "158")
     @HtmlUnitNYI(CHROME = "173",
             EDGE = "173",
-            FF = "154",
+            FF = "161",
             FF_ESR = "154")
     public void inputPassword() throws Exception {
         loadPageVerifyTitle2(testInput("password"));
@@ -1885,7 +1885,7 @@ public void inputReset() throws Exception {
             FF_ESR = "158")
     @HtmlUnitNYI(CHROME = "173",
             EDGE = "173",
-            FF = "154",
+            FF = "161",
             FF_ESR = "154")
     public void inputSelect() throws Exception {
         loadPageVerifyTitle2(testInput("select"));
@@ -1919,7 +1919,7 @@ public void inputSubmit() throws Exception {
             FF_ESR = "158")
     @HtmlUnitNYI(CHROME = "173",
             EDGE = "173",
-            FF = "154",
+            FF = "161",
             FF_ESR = "154")
     public void inputText() throws Exception {
         loadPageVerifyTitle2(testInput("text"));
