remove the index based access from AbstractJavaScriptConfiguration

Author: rbri

src/main/java/org/htmlunit/javascript/configuration/AbstractJavaScriptConfiguration.java

@@ -385,20 +385,6 @@ public static boolean isCompatible(final SupportedBrowser browser1, final Suppor
         return browser1 == browser2;
     }
 
-    /**
-     * Gets the class configuration for the supplied JavaScript class name.
-     * @param hostClassName the JavaScript class name
-     * @return the class configuration for the supplied JavaScript class name
-     */
-    public ClassConfiguration getClassConfiguration(final String hostClassName) {
-        for (final ClassConfiguration classConfig : configuration_) {
-            if (hostClassName.equals(classConfig.getClassName())) {
-                return classConfig;
-            }
-        }
-        return null;
-    }
-
     /**
      * Returns an immutable map containing the DOM to JavaScript mappings. Keys are
      * java classes for the various DOM classes (e.g. HtmlInput.class) and the values

src/test/java/org/htmlunit/general/DedicatedWorkerGlobalScopeConstantsTest.java

@@ -21,6 +21,7 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Set;
 
@@ -132,8 +133,13 @@ private String[] getExpectedString(final String className) {
 
         final WorkerJavaScriptConfiguration javaScriptConfig
                 = WorkerJavaScriptConfiguration.getInstance(getBrowserVersion());
+        final HashMap<String, ClassConfiguration> classConfigurationIndex = new HashMap<>();
+        for (final ClassConfiguration config : javaScriptConfig.getAll()) {
+            classConfigurationIndex.put(config.getClassName(), config);
+        }
+
         final List<String> constants = new ArrayList<>();
-        ClassConfiguration classConfig = javaScriptConfig.getClassConfiguration(className);
+        ClassConfiguration classConfig = classConfigurationIndex.get(className);
 
         boolean first = true;
         while (classConfig != null) {
@@ -148,7 +154,7 @@ private String[] getExpectedString(final String className) {
                     }
                 }
             }
-            classConfig = javaScriptConfig.getClassConfiguration(classConfig.getExtendedClassName());
+            classConfig = classConfigurationIndex.get(classConfig.getExtendedClassName());
             first = false;
         }
 

src/test/java/org/htmlunit/general/HostConstantsTest.java

@@ -20,6 +20,7 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Set;
 
@@ -124,8 +125,13 @@ private String[] getExpectedString() throws Exception {
         }
 
         final JavaScriptConfiguration javaScriptConfig = JavaScriptConfiguration.getInstance(getBrowserVersion());
+        final HashMap<String, ClassConfiguration> classConfigurationIndex = new HashMap<>();
+        for (final ClassConfiguration config : javaScriptConfig.getAll()) {
+            classConfigurationIndex.put(config.getClassName(), config);
+        }
+
         final List<String> constants = new ArrayList<>();
-        ClassConfiguration classConfig = javaScriptConfig.getClassConfiguration(host_);
+        ClassConfiguration classConfig = classConfigurationIndex.get(host_);
 
         boolean first = true;
         while (classConfig != null) {
@@ -140,7 +146,7 @@ private String[] getExpectedString() throws Exception {
                     }
                 }
             }
-            classConfig = javaScriptConfig.getClassConfiguration(classConfig.getExtendedClassName());
+            classConfig = classConfigurationIndex.get(classConfig.getExtendedClassName());
             first = false;
         }