Skip to content

Commit 456f643

Browse files
rbrirbri
committed
get rid of NotYetImplemented
1 parent 4656407 commit 456f643

14 files changed

+514
-24
lines changed

‎src/test/java/org/htmlunit/libraries/Prototype150rc1Test.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import org.htmlunit.WebServerTestCase;
2020
import org.htmlunit.junit.BrowserRunner;
21-
import org.htmlunit.junit.annotation.NotYetImplemented;
2221
import org.junit.BeforeClass;
2322
import org.junit.Test;
2423
import org.junit.runner.RunWith;
@@ -141,7 +140,6 @@ public void hash() throws Exception {
141140
* @throws Exception if test fails
142141
*/
143142
@Test
144-
@NotYetImplemented
145143
public void position() throws Exception {
146144
test("position.html");
147145
}

‎src/test/java/org/htmlunit/libraries/Prototype160Test.java‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import org.htmlunit.WebServerTestCase;
2020
import org.htmlunit.junit.BrowserRunner;
21-
import org.htmlunit.junit.annotation.NotYetImplemented;
2221
import org.junit.BeforeClass;
2322
import org.junit.Test;
2423
import org.junit.runner.RunWith;
@@ -108,7 +107,6 @@ public void base() throws Exception {
108107
* @throws Exception if test fails
109108
*/
110109
@Test
111-
@NotYetImplemented
112110
public void dom() throws Exception {
113111
test("dom.html");
114112
}
@@ -167,7 +165,6 @@ public void number() throws Exception {
167165
* @throws Exception if test fails
168166
*/
169167
@Test
170-
@NotYetImplemented
171168
public void position() throws Exception {
172169
test("position.html");
173170
}
@@ -201,7 +198,6 @@ public void string() throws Exception {
201198
* @throws Exception if test fails
202199
*/
203200
@Test
204-
@NotYetImplemented
205201
public void unitTests() throws Exception {
206202
test("unit_tests.html");
207203
}

‎src/test/java/org/htmlunit/libraries/Prototype161Test.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import org.htmlunit.WebServerTestCase;
1818
import org.htmlunit.junit.BrowserRunner;
19-
import org.htmlunit.junit.annotation.NotYetImplemented;
2019
import org.junit.BeforeClass;
2120
import org.junit.Test;
2221
import org.junit.runner.RunWith;
@@ -98,7 +97,6 @@ public void date() throws Exception {
9897
* @throws Exception if test fails
9998
*/
10099
@Test
101-
@NotYetImplemented
102100
public void dom() throws Exception {
103101
test("dom.html");
104102
}
@@ -173,7 +171,6 @@ public void periodicalExecuter() throws Exception {
173171
* @throws Exception if test fails
174172
*/
175173
@Test
176-
@NotYetImplemented
177174
public void position() throws Exception {
178175
test("position.html");
179176
}

‎src/test/java/org/htmlunit/libraries/Prototype171Test.java‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import org.htmlunit.WebServerTestCase;
1818
import org.htmlunit.junit.BrowserRunner;
19-
import org.htmlunit.junit.annotation.NotYetImplemented;
2019
import org.junit.BeforeClass;
2120
import org.junit.Test;
2221
import org.junit.runner.RunWith;
@@ -98,7 +97,6 @@ public void date() throws Exception {
9897
* @throws Exception if test fails
9998
*/
10099
@Test
101-
@NotYetImplemented
102100
public void dom() throws Exception {
103101
test("dom_test.html");
104102
}
@@ -165,7 +163,6 @@ public void hash() throws Exception {
165163
* @throws Exception if test fails
166164
*/
167165
@Test
168-
@NotYetImplemented
169166
public void layout() throws Exception {
170167
test("layout_test.html");
171168
}
@@ -198,7 +195,6 @@ public void periodicalExecuter() throws Exception {
198195
* @throws Exception if test fails
199196
*/
200197
@Test
201-
@NotYetImplemented
202198
public void position() throws Exception {
203199
test("position_test.html");
204200
}

‎src/test/java/org/htmlunit/libraries/YuiTest.java‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,13 @@
2727
import org.htmlunit.junit.BrowserRunner;
2828
import org.htmlunit.junit.annotation.Alerts;
2929
import org.htmlunit.junit.annotation.HtmlUnitNYI;
30-
import org.htmlunit.junit.annotation.NotYetImplemented;
3130
import org.junit.Before;
3231
import org.junit.Ignore;
3332
import org.junit.Test;
3433
import org.junit.runner.RunWith;
3534
import org.openqa.selenium.By;
36-
import org.openqa.selenium.StaleElementReferenceException;
3735
import org.openqa.selenium.WebDriver;
36+
import org.openqa.selenium.WebDriverException;
3837
import org.openqa.selenium.WebElement;
3938

4039
/**
@@ -172,7 +171,8 @@ public void editor() throws Exception {
172171
* @throws Exception if an error occurs
173172
*/
174173
@Test
175-
@NotYetImplemented
174+
@Alerts("")
175+
@HtmlUnitNYI("org.htmlunit.ScriptException: TypeError: Cannot call method \"appendChild\" of null")
176176
public void yuiLoaderRollup() throws Exception {
177177
doTest("yuiloader_rollup.html");
178178
}
@@ -240,7 +240,13 @@ private void doTest(final String fileName, final List<String> knownFailingTests,
240240
assertNotNull(url);
241241

242242
final WebDriver driver = getWebDriver();
243-
driver.get(url);
243+
try {
244+
driver.get(url);
245+
}
246+
catch (final WebDriverException e) {
247+
assertTrue(e.getMessage(), e.getMessage().startsWith(getExpectedAlerts()[0]));
248+
return;
249+
}
244250

245251
if (buttonToPush != null) {
246252
driver.findElement(By.id(buttonToPush)).click();
@@ -260,13 +266,7 @@ private void doTest(final String fileName, final List<String> knownFailingTests,
260266
}
261267

262268
for (final WebElement pre : tests) {
263-
final String[] parts;
264-
try {
265-
parts = pre.getText().split(" ");
266-
}
267-
catch (final StaleElementReferenceException e) {
268-
continue; // happens for FF17 on imageLoader test
269-
}
269+
final String[] parts = pre.getText().split(" ");
270270
final String result = parts[0];
271271
final String testName = parts[1].substring(0, parts[1].length() - 1);
272272
if ("pass".equalsIgnoreCase(result)) {

‎src/test/resources/libraries/prototype/1.5.0-rc1/expected.position.NYI.txt‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
5 tests, 22 assertions, 6 failures, 0 errors
2+
Status Test Message
3+
passed testPrepare 4 assertions, 0 failures, 0 errors
4+
failed testPositionedOffset 3 assertions, 1 failures, 0 errors
5+
Failure: assertEnumEqual: expected [10, 10], actual [10, 20]
6+
failed testPage 2 assertions, 2 failures, 0 errors
7+
Failure: assertEnumEqual: expected [20, 20], actual [20, 30]
8+
Failure: assertEnumEqual: expected [20, 30], actual [20, 40]
9+
passed testOffsetParent 4 assertions, 0 failures, 0 errors
10+
failed testWithin 9 assertions, 3 failures, 0 errors
11+
Failure: outside bottom
12+
Failure: outside bottom
13+
Failure: outside bottom

‎src/test/resources/libraries/prototype/1.6.0/expected.dom.NYI.txt‎

Lines changed: 123 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
1+
87 tests, 777 assertions, 34 failures, 0 errors
2+
Status Test Message
3+
passed testDollarFunction 9 assertions, 0 failures, 0 errors
4+
failed testGetElementsByClassName 15 assertions, 3 failures, 0 errors
5+
Failure: assertElementsMatch: size mismatch: 0 elements, 1 expressions (['div.B.C.D'])
6+
Failure: assertElementsMatch: size mismatch: 0 elements, 1 expressions (['li.A.C'])
7+
Failure: assertElementsMatch: size mismatch: 3 elements, 0 expressions ([])
8+
passed testElementInsertWithHTML 4 assertions, 0 failures, 0 errors
9+
passed testElementInsertWithDOMNode 5 assertions, 0 failures, 0 errors
10+
passed testElementInsertWithToElementMethod 2 assertions, 0 failures, 0 errors
11+
passed testElementInsertWithToHTMLMethod 2 assertions, 0 failures, 0 errors
12+
passed testElementInsertWithNonString 1 assertions, 0 failures, 0 errors
13+
passed testElementInsertInTables 5 assertions, 0 failures, 0 errors
14+
passed testElementInsertInSelect 2 assertions, 0 failures, 0 errors
15+
passed testElementMethodInsert 12 assertions, 0 failures, 0 errors
16+
passed testInsertionBackwardsCompatibility 4 assertions, 0 failures, 0 errors
17+
passed testElementWrap 8 assertions, 0 failures, 0 errors
18+
passed testElementWrapReturnsWrapper 2 assertions, 0 failures, 0 errors
19+
passed testElementVisible 2 assertions, 0 failures, 0 errors
20+
passed testElementToggle 4 assertions, 0 failures, 0 errors
21+
passed testElementShow 2 assertions, 0 failures, 0 errors
22+
passed testElementHide 2 assertions, 0 failures, 0 errors
23+
passed testElementRemove 1 assertions, 0 failures, 0 errors
24+
passed testElementUpdate 5 assertions, 0 failures, 0 errors
25+
passed testElementUpdateWithScript 6 assertions, 0 failures, 0 errors
26+
passed testElementUpdateInTableRow 2 assertions, 0 failures, 0 errors
27+
passed testElementUpdateInTableCell 1 assertions, 0 failures, 0 errors
28+
passed testElementUpdateInTable 1 assertions, 0 failures, 0 errors
29+
passed testElementUpdateInSelect 1 assertions, 0 failures, 0 errors
30+
passed testElementUpdateWithDOMNode 1 assertions, 0 failures, 0 errors
31+
passed testElementUpdateWithToElementMethod 1 assertions, 0 failures, 0 errors
32+
passed testElementUpdateWithToHTMLMethod 1 assertions, 0 failures, 0 errors
33+
passed testElementReplace 7 assertions, 0 failures, 0 errors
34+
passed testElementReplaceWithScript 4 assertions, 0 failures, 0 errors
35+
passed testElementReplaceWithDOMNode 1 assertions, 0 failures, 0 errors
36+
passed testElementReplaceWithToElementMethod 1 assertions, 0 failures, 0 errors
37+
passed testElementReplaceWithToHTMLMethod 1 assertions, 0 failures, 0 errors
38+
passed testElementSelectorMethod 6 assertions, 0 failures, 0 errors
39+
passed testElementAdjacent 4 assertions, 0 failures, 0 errors
40+
passed testElementIdentify 4 assertions, 0 failures, 0 errors
41+
passed testElementClassNameMethod 4 assertions, 0 failures, 0 errors
42+
passed testElementAncestors 3 assertions, 0 failures, 0 errors
43+
passed testElementDescendants 3 assertions, 0 failures, 0 errors
44+
passed testElementFirstDescendant 2 assertions, 0 failures, 0 errors
45+
passed testElementChildElements 4 assertions, 0 failures, 0 errors
46+
passed testElementImmediateDescendants 1 assertions, 0 failures, 0 errors
47+
passed testElementPreviousSiblings 3 assertions, 0 failures, 0 errors
48+
passed testElementNextSiblings 3 assertions, 0 failures, 0 errors
49+
passed testElementSiblings 2 assertions, 0 failures, 0 errors
50+
passed testElementUp 9 assertions, 0 failures, 0 errors
51+
passed testElementDown 6 assertions, 0 failures, 0 errors
52+
passed testElementPrevious 6 assertions, 0 failures, 0 errors
53+
passed testElementNext 7 assertions, 0 failures, 0 errors
54+
passed testElementInspect 3 assertions, 0 failures, 0 errors
55+
passed testElementMakeClipping 15 assertions, 0 failures, 0 errors
56+
passed testElementExtend 151 assertions, 0 failures, 0 errors
57+
passed testElementExtendReextendsDiscardedNodes 2 assertions, 0 failures, 0 errors
58+
passed testElementCleanWhitespace 9 assertions, 0 failures, 0 errors
59+
passed testElementEmpty 3 assertions, 0 failures, 0 errors
60+
passed testDescendantOf 17 assertions, 0 failures, 0 errors
61+
passed testChildOf 5 assertions, 0 failures, 0 errors
62+
passed testElementSetStyle 20 assertions, 0 failures, 0 errors
63+
passed testElementSetStyleCamelized 2 assertions, 0 failures, 0 errors
64+
passed testElementSetOpacity 6 assertions, 0 failures, 0 errors
65+
failed testElementGetStyle 25 assertions, 3 failures, 0 errors
66+
Failure: assertEqual: expected "'1240px'", actual "'1256px'"
67+
Failure: assertEqual: expected "'14px'", actual "'1256px'"
68+
Failure: assertEqual: expected "'17px'", actual "'15px'"
69+
passed testElementGetOpacity 1 assertions, 0 failures, 0 errors
70+
passed testElementReadAttribute 20 assertions, 0 failures, 0 errors
71+
passed testElementWriteAttribute 7 assertions, 0 failures, 0 errors
72+
failed testElementWriteAttributeWithBooleans 8 assertions, 1 failures, 0 errors
73+
Failure: assert: got "false"
74+
passed testElementWriteAttributeWithIssues 10 assertions, 0 failures, 0 errors
75+
passed testElementWriteAttributeWithCustom 3 assertions, 0 failures, 0 errors
76+
passed testNewElement 216 assertions, 0 failures, 0 errors
77+
failed testElementGetHeight 0 assertions, 2 failures, 0 errors
78+
Failure: assertIdentical: expected "100", actual "160"
79+
Failure: assertIdentical: expected "100", actual "160"
80+
failed testElementGetWidth 0 assertions, 2 failures, 0 errors
81+
Failure: assertIdentical: expected "200", actual "320"
82+
Failure: assertIdentical: expected "200", actual "320"
83+
failed testElementGetDimensions 0 assertions, 18 failures, 0 errors
84+
Failure: assertIdentical: expected "100", actual "160"
85+
Failure: assertIdentical: expected "200", actual "320"
86+
Failure: assertIdentical: expected "100", actual "160"
87+
Failure: assertIdentical: expected "200", actual "320"
88+
Failure: assertIdentical: expected "100", actual "160"
89+
Failure: assertIdentical: expected "200", actual "320"
90+
Failure: assertIdentical: expected "100", actual "160"
91+
Failure: assertIdentical: expected "200", actual "320"
92+
Failure: assertIdentical: expected "100", actual "160"
93+
Failure: assertIdentical: expected "200", actual "320"
94+
Failure: assertIdentical: expected "100", actual "160"
95+
Failure: assertIdentical: expected "200", actual "320"
96+
Failure: assertIdentical: expected "100", actual "160"
97+
Failure: assertIdentical: expected "200", actual "320"
98+
Failure: assertIdentical: expected "100", actual "160"
99+
Failure: assertIdentical: expected "200", actual "320"
100+
Failure: assertIdentical: expected "100", actual "160"
101+
Failure: assertIdentical: expected "200", actual "320"
102+
passed testDOMAttributesHavePrecedenceOverExtendedElementMethods 2 assertions, 0 failures, 0 errors
103+
passed testClassNames 3 assertions, 0 failures, 0 errors
104+
passed testHasClassName 6 assertions, 0 failures, 0 errors
105+
passed testAddClassName 3 assertions, 0 failures, 0 errors
106+
passed testRemoveClassName 3 assertions, 0 failures, 0 errors
107+
passed testToggleClassName 4 assertions, 0 failures, 0 errors
108+
passed testElementScrollTo 2 assertions, 0 failures, 0 errors
109+
passed testCustomElementMethods 4 assertions, 0 failures, 0 errors
110+
passed testSpecificCustomElementMethods 14 assertions, 0 failures, 0 errors
111+
passed testScriptFragment 4 assertions, 0 failures, 0 errors
112+
failed testPositionedOffset 3 assertions, 1 failures, 0 errors
113+
Failure: assertEnumEqual: expected [10, 10], actual [10, 20]
114+
failed testViewportOffset 2 assertions, 2 failures, 0 errors
115+
Failure: assertEnumEqual: expected [20, 20], actual [20, 30]
116+
Failure: assertEnumEqual: expected [20, 30], actual [20, 40]
117+
passed testOffsetParent 4 assertions, 0 failures, 0 errors
118+
passed testAbsolutize 2 assertions, 0 failures, 0 errors
119+
failed testViewportDimensions 0 assertions, 2 failures, 0 errors
120+
Failure: NOTE: YOU MUST ALLOW JAVASCRIPT TO RESIZE YOUR WINDOW FOR THESE TESTS TO PASS: expected "1306", actual "1256"
121+
Failure: NOTE: YOU MUST ALLOW JAVASCRIPT TO RESIZE YOUR WINDOW FOR THESE TESTS TO PASS: expected "655", actual "605"
122+
passed testViewportScrollOffsets 3 assertions, 0 failures, 0 errors
123+
passed testNodeConstants 13 assertions, 0 failures, 0 errors

‎src/test/resources/libraries/prototype/1.6.0/expected.position.NYI.txt‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
2 tests, 13 assertions, 3 failures, 0 errors
2+
Status Test Message
3+
passed testPrepare 4 assertions, 0 failures, 0 errors
4+
failed testWithin 9 assertions, 3 failures, 0 errors
5+
Failure: outside bottom
6+
Failure: outside bottom
7+
Failure: outside bottom

‎src/test/resources/libraries/prototype/1.6.0/expected.unit_tests.NYI.txt‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
10 tests, 82 assertions, 1 failures, 0 errors
2+
Status Test Message
3+
failed testIsRunningFromRake 0 assertions, 1 failures, 0 errors
4+
Failure: assert: got "false"
5+
Info: -- skipped for comparison --
6+
passed testAssertEqual 11 assertions, 0 failures, 0 errors
7+
passed testAssertEnumEqual 4 assertions, 0 failures, 0 errors
8+
passed testAssertHashEqual 4 assertions, 0 failures, 0 errors
9+
passed testAssertRespondsTo 2 assertions, 0 failures, 0 errors
10+
passed testAssertIdentical 15 assertions, 0 failures, 0 errors
11+
passed testAssertNullAndAssertUndefined 12 assertions, 0 failures, 0 errors
12+
passed testAssertMatch 7 assertions, 0 failures, 0 errors
13+
passed testAssertInstanceOf 3 assertions, 0 failures, 0 errors
14+
passed testAssertVisible 24 assertions, 0 failures, 0 errors

0 commit comments

Comments
 (0)