checkstyle

Author: rbri

checkstyle.xml

@@ -106,6 +106,10 @@
         <property name="message" value="System.out.print/ln found"/>
     </module>
 
+    <module name="BeforeExecutionExclusionFileFilter">
+        <property name="fileNamePattern" value="(.*[\\/]test[\\/].*$)|(module\-info\.java$)"/>
+    </module>
+
     <module name="TreeWalker">
 
         <property name="tabWidth" value="4"/>

pom.xml

@@ -69,7 +69,7 @@
         <jfreechart.version>1.5.6</jfreechart.version>
 
         <!-- quality -->
-        <checkstyle.version>13.0.0</checkstyle.version>
+        <checkstyle.version>12.3.1</checkstyle.version>
         <spotbugs.version>4.9.8</spotbugs.version>
         <pmd.version>7.20.0</pmd.version>
         <archunit.version>1.4.1</archunit.version>

src/main/java/org/htmlunit/html/impl/SimpleRange.java

@@ -462,7 +462,6 @@ public boolean equals(final Object obj) {
             .append(endOffset_, other.endOffset_).isEquals();
     }
 
-
     /**
      * {@inheritDoc}
      */

src/main/java/org/htmlunit/javascript/HtmlUnitContextFactory.java

@@ -342,7 +342,7 @@ protected boolean hasFeature(final Context cx, final int featureIndex) {
             case Context.FEATURE_E4X, Context.FEATURE_NON_ECMA_GET_YEAR -> false;
             case Context.FEATURE_HTMLUNIT_MEMBERBOX_NAME -> browserVersion_.hasFeature(JS_PROPERTY_DESCRIPTOR_NAME);
             case Context.FEATURE_HTMLUNIT_ARRAY_SORT_COMPERATOR_ACCEPTS_BOOL ->
-                    browserVersion_.hasFeature(JS_ARRAY_SORT_ACCEPTS_INCONSISTENT_COMPERATOR);
+                browserVersion_.hasFeature(JS_ARRAY_SORT_ACCEPTS_INCONSISTENT_COMPERATOR);
             default -> super.hasFeature(cx, featureIndex);
         };
     }

src/main/java/org/htmlunit/javascript/host/dom/Node.java

@@ -881,7 +881,7 @@ public boolean contains(final Object element) {
             throw JavaScriptEngine.reportRuntimeError("Could not convert JavaScript argument arg 0");
         }
 
-        for (; parent != null; parent = parent.getParentElement()) {
+        for ( ; parent != null; parent = parent.getParentElement()) {
             if (this == parent) {
                 return true;
             }

src/main/java/org/htmlunit/javascript/host/xml/FormData.java

@@ -135,7 +135,7 @@ protected Object nextValue(final Context cx, final Scriptable scope) {
                 case KEYS -> nextNameValuePair.getName();
                 case VALUES -> nextNameValuePair.getValue();
                 case BOTH ->
-                        cx.newArray(scope, new Object[]{nextNameValuePair.getName(), nextNameValuePair.getValue()});
+                    cx.newArray(scope, new Object[]{nextNameValuePair.getName(), nextNameValuePair.getValue()});
                 default -> throw new AssertionError();
             };
         }

src/main/java/org/htmlunit/util/Cookie.java

@@ -19,7 +19,6 @@
 import java.util.Objects;
 
 import org.apache.commons.lang3.builder.EqualsBuilder;
-import org.apache.commons.lang3.builder.HashCodeBuilder;
 import org.apache.http.cookie.ClientCookie;
 import org.apache.http.impl.cookie.BasicClientCookie;
 
@@ -253,8 +252,8 @@ public boolean equals(final Object o) {
      */
     @Override
     public int hashCode() {
-         final String path = getPath() == null ? "/" : getPath();
-         return Objects.hash(getName(), getDomain(), path);
+        final String path = getPath() == null ? "/" : getPath();
+        return Objects.hash(getName(), getDomain(), path);
     }
 
     /**

src/main/java/org/htmlunit/util/OrderedFastHashMap.java

@@ -1000,13 +1000,16 @@ private void orderedListRemove(final int position) {
     public String toString() {
         final int maxLen = 10;
 
-        return "mapData=%s, mapFillFactor=%s, mapThreshold=%s, mapSize=%s,%norderedList=%s, orderedListSize=%s".formatted(
-                mapData_ != null ? Arrays.asList(mapData_).subList(0, Math.min(mapData_.length, maxLen)) : null,
-                FILLFACTOR_, mapThreshold_, mapSize_,
-                orderedList_ != null
+        return "mapData=%s, mapFillFactor=%s, mapThreshold=%s, mapSize=%s,%norderedList=%s, orderedListSize=%s"
+                .formatted(
+                    mapData_ != null
+                        ? Arrays.asList(mapData_).subList(0, Math.min(mapData_.length, maxLen))
+                        : null,
+                    FILLFACTOR_, mapThreshold_, mapSize_,
+                    orderedList_ != null
                         ? Arrays.toString(Arrays.copyOf(orderedList_, Math.min(orderedList_.length, maxLen)))
                         : null,
-                orderedListSize_);
+                    orderedListSize_);
     }
 
     /**