Skip to content

Commit 71b8ce6

Browse files
committed
Chrome/Edge 141, Firefox 143, FirefoxESR 140
1 parent b0e78ab commit 71b8ce6

File tree

5 files changed

+13
-25
lines changed

5 files changed

+13
-25
lines changed

src/main/java/org/htmlunit/BrowserVersionFeatures.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,6 @@ public enum BrowserVersionFeatures {
7474
@BrowserFeature({FF, FF_ESR})
7575
EVENT_ONANIMATION_DOCUMENT_CREATE_NOT_SUPPORTED,
7676

77-
/** Triggers 'onclick' event handler using <code>PointerEvent</code>. */
78-
@BrowserFeature({CHROME, EDGE, FF})
79-
EVENT_ONCLICK_USES_POINTEREVENT,
80-
8177
/** <code>CloseEvent</code> can not be created by calling document.createEvent('CloseEvent'). */
8278
@BrowserFeature({FF, FF_ESR})
8379
EVENT_ONCLOSE_DOCUMENT_CREATE_NOT_SUPPORTED,

src/main/java/org/htmlunit/html/DomElement.java

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
package org.htmlunit.html;
1616

1717
import static org.htmlunit.BrowserVersionFeatures.EVENT_CONTEXT_MENU_HAS_DETAIL_1;
18-
import static org.htmlunit.BrowserVersionFeatures.EVENT_ONCLICK_USES_POINTEREVENT;
1918
import static org.htmlunit.BrowserVersionFeatures.JS_AREA_WITHOUT_HREF_FOCUSABLE;
2019

2120
import java.io.IOException;
@@ -1086,14 +1085,8 @@ else if (this instanceof HtmlOption) {
10861085
MouseEvent event = null;
10871086
if (webClient.isJavaScriptEnabled()) {
10881087
final BrowserVersion browser = webClient.getBrowserVersion();
1089-
if (browser.hasFeature(EVENT_ONCLICK_USES_POINTEREVENT)) {
1090-
event = new PointerEvent(getEventTargetElement(), MouseEvent.TYPE_CLICK, shiftKey,
1091-
ctrlKey, altKey, MouseEvent.BUTTON_LEFT, 1);
1092-
}
1093-
else {
1094-
event = new MouseEvent(getEventTargetElement(), MouseEvent.TYPE_CLICK, shiftKey,
1095-
ctrlKey, altKey, MouseEvent.BUTTON_LEFT, 1);
1096-
}
1088+
event = new PointerEvent(getEventTargetElement(), MouseEvent.TYPE_CLICK, shiftKey,
1089+
ctrlKey, altKey, MouseEvent.BUTTON_LEFT, 1);
10971090

10981091
if (disableProcessLabelAfterBubbling) {
10991092
event.disableProcessLabelAfterBubbling();
@@ -1489,16 +1482,11 @@ private Page doMouseEvent(final String eventType, final boolean shiftKey, final
14891482
final Event event;
14901483
if (MouseEvent.TYPE_CONTEXT_MENU.equals(eventType)) {
14911484
final BrowserVersion browserVersion = webClient.getBrowserVersion();
1492-
if (browserVersion.hasFeature(EVENT_ONCLICK_USES_POINTEREVENT)) {
1493-
if (browserVersion.hasFeature(EVENT_CONTEXT_MENU_HAS_DETAIL_1)) {
1494-
event = new PointerEvent(this, eventType, shiftKey, ctrlKey, altKey, button, 1);
1495-
}
1496-
else {
1497-
event = new PointerEvent(this, eventType, shiftKey, ctrlKey, altKey, button, 0);
1498-
}
1485+
if (browserVersion.hasFeature(EVENT_CONTEXT_MENU_HAS_DETAIL_1)) {
1486+
event = new PointerEvent(this, eventType, shiftKey, ctrlKey, altKey, button, 1);
14991487
}
15001488
else {
1501-
event = new MouseEvent(this, eventType, shiftKey, ctrlKey, altKey, button, 1);
1489+
event = new PointerEvent(this, eventType, shiftKey, ctrlKey, altKey, button, 0);
15021490
}
15031491
}
15041492
else if (MouseEvent.TYPE_DBL_CLICK.equals(eventType)) {

src/test/java/org/htmlunit/general/DedicatedWorkerGlobalScopeTypeOfTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6693,7 +6693,8 @@ public void selection() throws Exception {
66936693
@Alerts(DEFAULT = "undefined",
66946694
FF = "function",
66956695
FF_ESR = "function")
6696-
@HtmlUnitNYI(FF = "undefined")
6696+
@HtmlUnitNYI(FF = "undefined",
6697+
FF_ESR = "undefined")
66976698
public void serviceWorker() throws Exception {
66986699
test("ServiceWorker");
66996700
}
@@ -6705,7 +6706,8 @@ public void serviceWorker() throws Exception {
67056706
@Alerts(DEFAULT = "undefined",
67066707
FF = "function",
67076708
FF_ESR = "function")
6708-
@HtmlUnitNYI(FF = "undefined")
6709+
@HtmlUnitNYI(FF = "undefined",
6710+
FF_ESR = "undefined")
67096711
public void serviceWorkerContainer() throws Exception {
67106712
test("ServiceWorkerContainer");
67116713
}

src/test/java/org/htmlunit/general/HostClassNameTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,8 @@ public void css2Properties() throws Exception {
11781178
@Alerts(DEFAULT = "ReferenceError",
11791179
FF = "function CSSPageDescriptors() { [native code] }",
11801180
FF_ESR = "function CSSPageDescriptors() { [native code] }")
1181-
@HtmlUnitNYI(FF = "ReferenceError")
1181+
@HtmlUnitNYI(FF = "ReferenceError",
1182+
FF_ESR = "ReferenceError")
11821183
public void cssPageDescriptors() throws Exception {
11831184
test("CSSPageDescriptors");
11841185
}

src/test/java/org/htmlunit/general/HostTypeOfTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1158,7 +1158,8 @@ public void css2Properties() throws Exception {
11581158
@Alerts(DEFAULT = "undefined",
11591159
FF = "function",
11601160
FF_ESR = "function")
1161-
@HtmlUnitNYI(FF = "undefined")
1161+
@HtmlUnitNYI(FF = "undefined",
1162+
FF_ESR = "undefined")
11621163
public void cssPageDescriptors() throws Exception {
11631164
test("CSSPageDescriptors");
11641165
}

0 commit comments

Comments
 (0)