Skip to content

Commit 754af3d

Browse files
committed
fix some pmd warnings
1 parent e177a90 commit 754af3d

File tree

7 files changed

+10
-11
lines changed

7 files changed

+10
-11
lines changed

src/main/java/org/htmlunit/DefaultPageCreator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,7 @@ public static PageType determinePageType(final String contentType) {
119119
return PageType.UNKNOWN;
120120
}
121121

122-
final String contentTypeLC = org.htmlunit.util.StringUtils
123-
.toRootLowerCase(contentType);
122+
final String contentTypeLC = StringUtils.toRootLowerCase(contentType);
124123

125124
if (MimeType.isJavascriptMimeType(contentTypeLC)) {
126125
return PageType.JAVASCRIPT;

src/main/java/org/htmlunit/html/HtmlArea.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ protected boolean doClickStateUpdate(final boolean shiftKey, final boolean ctrlK
8080
final String href = getHrefAttribute().trim();
8181
if (!href.isEmpty()) {
8282
final HtmlPage page = (HtmlPage) getPage();
83-
if (org.htmlunit.util.StringUtils.startsWithIgnoreCase(href, JavaScriptURLConnection.JAVASCRIPT_PREFIX)) {
83+
if (StringUtils.startsWithIgnoreCase(href, JavaScriptURLConnection.JAVASCRIPT_PREFIX)) {
8484
page.executeJavaScript(
8585
href, "javascript url", getStartLineNumber());
8686
return false;
@@ -267,7 +267,7 @@ public boolean isDisplayed() {
267267

268268
private Rectangle2D parseRect() {
269269
// browsers seem to support comma and blank
270-
final String[] coords = org.htmlunit.util.StringUtils.splitAtCommaOrBlank(getCoordsAttribute());
270+
final String[] coords = StringUtils.splitAtCommaOrBlank(getCoordsAttribute());
271271

272272
double leftX = 0;
273273
double topY = 0;
@@ -299,7 +299,7 @@ private Rectangle2D parseRect() {
299299

300300
private Circle2D parseCircle() {
301301
// browsers seem to support comma and blank
302-
final String[] coords = org.htmlunit.util.StringUtils.splitAtCommaOrBlank(getCoordsAttribute());
302+
final String[] coords = StringUtils.splitAtCommaOrBlank(getCoordsAttribute());
303303

304304
double centerX = 0;
305305
double centerY = 0;
@@ -328,7 +328,7 @@ private Circle2D parseCircle() {
328328

329329
private Shape2D parsePoly() {
330330
// browsers seem to support comma and blank
331-
final String[] coords = org.htmlunit.util.StringUtils.splitAtCommaOrBlank(getCoordsAttribute());
331+
final String[] coords = StringUtils.splitAtCommaOrBlank(getCoordsAttribute());
332332

333333
try {
334334
if (coords.length > 1) {

src/main/java/org/htmlunit/html/HtmlElement.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1262,7 +1262,7 @@ public void setHidden(final String hidden) {
12621262
return;
12631263
}
12641264

1265-
if (org.htmlunit.util.StringUtils.isEmptyString(hidden)) {
1265+
if (StringUtils.isEmptyString(hidden)) {
12661266
removeAttribute(ATTRIBUTE_HIDDEN);
12671267
return;
12681268
}

src/main/java/org/htmlunit/html/HtmlMedia.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public final String getSrcAttribute() {
7777
*/
7878
public String getSrc() {
7979
final String src = getSrcAttribute();
80-
if (org.htmlunit.util.StringUtils.isEmptyString(src)) {
80+
if (StringUtils.isEmptyString(src)) {
8181
return src;
8282
}
8383
try {

src/main/java/org/htmlunit/html/HtmlOutput.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public boolean isValid() {
8787
*/
8888
@Override
8989
public boolean isCustomErrorValidityState() {
90-
return !org.htmlunit.util.StringUtils.isEmptyOrNull(customValidity_);
90+
return !StringUtils.isEmptyOrNull(customValidity_);
9191
}
9292

9393
@Override

src/main/java/org/htmlunit/html/ScriptElementSupport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ public static boolean isJavaScript(String typeAttribute, final String languageAt
297297
}
298298

299299
if (!StringUtils.isEmptyOrNull(languageAttribute)) {
300-
return org.htmlunit.util.StringUtils.startsWithIgnoreCase(languageAttribute, "javascript");
300+
return StringUtils.startsWithIgnoreCase(languageAttribute, "javascript");
301301
}
302302
return true;
303303
}

src/main/java/org/htmlunit/javascript/host/Navigator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public Scriptable getLanguages() {
111111
}
112112

113113
final ArrayList<String> res = new ArrayList<>();
114-
final String[] parts = org.htmlunit.util.StringUtils.splitAtComma(acceptLang);
114+
final String[] parts = StringUtils.splitAtComma(acceptLang);
115115
for (final String part : parts) {
116116
if (!StringUtils.isEmptyOrNull(part)) {
117117
final String lang = org.apache.commons.lang3.StringUtils.substringBefore(part, ";").trim();

0 commit comments

Comments
 (0)