BigInt support added

rbri · rbri · commit 84a95dc1c2fe · 2025-01-15T08:31:55.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -7,12 +7,19 @@
     </properties>
 
     <body>
-        <release version="4.9.0" date="February xx, 2025" description="Bugfixes">
+        <release version="4.9.0" date="February xx, 2025" description="Bugfixes, BigInt">
+            <action type="fix" dev="rbri">
+                core-js: junit-vintage-engine was NOT marked as 'test' dependency, therefore we had junit
+                as part of our depenencies/lib/diestribution (regression from 4.8.0)
+            </action>
+            <action type="add" dev="rbri">
+                BigInt support added.
+            </action>
             <action type="fix" dev="RhinoTeam">
-                core-js: Symbol.hasInstance for Function.prototype implemented
+                core-js: Symbol.hasInstance for Function.prototype implemented.
             </action>
             <action type="add" dev="rbri">
-                core-js: Context#emptyArgs is deprecated
+                core-js: Context#emptyArgs is deprecated.
             </action>
         </release>
 
diff --git a/src/main/java/org/htmlunit/javascript/JavaScriptEngine.java b/src/main/java/org/htmlunit/javascript/JavaScriptEngine.java
@@ -423,7 +423,7 @@ public static void configureRhino(final WebClient webClient,
                 NumberCustom.class, ScriptableObject.DONTENUM);
 
         // remove some objects, that Rhino defines in top scope but that we don't want
-        deleteProperties(scope, "Continuation", "StopIteration", "BigInt");
+        deleteProperties(scope, "Continuation", "StopIteration");
         if (!browserVersion.hasFeature(JS_ITERATOR_VISIBLE_IN_WINDOW)) {
             deleteProperties(scope, "Iterator");
         }
diff --git a/src/test/java/org/htmlunit/general/DedicatedWorkerGlobalScopeClassNameTest.java b/src/test/java/org/htmlunit/general/DedicatedWorkerGlobalScopeClassNameTest.java
@@ -508,6 +508,15 @@ public void beforeUnloadEvent() throws Exception {
         test("BeforeUnloadEvent");
     }
 
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts("function BigInt() { [native code] }")
+    public void bigInt() throws Exception {
+        test("BigInt");
+    }
+
     /**
      * @throws Exception if the test fails
      */
diff --git a/src/test/java/org/htmlunit/general/DedicatedWorkerGlobalScopeTypeOfTest.java b/src/test/java/org/htmlunit/general/DedicatedWorkerGlobalScopeTypeOfTest.java
@@ -505,6 +505,15 @@ public void beforeUnloadEvent() throws Exception {
         test("BeforeUnloadEvent");
     }
 
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts("function")
+    public void bigInt() throws Exception {
+        test("BigInt");
+    }
+
     /**
      * @throws Exception if the test fails
      */
diff --git a/src/test/java/org/htmlunit/general/HostClassNameTest.java b/src/test/java/org/htmlunit/general/HostClassNameTest.java
@@ -522,6 +522,15 @@ public void beforeUnloadEvent() throws Exception {
         test("BeforeUnloadEvent");
     }
 
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts("function BigInt() { [native code] }")
+    public void bigInt() throws Exception {
+        test("BigInt");
+    }
+
     /**
      * @throws Exception if the test fails
      */
diff --git a/src/test/java/org/htmlunit/general/HostTypeOfTest.java b/src/test/java/org/htmlunit/general/HostTypeOfTest.java
@@ -498,6 +498,15 @@ public void beforeUnloadEvent() throws Exception {
         test("BeforeUnloadEvent");
     }
 
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts("function")
+    public void bigInt() throws Exception {
+        test("BigInt");
+    }
+
     /**
      * @throws Exception if the test fails
      */
diff --git a/src/test/java/org/htmlunit/javascript/NativeBigIntTest.java b/src/test/java/org/htmlunit/javascript/NativeBigIntTest.java
@@ -0,0 +1,50 @@
+/*
+ * Copyright (c) 2002-2025 Gargoyle Software Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.htmlunit.javascript;
+
+import org.htmlunit.WebDriverTestCase;
+import org.htmlunit.junit.BrowserRunner;
+import org.htmlunit.junit.BrowserRunner.Alerts;
+import org.htmlunit.junit.BrowserRunner.HtmlUnitNYI;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+/**
+ * Some test for BigInt support.
+ *
+ * @author Ronald Brill
+ */
+@RunWith(BrowserRunner.class)
+public class NativeBigIntTest extends WebDriverTestCase {
+
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts(DEFAULT = {"bigint", "bigint"})
+    public void typeof() throws Exception {
+        final String html
+            = "<html>"
+            + "<body>\n"
+            + "<script>\n"
+            + LOG_TITLE_FUNCTION
+            + "  log(typeof 1n);\n"
+            + "  log(typeof BigInt('1'));\n"
+            + "</script>\n"
+            + "</body></html>";
+
+        loadPageVerifyTitle2(html);
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -423,7 +423,7 @@ public static void configureRhino(final WebClient webClient,`
`423`	`423`	`NumberCustom.class, ScriptableObject.DONTENUM);`
`424`	`424`
`425`	`425`	`// remove some objects, that Rhino defines in top scope but that we don't want`
`426`		`- deleteProperties(scope, "Continuation", "StopIteration", "BigInt");`
	`426`	`+ deleteProperties(scope, "Continuation", "StopIteration");`
`427`	`427`	`if (!browserVersion.hasFeature(JS_ITERATOR_VISIBLE_IN_WINDOW)) {`
`428`	`428`	`deleteProperties(scope, "Iterator");`
`429`	`429`	`}`