Skip to content

Commit 862b3c7

Browse files
committed
another try to optimize
1 parent ea87ce4 commit 862b3c7

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

src/main/java/org/htmlunit/html/DomNode.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,10 +1047,13 @@ private void fireAddition(final DomNode domNode) {
10471047

10481048
// a node that is already "complete" (ie not being parsed) and not yet attached
10491049
if (!domNode.isBodyParsed() && !wasAlreadyAttached) {
1050-
for (final Iterator<DomNode> iterator = domNode.new DescendantDomNodesIterator(); iterator.hasNext();) {
1051-
final DomNode child = iterator.next();
1052-
child.attachedToPage_ = true;
1053-
child.onAllChildrenAddedToPage(true);
1050+
if (domNode.getFirstChild() != null) {
1051+
for (final Iterator<DomNode> iterator =
1052+
domNode.new DescendantDomNodesIterator(); iterator.hasNext();) {
1053+
final DomNode child = iterator.next();
1054+
child.attachedToPage_ = true;
1055+
child.onAllChildrenAddedToPage(true);
1056+
}
10541057
}
10551058
domNode.onAllChildrenAddedToPage(true);
10561059
}

src/main/java/org/htmlunit/html/HtmlPage.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1745,11 +1745,13 @@ void notifyNodeAdded(final DomNode node) {
17451745
frameElements_.add((BaseFrameElement) node);
17461746
}
17471747

1748-
for (final Iterator<HtmlElement> iterator = node.new DescendantHtmlElementsIterator();
1749-
iterator.hasNext();) {
1750-
final HtmlElement child = iterator.next();
1751-
if (child instanceof BaseFrameElement) {
1752-
frameElements_.add((BaseFrameElement) child);
1748+
if (node.getFirstChild() != null) {
1749+
for (final Iterator<HtmlElement> iterator = node.new DescendantHtmlElementsIterator();
1750+
iterator.hasNext();) {
1751+
final HtmlElement child = iterator.next();
1752+
if (child instanceof BaseFrameElement) {
1753+
frameElements_.add((BaseFrameElement) child);
1754+
}
17531755
}
17541756
}
17551757

0 commit comments

Comments
 (0)