Document - several fixes to throw the correct error

rbri · rbri · commit 8920debf505f · 2025-02-03T07:14:11.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.10.0" date="February xx, 2025" description="Bugfixes">
+            <action type="fix" dev="rbri">
+                Document - several fixes to throw the correct error.
+            </action>
             <action type="fix" dev="rbri">
                 XMLHttpRequest - several fixes to throw the correct error.
             </action>
diff --git a/src/main/java/org/htmlunit/javascript/HtmlUnitScriptable.java b/src/main/java/org/htmlunit/javascript/HtmlUnitScriptable.java
@@ -109,7 +109,7 @@ public void put(final String name, final Scriptable start, final Object value) {
         }
         catch (final IllegalArgumentException e) {
             // is it the right place or should Rhino throw a RuntimeError instead of an IllegalArgumentException?
-            throw JavaScriptEngine.reportRuntimeError("'set "
+            throw JavaScriptEngine.typeError("'set "
                 + name + "' called on an object that does not implement interface " + getClassName());
         }
     }
diff --git a/src/main/java/org/htmlunit/javascript/host/dom/Document.java b/src/main/java/org/htmlunit/javascript/host/dom/Document.java
@@ -875,9 +875,13 @@ public void setBody(final HTMLElement htmlElement) {
             }
             return;
         }
-        throw JavaScriptEngine.reportRuntimeError("Failed to set the 'body' property on 'Document': "
-                + "The new body element is of type '" +  htmlElement.getTagName() + "'. "
-                + "It must be either a 'BODY' or 'FRAMESET' element.");
+        throw JavaScriptEngine.asJavaScriptException(
+                getWindow(),
+                new org.htmlunit.javascript.host.dom.DOMException(
+                        "Failed to set the 'body' property on 'Document': "
+                                + "The new body element is of type '" +  htmlElement.getTagName() + "'. "
+                                + "It must be either a 'BODY' or 'FRAMESET' element.",
+                        org.htmlunit.javascript.host.dom.DOMException.HIERARCHY_REQUEST_ERR));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public void put(final String name, final Scriptable start, final Object value) {`
`109`	`109`	`}`
`110`	`110`	`catch (final IllegalArgumentException e) {`
`111`	`111`	`// is it the right place or should Rhino throw a RuntimeError instead of an IllegalArgumentException?`
`112`		`- throw JavaScriptEngine.reportRuntimeError("'set "`
	`112`	`+ throw JavaScriptEngine.typeError("'set "`
`113`	`113`	`+ name + "' called on an object that does not implement interface " + getClassName());`
`114`	`114`	`}`
`115`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -875,9 +875,13 @@ public void setBody(final HTMLElement htmlElement) {`
`875`	`875`	`}`
`876`	`876`	`return;`
`877`	`877`	`}`
`878`		`- throw JavaScriptEngine.reportRuntimeError("Failed to set the 'body' property on 'Document': "`
`879`		`- + "The new body element is of type '" + htmlElement.getTagName() + "'. "`
`880`		`- + "It must be either a 'BODY' or 'FRAMESET' element.");`
	`878`	`+ throw JavaScriptEngine.asJavaScriptException(`
	`879`	`+ getWindow(),`
	`880`	`+ new org.htmlunit.javascript.host.dom.DOMException(`
	`881`	`+ "Failed to set the 'body' property on 'Document': "`
	`882`	`+ + "The new body element is of type '" + htmlElement.getTagName() + "'. "`
	`883`	`+ + "It must be either a 'BODY' or 'FRAMESET' element.",`
	`884`	`+ org.htmlunit.javascript.host.dom.DOMException.HIERARCHY_REQUEST_ERR));`
`881`	`885`	`}`
`882`	`886`
`883`	`887`	`/**`