DOMMatrix and DOMMatrixReadOnly stubs replaced by a real impl (incomplete)

rbri · rbri · commit 97d264b8cc83 · 2025-09-08T19:21:36.000+02:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.17.0" date="September xx, 2025" description="Chrome/Edge 140, Firefox 142, Bugfixes">
+            <action type="add" dev="rbri" issue="#371">
+                DOMMatrix and DOMMatrixReadOnly stubs replaced by a real impl (incomplete).
+            </action>
             <action type="fix" dev="René Schwietzke" issue="#1014">
                 Properly synchronize access to httpClientBuilder_ in class HttpWebConnection.
             </action>
diff --git a/src/main/java/org/htmlunit/javascript/host/dom/DOMMatrix.java b/src/main/java/org/htmlunit/javascript/host/dom/DOMMatrix.java
@@ -441,6 +441,7 @@ public double getF() {
     public void setF(final double f) {
         super.setM42(f);
     }
+
     /**
      * @return inverts the original matrix. If the matrix cannot be inverted,
      *     the new matrix's components are all set to NaN and its is2D property is set to false.
diff --git a/src/main/java/org/htmlunit/javascript/host/dom/DOMMatrixReadOnly.java b/src/main/java/org/htmlunit/javascript/host/dom/DOMMatrixReadOnly.java
@@ -853,7 +853,6 @@ public DOMMatrixReadOnly rotateAxisAngle(
      */
     @JsxFunction
     public DOMMatrixReadOnly skewX(final Object alphaObj) {
-
         // Default values
         double alpha = 0;
         if (alphaObj != null && !JavaScriptEngine.isUndefined(alphaObj)) {
@@ -880,7 +879,6 @@ public DOMMatrixReadOnly skewX(final Object alphaObj) {
      */
     @JsxFunction
     public DOMMatrixReadOnly skewY(final Object alphaObj) {
-
         // Default values
         double alpha = 0;
         if (alphaObj != null && !JavaScriptEngine.isUndefined(alphaObj)) {
diff --git a/src/test/java/org/htmlunit/general/ElementOwnPropertiesTest.java b/src/test/java/org/htmlunit/general/ElementOwnPropertiesTest.java
@@ -18383,6 +18383,30 @@ public void styleMedia() throws Exception {
                 + "m41[GCE],m42[GCE],m43[GCE],m44[GCE],multiply(),rotate(),rotateAxisAngle(),"
                 + "rotateFromVector(),scale(),scale3d(),scaleNonUniform(),skewX(),skewY(),"
                 + "toFloat32Array(),toFloat64Array(),toJSON(),toString(),transformPoint(),translate()")
+    @HtmlUnitNYI(CHROME = "a[GCE],b[GCE],c[GCE],constructor(),d[GCE],e[GCE],f[GCE],flipX(),flipY(),"
+                + "inverse(),is2D[GCE],m11[GCE],m12[GCE],m13[GCE],m14[GCE],"
+                + "m21[GCE],m22[GCE],m23[GCE],m24[GCE],m31[GCE],m32[GCE],m33[GCE],m34[GCE],"
+                + "m41[GCE],m42[GCE],m43[GCE],m44[GCE],multiply(),rotate(),rotateAxisAngle(),"
+                + "skewX(),skewY(),"
+                + "toFloat32Array(),toFloat64Array(),translate()",
+            EDGE = "a[GCE],b[GCE],c[GCE],constructor(),d[GCE],e[GCE],f[GCE],flipX(),flipY(),"
+                + "inverse(),is2D[GCE],m11[GCE],m12[GCE],m13[GCE],m14[GCE],"
+                + "m21[GCE],m22[GCE],m23[GCE],m24[GCE],m31[GCE],m32[GCE],m33[GCE],m34[GCE],"
+                + "m41[GCE],m42[GCE],m43[GCE],m44[GCE],multiply(),rotate(),rotateAxisAngle(),"
+                + "skewX(),skewY(),"
+                + "toFloat32Array(),toFloat64Array(),translate()",
+            FF = "a[GCE],b[GCE],c[GCE],constructor(),d[GCE],e[GCE],f[GCE],flipX(),flipY(),"
+                + "inverse(),is2D[GCE],m11[GCE],m12[GCE],m13[GCE],m14[GCE],"
+                + "m21[GCE],m22[GCE],m23[GCE],m24[GCE],m31[GCE],m32[GCE],m33[GCE],m34[GCE],"
+                + "m41[GCE],m42[GCE],m43[GCE],m44[GCE],multiply(),rotate(),rotateAxisAngle(),"
+                + "skewX(),skewY(),"
+                + "toFloat32Array(),toFloat64Array(),translate()",
+            FF_ESR = "a[GCE],b[GCE],c[GCE],constructor(),d[GCE],e[GCE],f[GCE],flipX(),flipY(),"
+                + "inverse(),is2D[GCE],m11[GCE],m12[GCE],m13[GCE],m14[GCE],"
+                + "m21[GCE],m22[GCE],m23[GCE],m24[GCE],m31[GCE],m32[GCE],m33[GCE],m34[GCE],"
+                + "m41[GCE],m42[GCE],m43[GCE],m44[GCE],multiply(),rotate(),rotateAxisAngle(),"
+                + "skewX(),skewY(),"
+                + "toFloat32Array(),toFloat64Array(),translate()")
     public void domMatrixReadOnly() throws Exception {
         testString("", "new DOMMatrixReadOnly()");
     }
@@ -18417,6 +18441,22 @@ public void domMatrixReadOnly() throws Exception {
                 + "m43[GSCE],m44[GSCE],multiplySelf(),preMultiplySelf(),rotateAxisAngleSelf(),"
                 + "rotateFromVectorSelf(),rotateSelf(),scale3dSelf(),scaleSelf(),"
                 + "setMatrixValue(),skewXSelf(),skewYSelf(),translateSelf()")
+    @HtmlUnitNYI(CHROME = "a[GSCE],b[GSCE],c[GSCE],constructor(),d[GSCE],e[GSCE],f[GSCE],invertSelf(),"
+                + "m11[GSCE],m12[GSCE],m13[GSCE],m14[GSCE],m21[GSCE],m22[GSCE],m23[GSCE],"
+                + "m24[GSCE],m31[GSCE],m32[GSCE],m33[GSCE],m34[GSCE],m41[GSCE],m42[GSCE],"
+                + "m43[GSCE],m44[GSCE]",
+            EDGE = "a[GSCE],b[GSCE],c[GSCE],constructor(),d[GSCE],e[GSCE],f[GSCE],invertSelf(),"
+                + "m11[GSCE],m12[GSCE],m13[GSCE],m14[GSCE],m21[GSCE],m22[GSCE],m23[GSCE],"
+                + "m24[GSCE],m31[GSCE],m32[GSCE],m33[GSCE],m34[GSCE],m41[GSCE],m42[GSCE],"
+                + "m43[GSCE],m44[GSCE]",
+            FF = "a[GSCE],b[GSCE],c[GSCE],constructor(),d[GSCE],e[GSCE],f[GSCE],invertSelf(),"
+                + "m11[GSCE],m12[GSCE],m13[GSCE],m14[GSCE],m21[GSCE],m22[GSCE],m23[GSCE],"
+                + "m24[GSCE],m31[GSCE],m32[GSCE],m33[GSCE],m34[GSCE],m41[GSCE],m42[GSCE],"
+                + "m43[GSCE],m44[GSCE]",
+            FF_ESR = "a[GSCE],b[GSCE],c[GSCE],constructor(),d[GSCE],e[GSCE],f[GSCE],invertSelf(),"
+                + "m11[GSCE],m12[GSCE],m13[GSCE],m14[GSCE],m21[GSCE],m22[GSCE],m23[GSCE],"
+                + "m24[GSCE],m31[GSCE],m32[GSCE],m33[GSCE],m34[GSCE],m41[GSCE],m42[GSCE],"
+                + "m43[GSCE],m44[GSCE]")
     public void domMatrix() throws Exception {
         testString("", "new DOMMatrix()");
     }
diff --git a/src/test/java/org/htmlunit/javascript/host/dom/DOMMatrixReadOnlyTest.java b/src/test/java/org/htmlunit/javascript/host/dom/DOMMatrixReadOnlyTest.java
@@ -1183,6 +1183,7 @@ public void multiplyAssociativity() throws Exception {
 
         loadPageVerifyTitle2(html);
     }
+
     /**
      * @throws Exception on test failure
      */

Original file line number	Diff line number	Diff line change
`@@ -441,6 +441,7 @@ public double getF() {`
`441`	`441`	`public void setF(final double f) {`
`442`	`442`	`super.setM42(f);`
`443`	`443`	`}`
	`444`	`+`
`444`	`445`	`/**`
`445`	`446`	`* @return inverts the original matrix. If the matrix cannot be inverted,`
`446`	`447`	`* the new matrix's components are all set to NaN and its is2D property is set to false.`
Original file line number	Diff line number	Diff line change
`@@ -1183,6 +1183,7 @@ public void multiplyAssociativity() throws Exception {`
`1183`	`1183`
`1184`	`1184`	`loadPageVerifyTitle2(html);`
`1185`	`1185`	`}`
	`1186`	`+`
`1186`	`1187`	`/**`
`1187`	`1188`	`* @throws Exception on test failure`
`1188`	`1189`	`*/`